Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 21:20:57 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Danilo Krummrich <dakr@redhat.com>
Cc:     airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de,
        mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com,
        bskeggs@redhat.com, matthew.brost@intel.com,
        boris.brezillon@collabora.com, alexdeucher@gmail.com,
        ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org,
        jason@jlekstrand.net, dri-devel@lists.freedesktop.org,
        nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-next v4 14/14] drm/nouveau: debugfs: implement DRM
 GPU VA debugfs
Message-ID: <20230614012057.jhyzdliloui5k7yx@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org,
        corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com,
        matthew.brost@intel.com, boris.brezillon@collabora.com,
        alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com,
        willy@infradead.org, jason@jlekstrand.net,
        dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230606223130.6132-1-dakr@redhat.com>
 <20230606223130.6132-15-dakr@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230606223130.6132-15-dakr@redhat.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m+Ea8tOAKQ+Oy20gfRTtjNrkqjl7VJsGnjILWR1McOiQpuEJz+t6JgI3he6K?=
 =?us-ascii?Q?QALNjV5lvazzde6RuqEv8ZsJ4AeuWOpcNdmtMbZ4yXtQMRT6ojcuqhlZzpEx?=
 =?us-ascii?Q?pljzgp/WZx6ho5+uzGXkxPXxiB0vzi6QtY90rM0K1pgDm2aLdwiBLdDCMP91?=
 =?us-ascii?Q?D8sIeyLpBrLW69C8AtK25cSYbxo77rp6qrTxiH8uzmYPOl6fjyqXbcW4VHMR?=
 =?us-ascii?Q?Z6WgdcLIJ/XH0LyGJLFd6vnErGYvf1FSetQIBbPv5qSOObLnUy2BL7D9673H?=
 =?us-ascii?Q?7gvW4AphykkuMj79tcnL0sjx/N+35j0dcIwBFHxoWdv2DGcESzShGxsNnR0k?=
 =?us-ascii?Q?R33jBfYograCXIJGFhVOVXtDyuq+xMt60I8NOeKuwfljJIFelEiAVtWog9Qg?=
 =?us-ascii?Q?NHGoxZDvGLLIu0Vx6CL8mui92atr3DlpOEC9BC8jgomvwWuDHOGGR4fauDhU?=
 =?us-ascii?Q?oWFKUPHsyOR1884jeht7IqLgjYdVd0Ud2y8VzP9UtFgNWQFr+2vQ32HHYM4v?=
 =?us-ascii?Q?PJIFCVKFmq51J4OLDpD91E8sOCeeBPj5b0PW2Iqbb7RIde+rWc4YcO5t9Mec?=
 =?us-ascii?Q?tFAJKGHmeUAnUau4pj5NhGUs8p8N0RRKnEAdfhQAQPNjdavnZhiAYRYzcqvP?=
 =?us-ascii?Q?1a2HpEbcMZErIJKT0R5pW3RlabjY0nS1djxf/Q+m4xo9OSswdQp6LiJTq/z2?=
 =?us-ascii?Q?D1rqCCFWeSUGQOLaiy9Q4MWgO5Ws7h3gcU37+YE1wrJskRqMmD8WVLbP/yVW?=
 =?us-ascii?Q?4WftPxt+jW1l2AN31/D6Om9xJVt2ep/0TUHyt7qG2kwjmxpL7lCCrUsE9I31?=
 =?us-ascii?Q?eAw5v+8jzl9+3J8NzpKx6INjHFkt9mxNlfeO3gmJvVPIaYn++Md1WWjTVJVa?=
 =?us-ascii?Q?VYsP9MkZ+kd0Cx0gK4Mz2NZBEGBMcxYIQ/z/e1tqvws45SjjBZxk7BQLbP6r?=
 =?us-ascii?Q?zkKfi6bNsxu++iP8fLvTeHADpRKiaFqUnOpQL/zMhSve1i8MOsl5qEfi7iyJ?=
 =?us-ascii?Q?FgINW4WkO6gjLpzcOB8g65o/ezHssC/j/26AU4eIAZzQaNgxaRSQOtVU5Hl/?=
 =?us-ascii?Q?Ww/to7/iVfhvFHc/pw/2VseyGnr9YAAa6XddPIS2QV7DdKelVUVBlJrUMMc6?=
 =?us-ascii?Q?8oN7ouAgp2mNcnVhp/o3Fw2g7koBtUZiQG6CTsuGxrkWNKSbaC9USplh5c4E?=
 =?us-ascii?Q?7Kocnkx37sehpdTSwCCs9+at6+2iztmLCtEAmBipt51bsXPv5CZUSwhRZeFM?=
 =?us-ascii?Q?hszIvaw3MebcHUELilMIohUYrPWv9gxO+/bnUmHgJUVSTO5F6hz3ghSZepPD?=
 =?us-ascii?Q?Y+r1ffsp+uwSJbeV4wir1lHrs7fzLkWugT7NCaUV0tRVUj7q08LUKn56BrlV?=
 =?us-ascii?Q?WMZG/xQ2BpvT58fKERWalQYRvjBv3KXz19SJ54nN3n/DkDvfnYTSZYOJdZFp?=
 =?us-ascii?Q?aPMt4MamAk/dCoTUP0VHq5rg0z6e5DfbCrgtfEdf/WKCFohXm+j2Ybsllpy5?=
 =?us-ascii?Q?jYy382siFnsCQ6EXPXJ3P9ShdVq+u6iPEIUw9Y6/wSLZHPbbPEoUJC4zfwSt?=
 =?us-ascii?Q?uWhY3qwewYjHaWOjDthtNRJ9WKPmcZJKiorOLmK6yKLC42/Ty8mZJAcx1pCA?=
 =?us-ascii?Q?Sg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?jnGOzA4bC2g+sJnur02KbNMtglRqaaHBFtBSJKXFg81v1WFWgMEG8kPHu571?=
 =?us-ascii?Q?unwOkNCY9a6vTpKIobB1f33NuvwcNyQCoPdioMNNm1Gpv/RZekkkJNUJcs6j?=
 =?us-ascii?Q?O9kaJ8cnxG8OgQsjzyhVLcuko0vYj3vY5SEmD6rEdWxfmu0niDks3IXfJDF0?=
 =?us-ascii?Q?ZgdgtyRbyX77Yjy9ad3B8+EChR7DuJrvV4Mo0YR7ehQCa9VGla8tTwRi3nCV?=
 =?us-ascii?Q?0n8xfeWZCzBitSADNNTGu1B8QyyCvj4tz332cWXAhlVfjByCeTKXnn8n3F50?=
 =?us-ascii?Q?o3DwZqROi9ih43WdBHOtVpTMt/BULZweOQLkk6CKMUXlb3eoZyMuKRraPPmJ?=
 =?us-ascii?Q?noq+6VO8L2qFT7LfOIPlRCDRqhNlnmaqZPMe6SwW/qfQ2LEHgWMRl7ub3nHm?=
 =?us-ascii?Q?tWclaI4xDh+3muliDTR5rZ9vaKk9KDFzjkGi1JXmNdlp9Cvgpo+JVZxECo4L?=
 =?us-ascii?Q?YNSCBf0AIQzPG+iKYBQ9rnqxJfBUKZBa7fs2yJ9s47lCGFKXevd+uEmHqQdR?=
 =?us-ascii?Q?lRABLdjZy0SKNygqzkeI9TsoHoR12kA0HiPx8rwz1InepZlEk/ByVy0VJivu?=
 =?us-ascii?Q?mzEaXg4pQ4NQ+rYgujOj03NT31Jij7Nud5e1tJPNYz3JmFvsTek2lMLVgkp7?=
 =?us-ascii?Q?oHRRnzmj5FRxDrZVEYbKPzwHLws9DaMixluGCW6obdYNIM+2g4f6nbu3cpP+?=
 =?us-ascii?Q?72by4ko++Pds1y+nwl34O7yFdGcR6X9ii4JR3CslF7ryPUtyKiBSG4tbYRmb?=
 =?us-ascii?Q?0IeVX00tbfrLpqtg0v7twyF/idpmjVt0fs8d7ZgeG2/Cmujc9GUoj6ub2IKB?=
 =?us-ascii?Q?j8C+hTcV0IwUENQYal1MNcuyIMWlU+FMvhKeb6Am7J39zDQyerueXIN7tTMA?=
 =?us-ascii?Q?zfeo+5E1/Ye5eK61S1oNNDr0VlFcG9kpqWQm6IVVPDPZOOblP36FkoC7ydZL?=
 =?us-ascii?Q?x40dVjuqam6vD2691qvk1y7ALfjQlgM8Bdlfq7ZqSEsFr1xpVGM7K8L/d5za?=
 =?us-ascii?Q?1jhgMCQv6B+lHB9vOBGZg6TkRT9WUQQr/ygPwt1WhJTDgeRmkJq/ualrIjRf?=
 =?us-ascii?Q?d8Tyk4cELgK5R/ae9cvcpmNcAR5Uw+iPJCrdPZPQtCNKuBboLhc8iFqk6FQ0?=
 =?us-ascii?Q?4/MhwTsc3QGs3OfD3jGFfb1BDTJxu50xdw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c31576c4-f838-4879-a34c-08db6c759d2d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 01:21:00.8453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YwxY0mZQR/vMisQq7XBrQxuH6vVw/YUJkr2BIPuSO2XNMscdy/AOkU8ityMlPWF6Gk79pctORYLK+AGDEMRBzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-13_24,2023-06-12_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306140008
X-Proofpoint-ORIG-GUID: rJdYf5tANraTRlwaW5hFRC3vxYssYZ8J
X-Proofpoint-GUID: rJdYf5tANraTRlwaW5hFRC3vxYssYZ8J
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Danilo Krummrich <dakr@redhat.com> [230606 18:32]:
> Provide the driver indirection iterating over all DRM GPU VA spaces to
> enable the common 'gpuvas' debugfs file for dumping DRM GPU VA spaces.
> 
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_debugfs.c | 39 +++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> index 99d022a91afc..053f703f2f68 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> @@ -203,6 +203,44 @@ nouveau_debugfs_pstate_open(struct inode *inode, struct file *file)
>  	return single_open(file, nouveau_debugfs_pstate_get, inode->i_private);
>  }
>  
> +static void
> +nouveau_debugfs_gpuva_regions(struct seq_file *m, struct nouveau_uvmm *uvmm)
> +{
> +	MA_STATE(mas, &uvmm->region_mt, 0, 0);
> +	struct nouveau_uvma_region *reg;
> +
> +	seq_puts  (m, " VA regions  | start              | range              | end                \n");
> +	seq_puts  (m, "----------------------------------------------------------------------------\n");

rcu_read_lock();

> +	mas_for_each(&mas, reg, ULONG_MAX)
> +		seq_printf(m, "             | 0x%016llx | 0x%016llx | 0x%016llx\n",
> +			   reg->va.addr, reg->va.range, reg->va.addr + reg->va.range);

rcu_read_unlock();

> +}
> +
> +static int
> +nouveau_debugfs_gpuva(struct seq_file *m, void *data)
> +{
> +	struct drm_info_node *node = (struct drm_info_node *) m->private;
> +	struct nouveau_drm *drm = nouveau_drm(node->minor->dev);
> +	struct nouveau_cli *cli;
> +
> +	mutex_lock(&drm->clients_lock);
> +	list_for_each_entry(cli, &drm->clients, head) {
> +		struct nouveau_uvmm *uvmm = nouveau_cli_uvmm(cli);
> +
> +		if (!uvmm)
> +			continue;
> +
> +		nouveau_uvmm_lock(uvmm);
> +		drm_debugfs_gpuva_info(m, &uvmm->umgr);
> +		seq_puts(m, "\n");
> +		nouveau_debugfs_gpuva_regions(m, uvmm);
> +		nouveau_uvmm_unlock(uvmm);
> +	}
> +	mutex_unlock(&drm->clients_lock);
> +
> +	return 0;
> +}
> +
>  static const struct file_operations nouveau_pstate_fops = {
>  	.owner = THIS_MODULE,
>  	.open = nouveau_debugfs_pstate_open,
> @@ -214,6 +252,7 @@ static const struct file_operations nouveau_pstate_fops = {
>  static struct drm_info_list nouveau_debugfs_list[] = {
>  	{ "vbios.rom",  nouveau_debugfs_vbios_image, 0, NULL },
>  	{ "strap_peek", nouveau_debugfs_strap_peek, 0, NULL },
> +	DRM_DEBUGFS_GPUVA_INFO(nouveau_debugfs_gpuva, NULL),
>  };
>  #define NOUVEAU_DEBUGFS_ENTRIES ARRAY_SIZE(nouveau_debugfs_list)
>  
> -- 
> 2.40.1
>