Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using
 cpumask_weight_and()
To:     Phil Auld <pauld@redhat.com>, <bristot@redhat.com>,
        <vschneid@redhat.com>, <dietmar.eggemann@arm.com>,
        <quic_mojha@quicinc.com>
CC:     <mingo@redhat.com>, <peterz@infradead.org>,
        <juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
        <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
        <bsegall@google.com>, <mgorman@suse.de>, <bristot@redhat.com>,
        <vschneid@redhat.com>, <linux-kernel@vger.kernel.org>
References: <20230522115605.1238227-1-linmiaohe@huawei.com>
 <7bfde912-1e15-ec1f-8a62-9cc508739cd6@huawei.com>
 <20230613131651.GA536267@lorien.usersys.redhat.com>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <1d5e80c1-69e6-e2e8-a5d1-6117cb661013@huawei.com>
Date:   Wed, 14 Jun 2023 09:43:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20230613131651.GA536267@lorien.usersys.redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/6/13 21:16, Phil Auld wrote:
> On Tue, Jun 13, 2023 at 08:19:22PM +0800 Miaohe Lin wrote:
>> On 2023/5/22 19:56, Miaohe Lin wrote:
>>> cpumask_weight_and() can be used to count of bits both in rd->span and
>>> cpu_active_mask. No functional change intended.
>>>
>>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>>
>> friendly ping... :)
> 
> This looks reasonable, and better, to me.
> 
> Reviewed-by: Phil Auld <pauld@redhat.com>

Many thanks for all of your reviews. :)

> 
>>
>>> ---
>>>  kernel/sched/deadline.c | 11 +----------
>>>  1 file changed, 1 insertion(+), 10 deletions(-)
>>>
>>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>>> index 166c3e6eae61..fe983ed7bb12 100644
>>> --- a/kernel/sched/deadline.c
>>> +++ b/kernel/sched/deadline.c
>>> @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
>>>  static inline int dl_bw_cpus(int i)
>>>  {
>>>  	struct root_domain *rd = cpu_rq(i)->rd;
>>> -	int cpus;
>>>  
>>>  	RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
>>>  			 "sched RCU must be held");
>>>  
>>> -	if (cpumask_subset(rd->span, cpu_active_mask))
>>> -		return cpumask_weight(rd->span);
>>> -
>>> -	cpus = 0;
>>> -
>>> -	for_each_cpu_and(i, rd->span, cpu_active_mask)
>>> -		cpus++;
>>> -
>>> -	return cpus;
>>> +	return cpumask_weight_and(rd->span, cpu_active_mask);
>>>  }
>>>  
>>>  static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
>>>
>>
>