Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Wang Ming <machel@vivo.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH] drivers/dcn32:improve-warning-messsge-for-dummy_latency_index
Date:   Wed, 14 Jun 2023 10:46:38 +0800
Message-Id: <20230614024718.480-1-machel@vivo.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kOkVpoN1Pm7/u4o05KI6c3GquapMlLQ94oOU2BXIjcobmUPdgesPd4XlrD4I?=
 =?us-ascii?Q?f1VsxIOJy6JA0YGUg1Ok535YhFoo5jAmRd0rGKMbtNlRxcZeg83Y8MH9K1oD?=
 =?us-ascii?Q?P34x2KRPtvAtuSDkcFVme0lr+EUJFrSoa4F7FHMUy2jJw9ODzuXkSm1tgsP9?=
 =?us-ascii?Q?p/mRJazW23RRS8Cs1cjDyFNqbIho/m/pwTji/SnuGIUDcxxlaH6zkM2cuzFK?=
 =?us-ascii?Q?dGv+pwRWAPWJma9AbFFNlPg54tnV3J7KAIcAO42BTpdBd8HXagdNanZZEnkM?=
 =?us-ascii?Q?IhBAQCysvF9F7zqvNuqPrcsm7g8hL7S+vslIhkf7IK7dapYySjCVeEXCykyb?=
 =?us-ascii?Q?B+NNYl7jyzlZLWFv9TGtAoPKBKhipXam93RckU5VRNPwLjgfezRB0Ua1o4zb?=
 =?us-ascii?Q?5vlNEIQCni6pKYblcFFKNSVrTP8Ysc7viU77WJexJSv15RMnfOn4jyi2fENr?=
 =?us-ascii?Q?foh3jRn7t5JUpC0T1yn0sr+fX+MJ1oRC4c8hd+jKHMQVeQXgUtm5zSYGa0Mc?=
 =?us-ascii?Q?cwFL26Qcwm5NbPJ6WM5rcyDOKIl4l2Rcq/gQYto+h+5PyQDXSLs1Kc6ts63z?=
 =?us-ascii?Q?XaEccTBtB3hMNXDO736TNUbYQJYNlhymY6R2dtc4qqGUppZVCoYvXmXb13L1?=
 =?us-ascii?Q?Gd/QKAgHrIN/+QuICndzZLOpKWMRZsDHnL0jKadXBhpvqlTa6LuDs17mP2a+?=
 =?us-ascii?Q?gSDXlA11n9AE7Nwbnms6a563T4T7L6sE6pLFwMwc9i38ddtRTPPqvdDWdvpf?=
 =?us-ascii?Q?352arf1WKdavGBmLMktO3iNojYgBuntvKN88O8MWFspMXHH2/oTM+JcnuC3Y?=
 =?us-ascii?Q?nFij2iHpvvTiAvj+FZ2GbqbewX8g5ovjViH+ndRCwpuzYFmFtepQfqeDjYXG?=
 =?us-ascii?Q?Uquqhb+psGhMCcHcFwLAPeE4LQVod0XgmV5AQ17TICNrxVd1fyLocpaUC5tq?=
 =?us-ascii?Q?QngBGjIotrZFukPK6yFnCXvq6MsrasI9J8MQo48Wwl0YOmqOTz4q8VAOlo4z?=
 =?us-ascii?Q?5gc/mGB0JIVy8vjEBUTDyu+1KOyUduFMpgBpXxfZTWL8y5s3VHUfPFjr8hmQ?=
 =?us-ascii?Q?E4ESFysgcycefv18wEKnMYFnqDSt39EMmiiHHuB1mu67D6sBdKrBCte5YIVu?=
 =?us-ascii?Q?pdWY+uy/GzbWFXkoig5+W4iYw0tu/XG86uh9VzqPs/ZgzNgJzNArvuLTDc/0?=
 =?us-ascii?Q?W51oxuaSHx01vQ1B9djwivF2LnArEZG1Jmk5snC3bPaOOPRy+4mFF/s6hu1u?=
 =?us-ascii?Q?CR4hFDifjGQd6uz5sXR7G4Kb2B47nRsGftWrpopYh9mOqzkGYg2jzh9QTC30?=
 =?us-ascii?Q?iZvTK8UUYcydqyKLwAdWeFILoWWJcGPrcaREWdEVO1T2wG9Sqem83GbSOeDj?=
 =?us-ascii?Q?2nEiMqjSNJ1IU1bGCixzYdJ7bxCnP3NE5S43fr4D5L5geKcUxqi++h/zovIA?=
 =?us-ascii?Q?DMOyzs7jWI4iDSTdFrJh5kgJ4Ngxd+L5BSRproN4m+V818uqeNdPkudEFbd6?=
 =?us-ascii?Q?yunYf7BJ3IR+JEpmSAMpB3/rUQ8CbihqJaFsVzu6w+IvfSfT4TKjKs4AdGLf?=
 =?us-ascii?Q?dSTC0vr+BXle4TgKttFE1Bv8p9SJIcVhcdWDYnNR?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93db3923-a61b-4ec7-dc65-08db6c81c09a
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 02:47:54.3205
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z9V8C8QG5HHLmacam1+7pQEIAOZdKQ8gcRlNdim6CSYsuEFB/o86P4XZYlZOr42OMrAhvoYoSI7YLVThvE5H3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5583
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 Unsigned expression compared with zero:
dummy_latency_index > 0.The return data type of the function is also int
For rigor,it is necessary to replace the data type unsigned int with int.
Otherwise,if there is a negative number,the consequences will be
disastrous.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c b/drivers=
/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
index ad6ee4858..e351357ff 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
@@ -1941,7 +1941,7 @@ void dcn32_calculate_wm_and_dlg_fpu(struct dc *dc, st=
ruct dc_state *context,
        double dcfclk_from_fw_based_mclk_switching =3D dcfclk_from_validati=
on;
        bool pstate_en =3D context->bw_ctx.dml.vba.DRAMClockChangeSupport[v=
level][context->bw_ctx.dml.vba.maxMpcComb] !=3D
                        dm_dram_clock_change_unsupported;
-       unsigned int dummy_latency_index =3D 0;
+       int dummy_latency_index =3D 0;
        int maxMpcComb =3D context->bw_ctx.dml.vba.maxMpcComb;
        unsigned int min_dram_speed_mts =3D context->bw_ctx.dml.vba.DRAMSpe=
ed;
        bool subvp_in_use =3D dcn32_subvp_in_use(dc, context);
--
2.25.1


________________________________
=E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=86=85=E5=
=AE=B9=E5=8F=AF=E8=83=BD=E5=90=AB=E6=9C=89=E6=9C=BA=E5=AF=86=E5=92=8C/=E6=
=88=96=E9=9A=90=E7=A7=81=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E4=BE=9B=E6=8C=
=87=E5=AE=9A=E4=B8=AA=E4=BA=BA=E6=88=96=E6=9C=BA=E6=9E=84=E4=BD=BF=E7=94=A8=
=E3=80=82=E8=8B=A5=E6=82=A8=E9=9D=9E=E5=8F=91=E4=BB=B6=E4=BA=BA=E6=8C=87=E5=
=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=E6=88=96=E5=85=B6=E4=BB=A3=E7=90=86=E4=BA=
=BA=EF=BC=8C=E8=AF=B7=E5=8B=BF=E4=BD=BF=E7=94=A8=E3=80=81=E4=BC=A0=E6=92=AD=
=E3=80=81=E5=A4=8D=E5=88=B6=E6=88=96=E5=AD=98=E5=82=A8=E6=AD=A4=E9=82=AE=E4=
=BB=B6=E4=B9=8B=E4=BB=BB=E4=BD=95=E5=86=85=E5=AE=B9=E6=88=96=E5=85=B6=E9=99=
=84=E4=BB=B6=E3=80=82=E5=A6=82=E6=82=A8=E8=AF=AF=E6=94=B6=E6=9C=AC=E9=82=AE=
=E4=BB=B6=EF=BC=8C=E8=AF=B7=E5=8D=B3=E4=BB=A5=E5=9B=9E=E5=A4=8D=E6=88=96=E7=
=94=B5=E8=AF=9D=E6=96=B9=E5=BC=8F=E9=80=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4=BA=
=BA=EF=BC=8C=E5=B9=B6=E5=B0=86=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6=E3=80=81=
=E9=99=84=E4=BB=B6=E5=8F=8A=E5=85=B6=E6=89=80=E6=9C=89=E5=A4=8D=E6=9C=AC=E5=
=88=A0=E9=99=A4=E3=80=82=E8=B0=A2=E8=B0=A2=E3=80=82
The contents of this message and any attachments may contain confidential a=
nd/or privileged information and are intended exclusively for the addressee=
(s). If you are not the intended recipient of this message or their agent, =
please note that any use, dissemination, copying, or storage of this messag=
e or its attachments is not allowed. If you receive this message in error, =
please notify the sender by reply the message or phone and delete this mess=
age, any attachments and any copies immediately.
Thank you