Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614033437.48549-1-luojianhong@cdjrlc.com> <475df60d9dd518e20ae9df396c60b69b@208suo.com>
In-Reply-To: <475df60d9dd518e20ae9df396c60b69b@208suo.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 13 Jun 2023 21:43:32 -0700
Message-ID: <CAP-5=fWtrQABXFnuAQWEuaFcvXJ5gaKf=gZUyTLqm8-aY9znrQ@mail.gmail.com>
Subject: Re: [PATCH] perf bench: remove unneeded variable
To:     baomingtong001@208suo.com
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 13, 2023 at 8:38=E2=80=AFPM <baomingtong001@208suo.com> wrote:
>
> fix the following coccicheck warning:
>
> tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err".
> Return "0".
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>   tools/perf/bench/find-bit-bench.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/find-bit-bench.c
> b/tools/perf/bench/find-bit-bench.c
> index 7e25b0e413f6..70619bc73841 100644
> --- a/tools/perf/bench/find-bit-bench.c
> +++ b/tools/perf/bench/find-bit-bench.c
> @@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int
> num_bits)
>
>   int bench_mem_find_bit(int argc, const char **argv)
>   {
> -    int err =3D 0, i;
> +    int i;
>
>       argc =3D parse_options(argc, argv, options, bench_usage, 0);
>       if (argc) {
> @@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
>       for (i =3D 1; i <=3D 2048; i <<=3D 1)
>           do_for_each_set_bit(i);
>
> -    return err;
> +    return 0;
>   }