Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <23dc1c47-88ee-6b2d-1a5a-d6c812bb1761@intel.com>
Date:   Tue, 13 Jun 2023 22:03:29 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>,
        "Nikolay Borisov" <nik.borisov@suse.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Russell King <linux@armlinux.org.uk>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-ia64@vger.kernel.org>,
        "Huacai Chen" <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>, <loongarch@lists.linux.dev>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        <linux-m68k@lists.linux-m68k.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        <linux-mips@vger.kernel.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>,
        "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
        <linux-sh@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        <sparclinux@vger.kernel.org>,
        "Richard Weinberger" <richard@nod.at>,
        Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        <linux-um@lists.infradead.org>,
        Richard Henderson <richard.henderson@linaro.org>,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Chris Zankel <chris@zankel.net>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <20230613223827.532680283@linutronix.de>
 <20230613224545.902376621@linutronix.de>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
Subject: Re: [patch 17/17] x86/fpu: Move FPU initialization into
 arch_cpu_finalize_init()
In-Reply-To: <20230613224545.902376621@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTJDNk10RTJtV2pMR012UHdnamtIY0MxZHFWTXY5S3UyMzFvbnFCVGJUcjg0?=
 =?utf-8?B?TWgrTWR5eGQxTmlHMmlLUU00Wk1NYjMrc1RhWmxMcU53YWFaTERvQ0xDNlBK?=
 =?utf-8?B?aExhQ1AxN2VQS0xVY3grT3YzM2R6SFhlTGg4WkVCTktjazUwMUhuZFY0bWp0?=
 =?utf-8?B?VjdDMnkzZHB4RHVhbVJ1OTR6aGJBRHdQWWJtVldhRW1jY3p1L3lIdFZJSEVU?=
 =?utf-8?B?S0dGQnF5WUJFM1VsYitNdS9DdXBsTGVlVTMrYUU4YXRXcU45UU9NVG5xSHE2?=
 =?utf-8?B?TE5Zd0VUTG9xM1d6TUhQNWw5WlZaajFMeFhPOFgxbHF6U3BDM21CYWlrMnNP?=
 =?utf-8?B?RGR2VGJ2QWRFWUlRUUgreUEyNDNtNmc0c1hGWk53NElabTdaRUdOako3M0NI?=
 =?utf-8?B?S2hhUy9HU1kvNmVkdDhOdXZoYWN3elk2MEpCdk94TWh1SVNtRDBLTFNwK3l1?=
 =?utf-8?B?M0lEWFQrTXQwWHk3OTBXVkNzbzdReXBlQk83MVNsdWIxeGt3RDhZRXVrOEla?=
 =?utf-8?B?bnFBbkZpNVM4WGxPeWVGUTNqbms4VEhtRmNydnRXMG1ESERxQkFLanNpQksx?=
 =?utf-8?B?K0tKK2xTNDdQOHQ3K1VxaW1OMG1GSjBwMkVVeDhta3ZmcmQrYmVKbW9oUlRG?=
 =?utf-8?B?UzZiMnY0ei9qTkFXWUNmOCtSeDFnTlZuZ05zNmdaSi94NDNUTnJUeGpsTEFV?=
 =?utf-8?B?RlBqVUZWbWFxRVZsNXVwdEIyQzRBcHNzRTlOVndHTmhuZTZTTFNmYnBON3RU?=
 =?utf-8?B?azVocFM3V0RzbHhoMDFHNkpwRXE2SzdvTXVYTURmOENLSi9jQVdxMkJ6eFdr?=
 =?utf-8?B?Vk82N1QyTmhLSlJkWkthcTllem03WTBHT3RRMVJYdjRoYXp3b0ErK0RoSUsx?=
 =?utf-8?B?eFNHMHV4d0NHUHN4ODdxVkVTQ2szUnh1c3N1bml5aWYvR3BNQWlNZGlOWlZo?=
 =?utf-8?B?U3JCeTNDQWhleUp1dTNKMlA0NHBsZFVYMENieUM1aTc5OFEveGdiNEZKQitp?=
 =?utf-8?B?WDlUT2I1ckd4cXNGZmhMZFpHZkVXTi9qZkJETDJRbEh2dE1tTURvTm1wNExh?=
 =?utf-8?B?MmYzVVhaT1RWRUV4MFVnbE1aNEl4alpmNUZ1VS9Ya1FFeTF6MExMRkY4bEty?=
 =?utf-8?B?Zys0WFFPdTVPTmpjTUs4TGhhQk9uTnJOMmJpS3plV0VyVlVTT3l1b3owcW40?=
 =?utf-8?B?REZJU2Jyb1ZwTGJEUkNJdTdqS1hMSGR3WFkra3BaRlExemtubmVSQ0YzUVlN?=
 =?utf-8?B?a3NRYXQrRm1BbXU3OURzcHJRTWwxV0ZVSGExcHNWRlUwVCtXMFBpbW5Ua3Yx?=
 =?utf-8?B?Um5NZlkzcGFqMVJ6QzhKVnR5OGV3ZTE1WVJVYXJRN1Byb1dsdHJFSTROOUlk?=
 =?utf-8?B?Yyt6T3N1MTk1UHNuUnJRSGhsUDlXWGdjTEtKV3pvSXZucmxBK1BQQUdGZkd0?=
 =?utf-8?B?T3A4TjBKcWIyZXdiZUJTbHFMNzBReE5IT0JYVGNRUUEwK1hQUThZcW5tcU9L?=
 =?utf-8?B?NW9xeHVVSFB5TTlhUDZSUzY5YlNRTVJwcHVmdWZZeURWM1RxVjZML2hoc2I5?=
 =?utf-8?B?YWxtU2toTjdZYzhwYTg5WDFFV3A5MWhteTZlQnQrM0NZUFBQWTkwSHZ3THM0?=
 =?utf-8?B?cWw2d1RjYjVvV1AyTDRYTEw3LzV1dERHS0xpbHRBZFdDd1pMMHJxemtTZTA5?=
 =?utf-8?B?a1cwdXNzTjlsRTNYbVhpS0dZV2VuVHhPQm1RamtGY3FDTGdmVlF3bzN5NG1n?=
 =?utf-8?B?elZYTXFjUFVHdnkreDJ0YmpERktLbUxqSTNGZldCVFIyaXN3VnZzQkNLWXp1?=
 =?utf-8?B?TEZEd1FiZGF2TlNxL212U1JJWHppaHlYSmd0bmlUc09NbGJESkFNRUc4MnQ3?=
 =?utf-8?B?eDlRWEdHM1lvYXFJMjJGUXdkdGQ1UXVQcEtFOWswYUd4bjF1RnRCbU9KbDZG?=
 =?utf-8?B?VGJRcXlpa09uY3VLcFF3QS96WGs3MGFrWU01cEljKzJabFI0SWpydFp6NGww?=
 =?utf-8?B?c1hPNXM3Tnoycy9IRnR4MHdJaVV5NWE4L0FPTEhoemlMbVUzY3pPQm1RM2ZR?=
 =?utf-8?B?L09JQVlYOHQyWVBjTGZkZkM5WkI1SmJiMytSZlp3R1EzSWJ6SHlIUERsRmxC?=
 =?utf-8?B?aTF2d3pJWXNGYTVDdkROMEwxcVlRYTBEcVh3SW1jWlFlOC9mMDBUQzgzbTFW?=
 =?utf-8?B?ZWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9876c98c-4192-4147-96d9-08db6c94b384
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 05:03:32.8606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d46p/S7Yr//r4uFBzUR70vDqh7oPaCC+qJ5cPwIvNYfOh/ApB+MYoTtZ5hY7e2tejjHbjdjimqR0N7iZOrhJOKk7zikZPNFSp3vdJFA4VqE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5465
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/13/2023 4:39 PM, Thomas Gleixner wrote:
>   
> @@ -2396,6 +2393,13 @@ void __init arch_cpu_finalize_init(void)
>   			'0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);
>   	}
>   
> +	/*
> +	 * Must be before alternatives because it might set or clear
> +	 * feature bits.
> +	 */
> +	fpu__init_system();
> +	fpu__init_cpu();

fpu__init_cpu() appears to be duplicated here because fpu__init_system() 
invoked this already:

void __init fpu__init_system(void)
{
...
	/*
	 * The FPU has to be operational for some of the
	 * later FPU init activities:
	 */
	fpu__init_cpu();
...
}

https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/tree/arch/x86/kernel/fpu/init.c?h=init#n223

Thanks,
Chang