Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2252525rwd; Tue, 13 Jun 2023 23:32:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4pHfm1djJ80/9TdLzMeuoB7ehCByJIu6T1VZIV29kXKUVKHCW7m4/5/92UOWfPCxQ8qHrJ X-Received: by 2002:a17:907:169f:b0:96f:2b3f:61 with SMTP id hc31-20020a170907169f00b0096f2b3f0061mr15746825ejc.7.1686724337306; Tue, 13 Jun 2023 23:32:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686724337; cv=none; d=google.com; s=arc-20160816; b=ngU/kmPB1N6CV5yDN7ePd4VO9wvLoGHGuhrW427f/Z8hHN9LAIamTo5z/EvX9YzKUC /No5/Pf4LpcGIiZ6KmHJFQIsxh5bZ/8ci1rNrub+krca4YvMig2fZc9ce/mzLehlQOQj JdtT53KW1s1pE84JH0GLCACmngsl1q78/mMG9HgAdUMOFAoftG7aGVivT2UOLk8yuW/n Mnz+VfPuFsLF5cwIwjYe4Izw4pWMFSSzdcqO3eJHWq8xDqlma98FRF5WkQKL4LI5cemu OfUrAOVl1Y/USJyXnHkPIo09n0z0vrrDlp1SHCT5o+wX1R+0/PHh4K4AkELRoBUgd5HL J0RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Cpt7/j1iq5H8adWmH5F4O2jrSqEne7TQhNs0GXBvlgE=; b=AepwyiFT5xBxggKeHyg//0LKp73/UIiu/WGS2SU+tkSBcIU4T4eLNCPUx+33Al9Rcb sTh7xxUBy8cdJbS97T+nnssAouyfnAuHLOjA3+LbQFUXti0a7ZMI4hC/mhAU+M1SfaoO jY0UPRnZHGUIE39H1J5UL0rjZvERv5i4IC+YOMKFaA7OTjuFYBuZ2j8QogXyHj3RezFQ GTgwxM2kB12T2V3KNYoqhkrk4mgU5IMSsXIM4UWRk/H5J340Pc3KksU2IRgyeQcTyDmM YShadAfNXLJBPE7hTygfcbxujA6upNp2pbZbYRIhJQGCaRDhDn12OuAIwqZlQtp7ISuR wldg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=IkmNWvX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020aa7c50a000000b005149c18e773si8474354edq.399.2023.06.13.23.31.49; Tue, 13 Jun 2023 23:32:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=IkmNWvX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243076AbjFNGTN (ORCPT + 99 others); Wed, 14 Jun 2023 02:19:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243043AbjFNGTG (ORCPT ); Wed, 14 Jun 2023 02:19:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E4B01BC5; Tue, 13 Jun 2023 23:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Cpt7/j1iq5H8adWmH5F4O2jrSqEne7TQhNs0GXBvlgE=; b=IkmNWvX7rTEu3GicBPsUe2m6GE 4gzsY2YXVx6WAcZIicMeC2/dthCdRTGvuTqlNrZG+VY1tLtdsN7DlF0wmYsBYS48onBHjqydO1aMg +bZM+OczV1r9dvL7sCpmUc+KBmjHR7Hh887KzQp3v7+PiqY6mOXtW0d0eiL07G1Zd95X1T3IaOgF8 vcQHqljwgx0wbD4F5QHY256Ajtc5w9qOJdsgf2IM7dfkk5pRQ5d87n+VZJrnf9vdCNTxU3pk0H9im EGn5Fu2upztmZLqwqG9PwWBfrmuoSt3PD9DINQAOzet/cMe9oSloYqJXEL5KOSpZ9HuSs/+b73O/z Rbb8gl5A==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q9JqQ-00AOvi-1m; Wed, 14 Jun 2023 06:19:02 +0000 Date: Tue, 13 Jun 2023 23:19:02 -0700 From: Christoph Hellwig To: Ed Tsai Cc: axboe@kernel.dk, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kbusch@kernel.org, amergnat@baylibre.com, liusong@linux.alibaba.com, wsd_upstream@mediatek.com, peter.wang@mediatek.com, stanley.chu@mediatek.com, powen.kao@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, Chun-Hung.Wu@mediatek.com Subject: Re: [PATCH v3] blk-mq: check on cpu id when there is only one ctx mapping Message-ID: References: <20230614002529.6636-1-ed.tsai@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230614002529.6636-1-ed.tsai@mediatek.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This looks fine to me: Reviewed-by: Christoph Hellwig > - if (rq->mq_hctx->nr_ctx == 1 || > + if ((rq->mq_hctx->nr_ctx == 1 && > + rq->mq_ctx->cpu == raw_smp_processor_id()) || > rq->cmd_flags & REQ_POLLED) But please fix the incorrct indentation in the existing code here please while you're at it (maybe Jens can just fold it in): if ((rq->mq_hctx->nr_ctx == 1 && rq->mq_ctx->cpu == raw_smp_processor_id()) || (rq->cmd_flags & REQ_POLLED))