Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f65f9809-7f52-5bb1-7e78-f22b813500c2@oracle.com>
Date:   Wed, 14 Jun 2023 01:25:09 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: Can vhost translate to io_uring?
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     Oleg Nesterov <oleg@redhat.com>, linux@leemhuis.info,
        nicolas.dichtel@6wind.com, axboe@kernel.dk,
        torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mst@redhat.com,
        sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
        brauner@kernel.org
References: <20230601183232.8384-1-michael.christie@oracle.com>
 <20230602192254.GD555@redhat.com>
 <87r0qt18qq.fsf_-_@email.froward.int.ebiederm.org>
 <ae250076-7d55-c407-1066-86b37014c69c@oracle.com>
 <20230605151037.GE32275@redhat.com>
 <03c07f48-8922-f563-560c-f0d4cc3e1279@oracle.com>
 <20230606121643.GD7542@redhat.com>
 <39f5913c-e658-e476-0378-62236bb4ed49@oracle.com>
 <20230606193907.GB18866@redhat.com>
 <cfbf1a0d-5d62-366f-f32f-6c63b151489e@oracle.com>
 <87mt12oa25.fsf_-_@email.froward.int.ebiederm.org>
Content-Language: en-US
From:   michael.christie@oracle.com
In-Reply-To: <87mt12oa25.fsf_-_@email.froward.int.ebiederm.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0NXMi9tSTVpUWpIbWhzZnAzYlVmOVVya2tleXBVK2R3WlZwRjdUYUxhRU5E?=
 =?utf-8?B?Y1FHazhHaGNJdUppWHR4QWl4MVMyRG1TOFFzR1ZFZm5OWi9hR3g0eVVoY0lS?=
 =?utf-8?B?K0ZPQXQyVHE5K1ZCMGxiSDRXR0t5OEN0c2xyNU1Da0liY0FqeHFqSkJQTU9n?=
 =?utf-8?B?WDhMZTBUNERLc2MwMXViTWJvUUt6elQ3b29aYi9FMGhRcjVOdEd1eThLaUVZ?=
 =?utf-8?B?K09zRkV2YU9wbVdHNmd0LzdqUERyajZIVk5Ra2o1UzVSZ1ZpZVNhVnpEK2M1?=
 =?utf-8?B?ZzQzM3ZtdEEvZVFjVTlVODk2OXhVeXp3bFJTQUdBOUZLYlF0YkZxakx4VjZm?=
 =?utf-8?B?OHUyNzV1L1U4V2hVY2d1OXJqOUlyNTRab0puUEIvUTJucUh4STduZzg0eURt?=
 =?utf-8?B?WmNtdkxYeGtBL2dSenBRTFF2MTBBMlNpR1g0NHdIaHM5R0lQajBUdnR0R0sw?=
 =?utf-8?B?M0xzMkNlbG9xbHhMUThFWFRpaTA2ekQ5b2FTczd1SmlRMjJCQW9UclM0VFkx?=
 =?utf-8?B?cWRNWFBGYWRTcFFadE10c1dXcjJnaUR1ci9sUTZVK0NqL0k1K0h3NlZiYjhM?=
 =?utf-8?B?cS96dkordE9WWTBoUW5RWk5DbFFvbFVvNUxOQVdUQVhKQit1QkZ3bHdRTGVm?=
 =?utf-8?B?UGlzb1l5QVB0YVBlNXJCK2ZFR1l0NkhvZ05MVUxnYUR1L3NXNXJQMTU3N01q?=
 =?utf-8?B?aTRKYjdncmZFR1R0QnhkeDhvOTRWUmZ3bGZvbGM0K0lSOWtMalZ1QkZabEFI?=
 =?utf-8?B?Vng3djJuSHVJdmlqemJZSzZPN09wZ2xKMFJZcXRENE4rcXpqSDduRzJCZnB3?=
 =?utf-8?B?MWFuT1cvZTFaeFNOWW1jZjBaSERGRklzbHlsMUc1U2RvZDl3anBlUWhXcmRa?=
 =?utf-8?B?anhLRXJRT3FUZVUxVld3dDZ3alFGUU1lQ2prYUV3Skg0Tzhhd05xUFN6Wjh6?=
 =?utf-8?B?dHQrWUlWU2I3K2pSNGRLYk5ORjdoemtWWWNPY0YwQW5BUVVNdFhzajZRNDFj?=
 =?utf-8?B?SFkwR3hOU09Na2RkMThZaXZRanQ2emRhR1NHWGZxRVNlcElBZ0N2U1U0WE1L?=
 =?utf-8?B?a2l4Tm5YYWovK1pSVU5IV0hwT0w0S0ZvQy85cGlSTlN6RWVVQWRGcHJSYkdR?=
 =?utf-8?B?S25NVlZjWm1ia0cvbVJ4VTNKTllWaTE5Z3lQQzVkVXNHdW1XRkpveDF2a0Jt?=
 =?utf-8?B?QXR5MVpiVTRWMGRHYzNlbktpV2hEQnhOT2VMU2xxbWNyekJycy9GRGxsSTlj?=
 =?utf-8?B?Uit4UC8wZU9hdkt6dkxUNDBjMHF4aDVQc0lZQVlMWXhHV1o2NnczbklFaUdr?=
 =?utf-8?B?VEoxSHVBVmc1M1NSSXZKcUZWeFZscHU2ZjBxSGIvNWpjcnZTdTlPQW1hUGtZ?=
 =?utf-8?B?T2F2WTlFcWZ3OHk5UGk2bS94UERXNEYzT1ArZll1bDVVSjZqVGlKTzA4SUlZ?=
 =?utf-8?B?RDQyQ21jNyt5ZHovcTRNcXBqN0w4T0hWazc4N0xIRVNVU2JtTHJ0QVE3ZjFL?=
 =?utf-8?B?M0QzQUFCR1JwcGYxTVd3TzdQRjJpYUJQeU42WmowK094MmpJVVhGbElJanRv?=
 =?utf-8?B?dHg1enM1RjM5b1VEb1ZJOWZ6L2JLNjBSbGl4ZWlnR1duRnBtNlRSV1Z2RERX?=
 =?utf-8?B?ank5WnlyNHhjSnNFeVF0clppWnlmdkxycVFhNlJYOVBmVFFYRVFTQlNYR0hu?=
 =?utf-8?B?SGF6eGNQNENaMG9UcUdwMzNnd2lTbFY0bXVIODNIeFc1R2hRSHY2UDFadGlq?=
 =?utf-8?B?clR6VDM0SVhVeElPMUk2T1dDRWNsNzI2dVhWK2lLaUphWXZIemFIMFMyNTRV?=
 =?utf-8?B?QTdhQkxSaHNvcVNjSXZsMXRSY2pZNHFBYVgzL0ttbGNBOGNSb0p6ZWJyRnhI?=
 =?utf-8?B?YmlJZDJrcUVueG1qcGhITDhOaVpKcmxLeUg2SHhEUnF3eWFkNU5XUEp5YWRL?=
 =?utf-8?B?bnJBbjRtT3Z1T1ZVTlBjS1ZtVExLQ1JTc0YyYnZMejdWRzlxdld1c2pzUWFz?=
 =?utf-8?B?NUtGQW04OURFUkJxTjU2d3BtUE5QM051MU9WTzQwSEdhUzJGM2dmdDZhdzBN?=
 =?utf-8?B?QW5JMkl3dFRyU0thZjNoU2IxWmFRcmk5cS9scTZlU3VWWnY5UEcrYm93RHg1?=
 =?utf-8?B?L3A4ZkJDVHd2UlBOTFlPTkhEcE1yL04rbTR4b3VGRzlqV2JkeEM4Y2xTTTI5?=
 =?utf-8?B?elE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VmtDMjI0V1hWdDR6UEw1ekcvOEM0SVdqQ3N2eUZSbTBhYndHdkVFZmJpc1hW?=
 =?utf-8?B?d0dnMkg3bjFKSDRvZUZKNjVMNjVtb2IzekNlZzE4bkxEZ0lZVmtOQk9iZkxJ?=
 =?utf-8?B?RE0rdUVNTmRRYU00bEdqV2JaN2hRR0VvbUV6QjFPUnhKT0xpVEwydStDcVR6?=
 =?utf-8?B?UkRCVkFlUjVQWldyYyt1WGpCdURBOThiWEp4MjFYdHArTUpYc0pQQ3IrbEN3?=
 =?utf-8?B?WnhDOVR5MUYzNHJuWUFKYmE2QmlqNVBQc0NOK0FVME84WnFPUkllS1dEYy9x?=
 =?utf-8?B?cE5VUlRiV2lpaXl5Y3c4dFhOTDVqRHFveldKZDZzOWNnOGQxOXIvSDVQQUo4?=
 =?utf-8?B?a3BYQ0xkRit6dkVNL3NtMFdNaVdVekY2Q1JQZkFmdG1KNDg1YWJRckk0Q29i?=
 =?utf-8?B?enJGMkpndnVjK3ExQXpYbFhnUUNENVNXMk8xV3RTM3ZqOTk3UUNOeTJ6THEr?=
 =?utf-8?B?ek5kMmFtdE40VFl5TEw4WDBqVzRVMzVxeVNJNXBHcXpSV3FMOXJTWW1GcGVv?=
 =?utf-8?B?L2pLVGpxemZmQXZZazdVQnhkUGtiRlJHK3BjTTl1Wng3NVJnTk1XaFBGekVJ?=
 =?utf-8?B?ZEhyNktBVkE2VVhOUm5sU2lQTkp5Y243UjZEWTRPanF4VlpXcDZGczFZT1RR?=
 =?utf-8?B?Tk8yejlXL3ZUbzJlZGErbmo0UE5UWUdCRi9rTnQxbDB4U1NrdjZNTXpGMVVJ?=
 =?utf-8?B?Ym5rU0wzT3Nmd3hQUXFWSXRGZHpMekJpK3ZWV25MbE8zNWg3ZFUvOWFPT25x?=
 =?utf-8?B?NkFzeGprdXBSVGFmeVlyRHQ3SFJpVHIyT2gvNmhzVmg2SmlXRG1wMkpjMkpQ?=
 =?utf-8?B?VWRUKyt4bVZtZlp2VUcyZXpWa3lDbVo3RFpOa1pxaUJaTzZJcDN1dy9vOFpx?=
 =?utf-8?B?UklSRGRqNFFLbjVPUVJrSUJhQ0V4OGVvM2JMQnNNSUMxMXh0aiswdDJ1bFY0?=
 =?utf-8?B?NzlkcE5sNmhrNmtDSS9vRFBTSzVSb1o1bUgzWk9VOUtzandYWUpCOHZkL1lX?=
 =?utf-8?B?MmdmaW9VVjFlTlNGVGxFclREdnlOMzE2Q0ZOcUNOY1gvM0xRK3d5N2pmcXBD?=
 =?utf-8?B?RjVNT0xDdzJMTStNM0tiOUJiYUdMazVXNWtrSEhnZWpScmZiYm5rVm9zWmEv?=
 =?utf-8?B?azhoWXBpM1lHMnZRYSsvZVFxbVJ1RFY1c0tEcnlscTVUUTFRc3Z2alV3d1V5?=
 =?utf-8?B?U01mbmVqamdRMitOcWgvWXpyc1JRUjZGTTZMSnptOFE4UWl4ejZhUGRVSFNx?=
 =?utf-8?B?YVpycnRJcC9FWS9qMCs0UmN3VkFCYk51WXZPSG5Ob1k0cnVpWSs3MVNUekJY?=
 =?utf-8?B?U1JhOUk0WXZiTjRRZDRhZU5HUG56YjduNW9GUFZEYzByM3AvcFl5T0ZVRXRa?=
 =?utf-8?B?MUpUWTFlMEVWbWljVFZvQTl2NThlaWtVWUdRMVNRZW9IaXdUODE4dUZmT29E?=
 =?utf-8?Q?vxdEoBxd?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89154899-2bbc-4bba-03b5-08db6ca01b5f
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 06:25:11.6137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jnTL9kU3KAMAvpU4aBL52pLsRr+ad4FbeWu0HrlApEdLGeCvL4TB5erTk8uHEnL+g8QD17SvAb3CtZ+FnozeW+9sBqVYlhDCskFtMG4fxps=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5151
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-14_03,2023-06-12_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0
 mlxlogscore=759 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306140054
X-Proofpoint-ORIG-GUID: VLr5iEHfA4Fh9r5blIL67AAV5DChCkJx
X-Proofpoint-GUID: VLr5iEHfA4Fh9r5blIL67AAV5DChCkJx
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/14/23 1:02 AM, Eric W. Biederman wrote:
> 
> I am sad my idea for simplifying things did not work out.
> 
> 
> Let's try an even bigger idea to reduce maintenance and simplify things.
> 
> Could vhost depend on io_uring?
> 
> Could vhost just be a translation layer of existing vhost requests to
> io_uring requests?
> 
> At a quick glance it looks like io_uring already supports the
> functionality that vhost supports (which I think is networking and
> scsi).
> 
> If vhost could become a translation layer that would allow removing
> the vhost worker and PF_USER_WORKER could be removed completely,
> leaving only PF_IO_WORKER.
> 
> 
> I suggest this because a significant vhost change is needed because in

It would be nice if the vhost layer could use the io-wq code as sort of
generic worker. I can look into what that would take if Jens is ok
with that type of thing.

For vhost, I just submitted a patch to the vhost layer that allow us to
switch out the vhost worker thread when IO is running:

https://lists.linuxfoundation.org/pipermail/virtualization/2023-June/067246.html

After that patch, I just need to modify vhost_worker/vhost_task_fn so
when get_signal returns true we set the worker to NULL and do a synchronize_rcu.
Then I just need to modify vhost-scsi so it detects when the worker is NULL
and modify the flush code so it handles work that didn't get to run.


> the long term the hacks in exec and coredump are not a good idea.  Which
> means something like my failed "[PATCH v3] fork, vhost: Use CLONE_THREAD
> to fix freezer/ps regression".
> 
> If we have to go to all of the trouble of reworking things it why can't
> we just make io_uring do all of the work?
> 
> Eric