Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abb91fb3-f50a-6235-eac6-a94093c54cc8@gmx.com>
Date:   Wed, 14 Jun 2023 15:09:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] btrfs: remove unneeded variable from unpin_extent_cache()
Content-Language: en-US
To:     baomingtong001@208suo.com, clm@fb.com, josef@toxicpanda.com,
        dsterba@suse.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230614065736.22353-1-luojianhong@cdjrlc.com>
 <a1c89487cc2839474f232ab140a96e3b@208suo.com>
From:   Qu Wenruo <quwenruo.btrfs@gmx.com>
In-Reply-To: <a1c89487cc2839474f232ab140a96e3b@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:FrRq7xmgPDg=;FFH9boazoK87MgRyt9IjkrDaz1t
 T1RcYep4SmCtfvaMGV/I+6ainBD3ERoq4IqdQT/lXw+4MO2CNXNXEdNkfJn26rSdnw6SoczZo
 As00Cm7I0WqpI3mKiFMohXaXrgsZlhe0kmlw4SbJ1mKYGj2ydc2jGL6zJD4j7I27ehEUfy3GO
 JhEiHQLyipDDxWp5m8VTFKjVix1hNkL8KlVHGKbB3eXpu+u8BHNy+t0frLk3yE60ZdnHsetPJ
 rtKssU51qpaa03NEBr9p4RHA8bt4QPhtzh0lWNnt4Ddhf/Kp1d0HLI/RVJ86tsQQU9RoAYid4
 23Ijk6jWfN9ISFfwkzXQgMI8xkPgHRtf7eKwXkp2iBeBDCOUsI9XP193Wj1hsuplUWxyI8TLs
 WM86I1tBVVQ7xua4IT0xJC8/FmdzFbESaBZFHzRj04fvUianUfYU4IC9Z0F8WSL4xaVAVqD7u
 l9THAtMCt96KHmGV9SqDIPIcVJIf2BZnbBOh3FmbT4vNhLBE84cFULK4ffOET2HF9rQ6NoKTg
 0AkDCgCrSl4JWu/6SrOdMt4MssHxwCMZt7BBhIDKrlRM1JYwmlf66hueHmGwKPytqncT0bVxl
 PIBPNvZaYkF7X/gUg+VpIij5q2jJ9Crg8Iy0gXy1/5El0yJI+S28IWGO01VTD1TQz15gWV+rN
 pk8a3G9lyzluU5s0v4j3EhDktOe1XS5h3tP4ySp6cnTr/5ZASmybmV/+ghQoDlmFqZMmouNoA
 0bn21l3NjTNGkJu0JxwQ8WxUkPNp5vOVEjLXawO+ptInXSnCXX6rFXLvcwC4GU7xrZG1kiVYT
 sTb771MXD5lMNB8RtFixnEdcsD7fstQov+ef3kK9b/PY8R1VjNaOb9owHBc+tygTFjlQo8YDv
 lykGNz4jDM2YmXz+cF6WkUKYiNpcEMpJaw/c+dAl5QNc8/O7Ftq2xrwC4RSkvIu/1TxHmK/mj
 245ZW3GOeTm1At7rlUkwwL4FylY=
Precedence: bulk


On 2023/6/14 14:59, baomingtong001@208suo.com wrote:
> fix the following coccicheck warning:
>
> fs/btrfs/extent_map.c:298:5-8: Unneeded variable: "ret". Return "0".
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>

You can take it one step further by making the function return void.

Thanks,
Qu
> ---
>  =C2=A0fs/btrfs/extent_map.c | 3 +--
>  =C2=A01 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
> index 0cdb3e86f29b..f3e9aaeb9956 100644
> --- a/fs/btrfs/extent_map.c
> +++ b/fs/btrfs/extent_map.c
> @@ -295,7 +295,6 @@ static void try_merge_map(struct extent_map_tree
> *tree, struct extent_map *em)
>  =C2=A0int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u=
64 len,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 u64 gen)
>  =C2=A0{
> -=C2=A0=C2=A0=C2=A0 int ret =3D 0;
>  =C2=A0=C2=A0=C2=A0=C2=A0 struct extent_map *em;
>  =C2=A0=C2=A0=C2=A0=C2=A0 bool prealloc =3D false;
>
> @@ -327,7 +326,7 @@ int unpin_extent_cache(struct extent_map_tree *tree,
> u64 start, u64 len,
>  =C2=A0=C2=A0=C2=A0=C2=A0 free_extent_map(em);
>  =C2=A0out:
>  =C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&tree->lock);
> -=C2=A0=C2=A0=C2=A0 return ret;
> +=C2=A0=C2=A0=C2=A0 return 0;
>
>  =C2=A0}