Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Markus Burri <markus.burri@mt.com>
To:     linux-kernel@vger.kernel.org
Cc:     Markus Burri <markus.burri@mt.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Subject: [PATCH v3] iio: ado: ad7192: Add error check and more debug log
Date:   Wed, 14 Jun 2023 09:30:33 +0200
Message-Id: <20230614073033.2497318-1-markus.burri@mt.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6DrXQiP7BZMNjHp18bCsYS31EB7joYuB7R3rUCc5hCRhTRWADmOvUIhERB/v?=
 =?us-ascii?Q?RLNPsJ1ojkx1UyE0IFbsTxQI4emuSBBqf2g2ytq7uFvcV92BkcZ4+IIdcpen?=
 =?us-ascii?Q?TRj3SOqWjCWiGUlZ2Y/92Z1H/Mgr4Xq/cjZa/l0k93U9PvNxSK3DIq0uJCEK?=
 =?us-ascii?Q?/16Z+PRaf9CH5Q/I8X6/3dA9MAMJY7SMUwDs1wIYjTG9Jt2wRipwk0EfmQKD?=
 =?us-ascii?Q?+lwWUvn2NFqX9vkHhdCB4UXXP7s+yz1tw1wumXJkp5fHXPfp3bFHZav7iVAa?=
 =?us-ascii?Q?+9A/jQSm0ZV+XW1U66mPjNUWNelt7vjtn8Rzm8yKpUQrSZGe0gw069CVigj5?=
 =?us-ascii?Q?Olys30oOHEs+yDjzgqLUnkzjlL8NDRNn+UHMBe7UWoCEfmjFm19aXsxfNTws?=
 =?us-ascii?Q?qlVx++b8WYgU1bZSjIRr8j6QKT0EBALJob759R3JtXL2Zmw6u3Y8TPixwjwj?=
 =?us-ascii?Q?objKdsCd1/4iR3vgizS+66hLPPGdnfTkNfAFKiWFPZvjkL3/HzJDIiW1havy?=
 =?us-ascii?Q?gGQO+5ksbUHwAJdyA85EU2hGifOh58QOBY55DcvULeEhtR60PmqAtiNJ9dUL?=
 =?us-ascii?Q?6DSLSDrg0BhAd4gs9ClrAtc/DFz9kI7A/Pg9q9LQfFDNpF6uDStHJs3FLuzb?=
 =?us-ascii?Q?P/eom2+hXQ4DykXZG/Qvg6WZn5PdHvKfZj1xHL9W3frNVCSlSS3fNn5xNIdU?=
 =?us-ascii?Q?ltoskomCsBNvc2LlWXN/jf0EGmsqAMZDuQUDKF/k8ci56Luoh7ucvZMgp9Ad?=
 =?us-ascii?Q?27k6iu8V9VtWn+GzqOa5kC0T8cA6g8wELXczJExWmx81D/97Z3tHaT3mQKUN?=
 =?us-ascii?Q?Xic7SbQQBOyz3wVup5XQMW73BWv8yOYHl1hceCUOEuDwAR2n/LZBQGykp7yZ?=
 =?us-ascii?Q?0yY4C57aG+hfrMR4p1sLnwXBv+eMkdzKxnjJSazdu+P7XIbwHB1HWdKs/GCx?=
 =?us-ascii?Q?7JlxPjTbD8OGSPqnQky6P7k8eZsKg65K+4efg+cPGyH4v1CkFROytiU4RfWE?=
 =?us-ascii?Q?fhIePWd9MMSltbst6FrNKw18Tb4enJ2xa25Z+iLfqD5KQek9O3mFBBZJ+kng?=
 =?us-ascii?Q?7dOwNLa1pq2LN3QnHEg6hu6Bey/RJLuBkmtavB92rD1XLHfSAzcsI/5osoH6?=
 =?us-ascii?Q?H8Whyf48FL0pyjfgFv9K0gMASXEtcWRAHOyDK6a9msEjXulGVchII7juyI+3?=
 =?us-ascii?Q?yUCZMpMzDKdU5/DI8j7/MqoPS6BF9R9s+7Docb6bCTp+nPUyphXEb1JA8QeP?=
 =?us-ascii?Q?7o6yYI17ROzdXC/bEDkNnfX1oiGnyfV06BpZgjTZpZTXPsF5X+JIX4HagzVj?=
 =?us-ascii?Q?dLgfWtLCM/BvgCAlovxTzAmF0/JPpjQh5QpFiWMtGrVr+YX4WNQwHK9dgxfZ?=
 =?us-ascii?Q?v+9UiGOLeM9Mu9MZ9snncLMo3V9E9x0uH3PoFqdvsnXoO6tJrZ/Sk0CuJRNV?=
 =?us-ascii?Q?ZD2Ij7/jP9zWdEf62qaiN1eE3N1Zcoc+OpmqIaeDM3dv8kYtYj0FY/Bw+GIw?=
 =?us-ascii?Q?QaYj5m68ImR8nN5e95FM8D/sAJBxub9b0qWfHQNc5/keEs64Ya0Dv7deq24b?=
 =?us-ascii?Q?8ZSNYKNQeKRB+AXjhKgW1p+kZ6RpCU2t9BwyoNag?=
X-OriginatorOrg: mt.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81224b9a-a8af-4a1c-733c-08db6ca94d42
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7488.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 07:31:00.5393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YFSmtRHjLGNT0/bfJB9ARUGc6q4s/8tcnE8YSE2rgE+RMZ9j41G3zsrodOm+P6zwga3XHUk0thoHofwBwVslHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR03MB8238
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Print read and expected device ID as debug warning.
Add error check for ad_sd_init() result.

Signed-off-by: Markus Burri <markus.burri@mt.com>
---
 drivers/iio/adc/ad7192.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index d71977b..220c3b7 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np)
 	id &= AD7192_ID_MASK;
 
 	if (id != st->chip_info->chip_id)
-		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
-			 id);
+		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n",
+			 id, st->chip_info->chip_id);
 
 	st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
 		AD7192_MODE_CLKSRC(st->clock_sel) |
@@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
 	else
 		indio_dev->info = &ad7192_info;
 
-	ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+	ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+	if (ret)
+		return ret;
 
 	ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
 	if (ret)
-- 
2.39.2