Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cc8cb124-86c8-fceb-a5cc-1b59c5c4a9af@amd.com>
Date:   Wed, 14 Jun 2023 13:06:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] iommu/amd: Fix memory leak when domain type checks fail
Content-Language: en-US
To:     Hao Ge <gehao@kylinos.cn>, joro@8bytes.org,
        suravee.suthikulpanit@amd.com, will@kernel.org,
        robin.murphy@arm.com
Cc:     kevin.tian@intel.com, jgg@ziepe.ca, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, gehao618@163.com
References: <20230612021718.82293-1-gehao@kylinos.cn>
From:   Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20230612021718.82293-1-gehao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmRhTmFGekdwbWZSVVl4QUVOSGNmMEhPUzV5bGVQSkROTlZzczcwcFcrTUE1?=
 =?utf-8?B?TmUrVjdwZUtSakN6K1MrYjhkS2RISTdidk1HT1paUDVldjVJOHZ1TDB5OER0?=
 =?utf-8?B?RGlnT1ZNQm9uVjhQZzcvbGVocjNod3hPdFFSOVEyN2hwTkM5aXNQc0ozejlV?=
 =?utf-8?B?QVhEblBPem9DKzUrT0w3Q0FhYVF6NzNpdWpvYTQ0MlNOTzlMRU96SnRNOFND?=
 =?utf-8?B?RDdOWDN4dmNEQ2N5Z3ZsUEt0cE1aU21OWXczZTB5RjJZSnlUY09XbGx4bXZU?=
 =?utf-8?B?cDEva3VocEJhUE9ubnUvcHYyTGppb3ZvZDFNbjJtM3pVcDV0UnNaS3JWTnp3?=
 =?utf-8?B?Q2c3VEpCS1BpVkVxZEl0SlA5L3BlUjBTQ0dZU09MQUdaRHpDZG9sWFBvSG9Q?=
 =?utf-8?B?cHFXNi81Zyt4dGg5MXNoMmJIczI0bzlnR1lzcGVTSDJhdmowVndDa1FTUHN3?=
 =?utf-8?B?dStiUnJUQ1NyNU9IdHY0d0RtWHVUWjdiL2drMmFEeGNXa093THRFdGVZYy9k?=
 =?utf-8?B?eldyck5wOW5yRzVhelg3emd6REYwUU0vZi9UOHptcnZQRFJNUnhiZlNvamVF?=
 =?utf-8?B?MGdVTlZFL0w2WDMrbSt3b3FaR0RJVzFacXRYcjJVRnFZS1ppSDM4RlFIZjZ4?=
 =?utf-8?B?Y0ZoMVpjT0ZmcC9SVjdTWTBGL3JWWC9TSzY3eElGODRJREN6ZXdYcDQyYmpx?=
 =?utf-8?B?czVCZFVWMXpPaXhjTlFNdS9jTDJYbnhGVVpZdkx4eG5LNzhDWDAzb0Y0RUJE?=
 =?utf-8?B?aFExV3lMYVF5ZzhzQzVPMmZNQXdzTWZDMmJKUGxTMUtTVDI4Qm9GZ0MxTyti?=
 =?utf-8?B?WEZCOXF5N0FKWFlySnUvOHRNMnVkejN1QlBVMTFUdDEzaHNITEUyZFc5SUdO?=
 =?utf-8?B?djZxSlk4cjZZZkhpWStzMkJDd0hCMEl0U291eThKV2JPYmhZMS9kNlRwc2Jo?=
 =?utf-8?B?T0t2SFNQRHNWakJpdXRCWjZ4dDduTnFWOW8rOHY1aGRETU1ZUWNieWxiODZy?=
 =?utf-8?B?VkE4V2JtOU1zRWlpcHNsWi9oSXJySlNNVFlYdVhpUytJeHNnbmxYblpaeWpm?=
 =?utf-8?B?T1lWb2I3bnNtTldiOVJCZmJ4NmlFeFl0bUZCYnAydjRKT0djOXE4VjB1U2t1?=
 =?utf-8?B?US9jb2NhdjhjejFxNlI1Y2xHK2tuODNOeXZYR3g4VkVRWE1rdE52by9vd1c1?=
 =?utf-8?B?eXBpcEZWd0tVQ2I4NVhVcDJVVnJIMy9xZjNhODlrM3p4ZXV0Q1BTdUZkOTh2?=
 =?utf-8?B?bFBlaFluZ1hCaXdIL2RHb1g3SmhHNDlhV0pRN01EMXpXai9QOHIzVkY0OGpz?=
 =?utf-8?B?WTROUUE4SW9QZFAzNjVBenc2SmNnZTdnaEF5dEVxMXZVbFVTUzBuc2hsUFFM?=
 =?utf-8?B?NDdyZ3ZyMyt4NnJWVllvRGFFWHdNOHluVml5SFpKeHRkdkVMSjYxL21tdU9H?=
 =?utf-8?B?SXc3ampYdkVLZnMySkdIeFp4c0RkTkRaTnpsaFQ0TDN5VitWRy96dVhZOEEz?=
 =?utf-8?B?WldYaXBvTG9kWHh5aEZDZGMrZTYyMGRacUg0eno2aDRYUVpjQk1DMFZnV3BK?=
 =?utf-8?B?bGtyaFg4T0Ezc2gyWTNJUWpBOGw5c0ZMTnZ4ODhVUU5KandZbHhLQ2xCRTRN?=
 =?utf-8?B?QnNUR3VEcnErY0NmZjFQcFpWakFwby9CNkhVdkZnKzA0VlM4aWozdno1TlZw?=
 =?utf-8?B?US95V2tZTTBwV05Wbk5HQVM3aHd6ckJoY0M1OFVYRTkyK3M4U05qdzRmVlNZ?=
 =?utf-8?B?ZHF6YjBMR055L0tRL3BUZlRrM3BvcE0wYW1uZlcrVVhFMVFBWmhrRlV3NFcz?=
 =?utf-8?B?aDZ1UXRmRGRVWGtVOXlETkl3ZmJGK3llZGdvU3VURURiZjNaTGtyZnZ6aE9v?=
 =?utf-8?B?OHJPcmIwc0VTcGNNcU5aayt3N08vbExncmZXb3psclJ4K1JwZGdIWFN5cm9Z?=
 =?utf-8?B?RitOcTlNSGptNy9kTkFvS1BXbFkyRVZ6ZVNLL2pQTkZEclFmRlNweVR2Viti?=
 =?utf-8?B?NGk5Ly9EVGw3M1FIVDFxaU1pSk85YzhtekNiQS83cmlQdzArTGx1anhISDBu?=
 =?utf-8?B?QmVXWUtYc2ZZMVl5b1lHRElwQzZxTjdIZVpwcmZoMmlxZTlFaHp2eEw2Ny82?=
 =?utf-8?Q?5jhitjhn4TlCmUwujXF7LLmu/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3f16af3-aa9b-4005-78da-08db6caa09a8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 07:36:16.9540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nh3jWDW8Tq+ZWA4KU6id+gzBUENRdaTFYEdL9MnTu2BazoiHQevQ2rNNjcgbVPuPIkrj4roICb3khvkhBtcprw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8002
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 6/12/2023 7:47 AM, Hao Ge wrote:
> When domain type checks fail,we also should free protection_domain struct
> to avoid memory leak in protection_domain_alloc
> 

There is another patch from Su to fix this issue [1].

[1] https://lore.kernel.org/linux-iommu/20230608021933.856045-1-suhui@nfschina.com/

-Vasant

> Fixes: 29f54745f245 ("iommu/amd: Add missing domain type checks")
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
> ---
>  drivers/iommu/amd/iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index dc1ec6849775..f08e65629c74 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -2094,7 +2094,7 @@ static struct protection_domain *protection_domain_alloc(unsigned int type)
>  	} else if (type == IOMMU_DOMAIN_DMA || type == IOMMU_DOMAIN_DMA_FQ) {
>  		pgtable = amd_iommu_pgtable;
>  	} else {
> -		return NULL;
> +		goto out_err;
>  	}
>  
>  	switch (pgtable) {