Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67c7f462-6564-0d54-9eda-0e97f66bee8b@loongson.cn>
Date:   Wed, 14 Jun 2023 16:17:31 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] drm/fbdev-generic: Remove a redundant assignment clause
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230614013011.750598-1-suijingfeng@loongson.cn>
 <b99747c5-8810-d2b6-80c7-dbc85fcefb8b@suse.de>
Content-Language: en-US
From:   Sui Jingfeng <suijingfeng@loongson.cn>
Organization: Loongson
In-Reply-To: <b99747c5-8810-d2b6-80c7-dbc85fcefb8b@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 2023/6/14 13:29, Thomas Zimmermann wrote:
> Hi
>
> Am 14.06.23 um 03:30 schrieb Sui Jingfeng:
>> The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() 
>> function
>> is redundant because it has already been copied when the call to
>> drm_client_buffer_vmap() is finished. Therefore, this patch saves a 
>> useless
>> copy. No functional change.
>
> Isn't that what we discussed here?
>
Yeah,

Lucas say he would like to take a deeper look in later time.

Then, two and half a mouths passed, it seem that no one send

fix patch.

I thinks this is an exercise for me, I resend this patch again.

Any idea?

> https://lore.kernel.org/dri-devel/20230325074636.136833-1-15330273260@189.cn/ 
>
>
> Best regards
> Thomas
>
>>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>>   drivers/gpu/drm/drm_fbdev_generic.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_fbdev_generic.c 
>> b/drivers/gpu/drm/drm_fbdev_generic.c
>> index 98ae703848a0..aa6924e3a58c 100644
>> --- a/drivers/gpu/drm/drm_fbdev_generic.c
>> +++ b/drivers/gpu/drm/drm_fbdev_generic.c
>> @@ -182,7 +182,7 @@ static int drm_fbdev_generic_damage_blit(struct 
>> drm_fb_helper *fb_helper,
>>                        struct drm_clip_rect *clip)
>>   {
>>       struct drm_client_buffer *buffer = fb_helper->buffer;
>> -    struct iosys_map map, dst;
>> +    struct iosys_map map;
>>       int ret;
>>         /*
>> @@ -202,8 +202,7 @@ static int drm_fbdev_generic_damage_blit(struct 
>> drm_fb_helper *fb_helper,
>>       if (ret)
>>           goto out;
>>   -    dst = map;
>> -    drm_fbdev_generic_damage_blit_real(fb_helper, clip, &dst);
>> +    drm_fbdev_generic_damage_blit_real(fb_helper, clip, &map);
>>         drm_client_buffer_vunmap(buffer);
>
-- 
Jingfeng