Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 10:26:31 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Ivan Vecera <ivecera@redhat.com>
Cc:     netdev@vger.kernel.org, Ma Yuying <yuma@redhat.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] i40e: Wait for pending VF reset in VF set
 callbacks
Message-ID: <ZIl5t3x3/BDdHyhr@corigine.com>
References: <20230613121610.137654-1-ivecera@redhat.com>
 <20230613121610.137654-2-ivecera@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613121610.137654-2-ivecera@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H5LyY2chuz1ZDb/+p33IYg5WO12IPhl82Q+i8vYdMHQ3c2MhkR9MkQyYfpwQ?=
 =?us-ascii?Q?Zz7bHM1vwWMOac0bfNkZ82kAdxRdiRQkSYaevpI+IpCCdswTwIeSsnJNiU1f?=
 =?us-ascii?Q?JlKv8uqRa9msn3XemPOdG9maCffEIpJ7ThfrFk+rD/cQthLbcy9IbgOpMZGz?=
 =?us-ascii?Q?Qzenw2ssGVQXIA1vt+ZvOjT+KMAdHwFos4UrsfYNRc1NrCQYi9Cfk0/zpouw?=
 =?us-ascii?Q?5WWG7799wYmJlkViJlhEHBbFEbSzaAbu8hjX4cNWeEW7wVwYUdZL6sXqNMG+?=
 =?us-ascii?Q?pQDn2k4TNNUb6IQ9BzcPkqzBCwLK62czQUamRxXkXRug1etbhZJoxnkpVaN2?=
 =?us-ascii?Q?6lq1I7Nln/tOWuTuiNVhuHSjolsqULlpDfIvV/o2XHsJsYU0a2axHsdLAOtF?=
 =?us-ascii?Q?OysW10BjZL3qubIzBxkqH56qeTu9c09mvZfYWhDJSrT1RCRrtCwoHhzHKF2M?=
 =?us-ascii?Q?0ntWOPjRV87rEgYwqhuDjNZgC1cT/ng6apDZVABcPUh/5jw3eI5nQlsNfw1W?=
 =?us-ascii?Q?yLqHGSDDqnGvdTL53/pfe9ldEiUAgeYZhLllBkf0yWSdNBvcDccce1xBBjie?=
 =?us-ascii?Q?6ROceP15AuToAWjZLcZNX1wnq63Sh7zskEJxypljhnroT5YQo3y+l39zagBv?=
 =?us-ascii?Q?SHJAAPv8pUI1YNB3iHNXlZePK6fH3lf70q2FL9RkfiJUeljUmphw1aO50lBd?=
 =?us-ascii?Q?UnwoBRZZ5EDgUpWhIws7O85VLlvq5wQrmRar8kg6NoRkrFnR6WjUDqlZafPe?=
 =?us-ascii?Q?cg8jeJtbCdPzH4qnyA/wgEkNQU0CXw6eh+Ej0rSj4J4wK6nPg2kYxqG0+auq?=
 =?us-ascii?Q?VclCLXcpJMWDAhLGPsyWcFQ5ckIYf1sOyMAVuZyH69JC7bJQRL5T0ijN6ums?=
 =?us-ascii?Q?XT52ukOQ3xPRce8y2w2nPSOobWDVAA6Ao9wH2dK1hSItg1Tf8rqMEo/1PSXW?=
 =?us-ascii?Q?OlfmcEhkLX4PXT2rBRK3HiNwVubDHT/C9XFFx6KOmcpv5JvltUZIrGe2f4h/?=
 =?us-ascii?Q?x7WjNBHl5mUlUHMKoePhy6x2HszLbkdfj8oVDKWt0YOUc1VF21VirpBltkuG?=
 =?us-ascii?Q?zqOMOTVhPrrUoER9n4xc1CKw6+c2opCN1iZJ+NMZFekT3ilnhdiqnprWsg3E?=
 =?us-ascii?Q?H1CyId2IOIRsxVdO+gwa6q1mz4hgk/ApEiq0OJVmHGfyZq3NtkZxdmHOZmKP?=
 =?us-ascii?Q?WreYXkkrCtYhshrs5/chEpX0Juz41zOGeqO3/cxnr4CRsQ9NGtUbFSWpEtfV?=
 =?us-ascii?Q?0qcrf8Pls2KB/13i6kA9ZwfSvvo7zVrDXUsUmBrj75K41lBYgxYvURkxieSn?=
 =?us-ascii?Q?x4gtGFCfLCttg89pJ2aQg1weG5K8JEebwtG7LZPkSCoKVz61wPjZK/tjWIdf?=
 =?us-ascii?Q?wLHXCbAMA82O6EARRXkIOa+AslLwb9XVyvXL/O8Z+loEMtganNBSmolvT+8t?=
 =?us-ascii?Q?v2EgKJC320GplCRRFqE3MBcbpQzeFhHQwBeR1osJMu9CTobeF1VuzGT6DR3b?=
 =?us-ascii?Q?oRjDwNwx96NX2V0nzTbtsgcbyl8cf3McFkAq6CM90+qr8SUuoI/0CqgPsBUU?=
 =?us-ascii?Q?vNuUX9sc3tM5WvMbXuFa7K+4vYPHXYWKtyrXX7ZF2pU0nAlKN9emZMYoG09p?=
 =?us-ascii?Q?M4LzB5SuN2q7fJfb3z6Z4OhTif+OTfslyyM9WUh9EIwqH+1dndPzE2o+DWZJ?=
 =?us-ascii?Q?viuHxQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73183385-f8a5-40e9-36d5-08db6cb11286
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 08:26:38.1101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 12bCrNKcIeB5Jd04yrELmpgrc2hoq2uGPlrrjGYWIEdL4I+thbS5WH6HWTYZHxoF/h0i1eJDwN0UkPqCQCcZCaHhF/EnGIyhUHdBsgzJ+uU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR13MB6350
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 13, 2023 at 02:16:10PM +0200, Ivan Vecera wrote:
> Commit 028daf80117376 ("i40e: Fix attach VF to VM issue") fixed
> a race between i40e_ndo_set_vf_mac() and i40e_reset_vf() during
> an attachment of VF device to VM. This issue is not related to
> setting MAC address only but also VLAN assignment to particular
> VF because the newer libvirt sets configured MAC address as well
> as an optional VLAN. The same behavior is also for i40e's
> .ndo_set_vf_rate and .ndo_set_vf_spoofchk where the callbacks
> just check if the VF was initialized but not wait for the finish
> of pending reset.
> 
> Reproducer:
> [root@host ~]# virsh attach-interface guest hostdev --managed 0000:02:02.0 --mac 52:54:00:b4:aa:bb
> error: Failed to attach interface
> error: Cannot set interface MAC/vlanid to 52:54:00:b4:aa:bb/0 for ifname enp2s0f0 vf 0: Resource temporarily unavailable
> 
> Fix this issue by using i40e_check_vf_init_timeout() helper to check
> whether a reset of particular VF was finished in i40e's
> .ndo_set_vf_vlan, .ndo_set_vf_rate and .ndo_set_vf_spoofchk callbacks.
> 
> Tested-by: Ma Yuying <yuma@redhat.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>