Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230613211159.b1faefb1a1bd.Ie873f66db5555c014c4afc15678e4fd5cfeca226@changeid>
References: <20230613211159.b1faefb1a1bd.Ie873f66db5555c014c4afc15678e4fd5cfeca226@changeid>
Subject: Re: [PATCH] gdb: linux: make SB_* constants gdb-parsed
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        Johannes Berg <johannes.berg@intel.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org
Date:   Wed, 14 Jun 2023 09:48:45 +0100
Message-ID: <168673252566.2889415.6583119718907787971@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Hi Johannes,

Quoting Johannes Berg (2023-06-13 20:11:59)
> From: Johannes Berg <johannes.berg@intel.com>
>=20
> These now contain "UL" suffixes due to the use of BIT(),
> so they need to be parsed by gdb since python doesn't
> understand that.
>=20
Thank you for the patch, however there is an existing patch [0] submitted
and on it's way upstream [1] to resolve this.

[0] https://lore.kernel.org/all/20230607221337.2781730-1-florian.fainelli@b=
roadcom.com/
[1] https://lore.kernel.org/all/20230609004453.2AAEEC433EF@smtp.kernel.org/

> Also fix a comment typo while at it.
>=20

This typo wasn't fixed though. Perhaps that's worth a separate patch if
you wish ...

--
Regards

Kieran

> ticket=3Dnone
>=20
> Fixes: f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUS=
ER")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  scripts/gdb/linux/constants.py.in | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>=20
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/consta=
nts.py.in
> index 471300ba176c..646fffddd862 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -48,14 +48,14 @@ if IS_BUILTIN(CONFIG_COMMON_CLK):
>      LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
> =20
>  /* linux/fs.h */
> -LX_VALUE(SB_RDONLY)
> -LX_VALUE(SB_SYNCHRONOUS)
> -LX_VALUE(SB_MANDLOCK)
> -LX_VALUE(SB_DIRSYNC)
> -LX_VALUE(SB_NOATIME)
> -LX_VALUE(SB_NODIRATIME)
> +LX_GDBPARSED(SB_RDONLY)
> +LX_GDBPARSED(SB_SYNCHRONOUS)
> +LX_GDBPARSED(SB_MANDLOCK)
> +LX_GDBPARSED(SB_DIRSYNC)
> +LX_GDBPARSED(SB_NOATIME)
> +LX_GDBPARSED(SB_NODIRATIME)
> =20
> -/* linux/htimer.h */
> +/* linux/hrtimer.h */
>  LX_GDBPARSED(hrtimer_resolution)
> =20
>  /* linux/irq.h */
> --=20
> 2.40.1
>