Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 10:45:35 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Shuai Jiang <d202180596@hust.edu.cn>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Ivan T. Ivanov" <iivanov@mm-sol.com>,
        Sricharan R <sricharan@codeaurora.org>,
        Naveen Kaje <nkaje@codeaurora.org>,
        Austin Christ <austinwc@codeaurora.org>,
        hust-os-kernel-patches@googlegroups.com,
        Andy Gross <agross@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: qup: Add missing unwind goto in qup_i2c_probe()
Message-ID: <ZIl+L+KTMclMXMQd@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Shuai Jiang <d202180596@hust.edu.cn>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Ivan T. Ivanov" <iivanov@mm-sol.com>,
        Sricharan R <sricharan@codeaurora.org>,
        Naveen Kaje <nkaje@codeaurora.org>,
        Austin Christ <austinwc@codeaurora.org>,
        hust-os-kernel-patches@googlegroups.com,
        Andy Gross <agross@codeaurora.org>, linux-arm-msm@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230418135612.598-1-d202180596@hust.edu.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="krO64uYAB+KZ7qEU"
Content-Disposition: inline
In-Reply-To: <20230418135612.598-1-d202180596@hust.edu.cn>
Precedence: bulk


--krO64uYAB+KZ7qEU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 18, 2023 at 09:56:12PM +0800, Shuai Jiang wrote:
> Smatch Warns:
> 	drivers/i2c/busses/i2c-qup.c:1784 qup_i2c_probe()
> 	warn: missing unwind goto?
>=20
> The goto label "fail_runtime" and "fail" will disable qup->pclk,=20
> but here qup->pclk failed to obtain, in order to be consistent,=20
> change the direct return to goto label "fail_dma".
>=20
> Fixes: 10c5a8425968 ("i2c: qup: New bus driver for the Qualcomm QUP I2C c=
ontroller")
> Fixes: 515da746983b ("i2c: qup: add ACPI support")
> Signed-off-by: Shuai Jiang <d202180596@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>

Applied to for-current, thanks! Thanks Andi, for the proper Fixes tag!


--krO64uYAB+KZ7qEU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmSJfi8ACgkQFA3kzBSg
KbbOQRAAjMg3E3JBbJtdqbztOeRNM3Vz6Wz6IG5McYtBwo1FQ1Eg5cllnx9KWpNX
ucOIXhN2mM0ovJSNzKcD+Upkxg7hmQT/S6akdSholHZRG3yof6/j8sTYRzpeZbsE
XXd0qW4L3tNhBB5cJZVH9xqFuOUUshORLZozTGWOEizVwuedqZsxpnLbQOr5EXnN
WvZkuCIxB6M7rN2apyZLoAGOz+/AN42/mZy8vI0Gl8PeL7XtqYCIKw7nLgI0UU0c
JYCUEaevpCYKkZOeZJLpqDN8uxlvFFSVYcs1Vcz+hq5RIRY4/KGvoUGZUw9/meKt
Fs4gQ9kdZgULVEJw/UtGtSHQfRQ310Zd4GecAIzjVBfrKtzU0436v3FWXrRb/oE8
6cIkr4D4gCDbAgLy0n+BcNAXeoAuW7l1+NuH4R/+XosFVPTK8BYUH6x6h1uJKsNR
CAzCQTKgrnNb2WeAX1knQ7+EtrKyPm1Spb/T14dtwp4v3Ik4h5Z8JojAb9snCG68
5gsFdLArpHLBIjC/GZ33R4p8EVHgY+5fBGUMKZ2w1VAjlwYQB8exp3hQ+dadGcow
Q8U0iZaloJobkHy1lSoA+wZhRbsV2Rv46ow3vyafbnof0rpV9H873AkYP7njuuLK
QR9mcJAD1LZ+H0UKadb5Q9gkYy4D0SzMD9bQ1vbKIbM0/gYxPTE=
=VxEP
-----END PGP SIGNATURE-----

--krO64uYAB+KZ7qEU--