Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92bb89b1-23a2-668d-a5fa-6306336241a0@redhat.com>
Date:   Wed, 14 Jun 2023 10:41:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] mm: page_io: Prefer 'unsigned int' to bare use of
 'unsigned'
Content-Language: en-US
To:     hexingwei001@208suo.com, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230614071804.13110-1-panzhiai@cdjrlc.com>
 <1e132a6416d673e285af610ff185fa5f@208suo.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <1e132a6416d673e285af610ff185fa5f@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14.06.23 09:23, hexingwei001@208suo.com wrote:
> Fix the following checkpatch warning:
> 
> mm/page_io.c:87: WARNING: Prefer 'unsigned int' to bare use of
> 'unsigned'.
> mm/page_io.c:89: WARNING: Prefer 'unsigned int' to bare use of
> 'unsigned'.
> mm/page_io.c:109: WARNING: Prefer 'unsigned int' to bare use of
> 'unsigned'.
> 
> Signed-off-by: Xingwei He <hexingwei001@208suo.com>
> ---
>    mm/page_io.c | 6 +++---
>    1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/page_io.c b/mm/page_io.c
> index 684cd3c7b59b..138f73386612 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -84,9 +84,9 @@ int generic_swapfile_activate(struct swap_info_struct
> *sis,
>    {
>        struct address_space *mapping = swap_file->f_mapping;
>        struct inode *inode = mapping->host;
> -    unsigned blocks_per_page;
> +    unsigned int blocks_per_page;
>        unsigned long page_no;
> -    unsigned blkbits;
> +    unsigned int blkbits;
>        sector_t probe_block;
>        sector_t last_block;
>        sector_t lowest_block = -1;
> @@ -106,7 +106,7 @@ int generic_swapfile_activate(struct
> swap_info_struct *sis,
>        last_block = i_size_read(inode) >> blkbits;
>        while ((probe_block + blocks_per_page) <= last_block &&
>                page_no < sis->max) {
> -        unsigned block_in_page;
> +        unsigned int block_in_page;
>            sector_t first_block;
> 
>            cond_resched();
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb