Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614032446.8391-1-zhanglibing@cdjrlc.com> <4c81c6406707cf2e26b43bd4c5caca3a@208suo.com>
 <74ed374c5d5ec504d3bbecef656c1b37@208suo.com>
In-Reply-To: <74ed374c5d5ec504d3bbecef656c1b37@208suo.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 14 Jun 2023 11:34:36 +0200
Message-ID: <CAMuHMdVEOxVs1YOnmhbgqWMqpG-erahs8_OdpL1Jhck7KK+F0g@mail.gmail.com>
Subject: Re: [PATCH] m68k/q40: Fix syntax error
To:     wuyonggang001@208suo.com
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Yonggang,

Thanks for your patch!

On Wed, Jun 14, 2023 at 8:16 AM <wuyonggang001@208suo.com> wrote:
>
> Fix the following checkpatch error:

The patch subject does not match the description.

>
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
>
> Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>

scripts/checkpatch.pl says:

    WARNING: From:/Signed-off-by: email name mismatch: 'From:
wuyonggang001@208suo.com' != 'Signed-off-by: Yonggang Wu
<wuyonggang001@208suo.com>'

> --- a/arch/m68k/q40/config.c
> +++ b/arch/m68k/q40/config.c

> @@ -270,7 +270,7 @@ static int q40_set_rtc_pll(struct rtc_pll_info *pll)
>       if (!pll->pll_ctrl) {
>           /* the docs are a bit unclear so I am doublesetting */
>           /* RTC_WRITE here ... */
> -        int tmp = (pll->pll_value & 31) | (pll->pll_value<0 ? 32 : 0) |
> +        int tmp = (pll->pll_value & 31) | (pll->pll_value < 0 ? 32 : 0)
> |

ERROR: patch seems to be corrupt (line wrapped?)

>                 Q40_RTC_WRITE;
>           Q40_RTC_CTRL |= Q40_RTC_WRITE;
>           Q40_RTC_CTRL = tmp;


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds