Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 11:29:20 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Shuijing Li <shuijing.li@mediatek.com>
Cc:     thierry.reding@gmail.com, matthias.bgg@gmail.com,
        angelogioacchino.delregno@collabora.com,
        devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        jitao.shi@mediatek.com, Fei Shao <fshao@chromium.org>
Subject: Re: [PATCH v3] pwm: mtk_disp: Fix the disable flow of disp_pwm
Message-ID: <20230614092920.sl2qjdx3wbf7xtcm@pengutronix.de>
References: <20230531031001.7440-1-shuijing.li@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7wrtscz2pppnkeoz"
Content-Disposition: inline
In-Reply-To: <20230531031001.7440-1-shuijing.li@mediatek.com>
Precedence: bulk


--7wrtscz2pppnkeoz
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 31, 2023 at 11:10:01AM +0800, Shuijing Li wrote:
> There is a flow error in the original mtk_disp_pwm_apply() function.
> If this function is called when the clock is disabled, there will be a
> chance to operate the disp_pwm register, resulting in disp_pwm exception.
> Fix this accordingly.
>=20
> Fixes: 888a623db5d0 ("pwm: mtk-disp: Implement atomic API .apply()")
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Tested-by: Fei Shao <fshao@chromium.org>

When I sent my ack for v2, I missed there was already a v3, so here
again for the sake of easier maintenance:

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

> ---
> Changes in v3:
> Add Fixes per suggestion from the previous thread:

Note that for that a new version isn't necessary, patchwork (and I think
also b4) pick up a fixes line from replies.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--7wrtscz2pppnkeoz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSJiG8ACgkQj4D7WH0S
/k7apQf/QaFjN2bcdxDG3XjvUNxRfD7RzMDbbOJEbaqKBdj4v2M9frLXUojcBuu4
OEXHdWb10Ubr4+XXAFxEf/DEhL8ejeD+RCp3qGCThjEnjEpv1X9XuaUR4WdcplVJ
Aw1XlXDBIKULr/Mhmq9cvPQ7zJ0UYvLYDyKdK56QoItIoA60xHi37SSzWXWEzMCJ
Eiyav50MyLXNBzx8UciAX8xGnN/C58csjV+kcckEAhuG7bF+ge5h6CjZzcxbTI1v
hlzmQiRWt2NJsCd28aS4+7ibCtXW5GkYhGW1Gbxip8m/qlUw+CAelkrOBMK6ZQRL
86cczXryeWLJGY7qC8lzocKjBZdt1w==
=SoWt
-----END PGP SIGNATURE-----

--7wrtscz2pppnkeoz--