Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
From:   Mithil <bavishimithil@gmail.com>
Date:   Wed, 14 Jun 2023 14:43:03 +0530
Message-ID: <CAGzNGR=BkOMtw2PhudUs_b4ffk3B+x==9dtWuA-kcqnePaHVYA@mail.gmail.com>
Subject: Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power
To:     "robh@kernel.org" <robh@kernel.org>
Cc:     "bavishimithil@gmail.com" <bavishimithil@gmail.com>,
        "contact@paulk.fr" <contact@paulk.fr>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "lee@kernel.org" <lee@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "sre@kernel.org" <sre@kernel.org>,
        "tony@atomide.com" <tony@atomide.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Subject: Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for
twl6030-power

On Tue, Aug 23, 2022 at 12:54 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Aug 20, 2022 at 12:46:55PM +0530, Mithil Bavishi wrote:
> > Adds documentation for the twl6030 power driver.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> > ---
> >  .../bindings/power/reset/twl6030-power.txt    | 31 +++++++++++++++++++
>
> New bindings must be DT schema format.
>
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/reset/twl6030-power.txt b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> > new file mode 100644
> > index 000000000..946bb3d9f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> > @@ -0,0 +1,31 @@
> > +Texas Instruments TWL family (twl6030) reset and power management module
> > +
> > +For now, the binding only supports the complete shutdown of the system after
> > +poweroff.
> > +
> > +Required properties:
> > +- compatible : must be
> > +       "ti,twl6030-power"
> > +
> > +Optional properties:
> > +
> > +- ti,system-power-controller: This indicates that TWL6030 is the
>
> We have a generic property for this.
>

What is property is that? And how would it get implemented here?

> > +  power supply master of the system. With this flag, the chip will
> > +  initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > +  system poweroffs.
> > +
> > +Example:
> > +&i2c1 {
> > +       clock-frequency = <2600000>;
> > +
> > +       twl: twl@48 {
> > +               reg = <0x48>;
> > +               interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > +               interrupt-parent = <&intc>;
> > +
> > +               twl_power: power {
> > +                       compatible = "ti,twl6030-power";
> > +                       ti,system-power-controller;
>
> Why do you need a child node here? There aren't any resources for the
> sub-block.
>

Just an example and how it is used on a device as well, is it fine if
just the block is as-is?

Mithil