Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1957b1cf-28b7-dbfc-1675-ee4534e5571b@quicinc.com>
Date:   Wed, 14 Jun 2023 16:04:25 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH] arm64: dts: qcom: ipq9574: enable the SPI NOR support in
 RDP433
From:   Kathiravan T <quic_kathirav@quicinc.com>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230609081508.30982-1-quic_kathirav@quicinc.com>
 <c1c34aa4-ac7d-2c07-bf92-05d887aed3d2@linaro.org>
 <ed9d11cc-7ab4-b6c8-737b-bd89d3973e80@quicinc.com>
Content-Language: en-US
In-Reply-To: <ed9d11cc-7ab4-b6c8-737b-bd89d3973e80@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 6/14/2023 12:02 PM, Kathiravan T wrote:
>
> On 6/9/2023 2:37 PM, Konrad Dybcio wrote:
>>
>> On 9.06.2023 10:15, Kathiravan T wrote:
>>> RDP433 has the support for SPI NOR, add the support for it.
>>>
>>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>>> ---
>>> Note: This patch was part of initial submission
>>> https://lore.kernel.org/linux-arm-msm/20230329053726.14860-1-quic_kathirav@quicinc.com/ 
>>>
>>> however this got missed in between, so sending it across again.
>>>
>>>   arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 21 
>>> +++++++++++++++++++++
>>>   1 file changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts 
>>> b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
>>> index 2b3ed8d351f7..31ee19112157 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
>>> @@ -48,6 +48,20 @@
>>>       };
>>>   };
>>>   +&blsp1_spi0 {
>>> +    pinctrl-0 = <&spi_0_pins>;
>>> +    pinctrl-names = "default";
>>> +    status = "okay";
>>> +
>>> +    flash@0 {
>>> +        compatible = "micron,n25q128a11", "jedec,spi-nor";
>>> +        reg = <0>;
>>> +        #address-cells = <1>;
>>> +        #size-cells = <1>;
>> If you're not adding a partition table, you can drop the address-
>> and size-cells properties, as they determine what the reg value of
>> the child looks like.
>
>
> Sorry, somehow I missed this query. Will check and update it.


Currently IPQ boot loaders patches the partition information into the 
SPI node. To parse that, we need the address-cells and size-cells 
properties.

Also, this patch is now integrated into the below series

https://lore.kernel.org/linux-arm-msm/20230614085040.22071-1-quic_anusha@quicinc.com/T/#t


Thanks,


>
>
>>
>> Konrad
>>> +        spi-max-frequency = <50000000>;
>>> +    };
>>> +};
>>> +
>>>   &sdhc_1 {
>>>       pinctrl-0 = <&sdc_default_state>;
>>>       pinctrl-names = "default";
>>> @@ -96,6 +110,13 @@
>>>               bias-pull-down;
>>>           };
>>>       };
>>> +
>>> +    spi_0_pins: spi-0-state {
>>> +        pins = "gpio11", "gpio12", "gpio13", "gpio14";
>>> +        function = "blsp0_spi";
>>> +        drive-strength = <8>;
>>> +        bias-disable;
>>> +    };
>>>   };
>>>     &xo_board_clk {