Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2549173rwd; Wed, 14 Jun 2023 04:37:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6+XOsZpG6JfFzaLf2Y7J6NX+Oi2rVCBqAzUyKMU5WgFCPoKaF/9isr2FLLqCJNq/ajZs6p X-Received: by 2002:a05:6402:3cb:b0:514:a4cd:85d7 with SMTP id t11-20020a05640203cb00b00514a4cd85d7mr9672915edw.26.1686742628547; Wed, 14 Jun 2023 04:37:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686742628; cv=none; d=google.com; s=arc-20160816; b=Pqj0TFYR4qSfUTbqc3Inl+zTZcxfJ5pfR41ZzOGOrpTxVFfmsm7gR5Yz4EYN2+gH31 Msr/92s9tB6OirJ8ALKM1n18N7SKxY4xVKUuHcsRSAyFbuNKVcb6erUFN83HMJpWVf+a 2YZX4yO57K4M1SG6bfmhUvMtTZ4pcB5Aby63UADXqgzemyjzcaRSkaLqDR5JCdxQhKry 6M+XnIbM1QMsBq8/Yjm1Nd0HKnYUryYbIjriZDH6y2+hhLO4jEE/DyeXpiW6rvpGJoiB ZkTNAuRAfrq3XxfFRrasfqC4u2Vtkg9RtuYAGtuamw9B3YBbgyGiaZq/kPxre1npKdtC aOwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=f6JC4f9xG4netaVZIsiegU+QodoEJqozzT+iKXr0PXI=; b=sLH/AHKQHhQexVqGsq2XNF+7QKpSmkAuQCmzL1uELqrlVaa7md11NuENa/ntjSxk2A FK/VTBjB5jSe8wHxjgXkd/l2R8zGOCqc58Y0RXETTE934arbsAEjPsUd3F8moZ28SUyI 9fgBwGwv+yHML/MlXsjDSjCogbIDP1zuYtJJUsilLVtVDr+n7DgucDYLpFCi+IizdEgL CU9INWHSigY4zocGC6lbZrsRwm+53ioW3qtmv9gVcgEfu8yfKBxXy68zfCmfuCn9IR6O BCIp3GffdWqzID1DYniC7v/jQtfhoeDWFS78l85K0EmjsUHQfJO/XDChPuSJYSijm3Vw kIcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020aa7c387000000b00514a327b6fesi8391125edq.666.2023.06.14.04.36.44; Wed, 14 Jun 2023 04:37:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231812AbjFNLaZ convert rfc822-to-8bit (ORCPT + 99 others); Wed, 14 Jun 2023 07:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234041AbjFNLaY (ORCPT ); Wed, 14 Jun 2023 07:30:24 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7053E55 for ; Wed, 14 Jun 2023 04:30:21 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mtapsc-8-f8v9-c73Obe53UlMQEGF2A-1; Wed, 14 Jun 2023 12:30:18 +0100 X-MC-Unique: f8v9-c73Obe53UlMQEGF2A-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 14 Jun 2023 12:30:15 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Wed, 14 Jun 2023 12:30:15 +0100 From: David Laight To: 'Sven Schnelle' , Steven Rostedt CC: "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] tracing: fix memcpy size when copying stack entries Thread-Topic: [PATCH] tracing: fix memcpy size when copying stack entries Thread-Index: AQHZnqzKx3JbU4cZlkeCRQJzbO4XQa+KKVfQ Date: Wed, 14 Jun 2023 11:30:15 +0000 Message-ID: References: <20230612160748.4082850-1-svens@linux.ibm.com> <20230612123407.5ebcabdf@gandalf.local.home> <20230613113737.1e07c892@gandalf.local.home> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sven Schnelle > Sent: 14 June 2023 11:41 > > Steven Rostedt writes: > > > On Tue, 13 Jun 2023 07:19:14 +0200 > > Sven Schnelle wrote: > > > >> > Yes the above may be special, but your patch breaks it. > >> > >> Indeed, i'm feeling a bit stupid for sending that patch, should have > >> used my brain during reading the source. Thanks for the explanation. > > > > Does this quiet the fortifier? > > [..] > > No, still getting the same warning: > > [ 2.302776] memcpy: detected field-spanning write (size 104) of single field "stack" at > kernel/trace/trace.c:3178 (size 64) What about: (memcpy)(......) Or maybe: (__builtin_memcpy)(....) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)