Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 13:39:24 +0200
Message-ID: <87jzw69ssz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Lukasz Tyl <ltyl@hem-e.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, pgorgon@hem-e.com
Subject: Re: [PATCH] sound: usb: quirks: add flag for HEM devices to enable native DSD playback
In-Reply-To: <20230614113350.25607-1-ltyl@hem-e.com>
References: <20230614113350.25607-1-ltyl@hem-e.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 14 Jun 2023 13:33:50 +0200,
Lukasz Tyl wrote:
> 
> This commit adds new DEVICE_FLG with QUIRK_FLAG_DSD_RAW and Vendor Id for
> HEM devices which supports native DSD. Prior to this change Linux kernel
> was not enabling native DSD playback for HEM devices, and as a result,
> DSD audio was being converted to PCM "on the fly". HEM devices,
> when connected to the system, would only play audio in PCM format,
> even if the source material was in DSD format. With the addition of new
> VENDOR_FLG in the quircks.c file, the devices are now correctly
> recognized, and raw DSD data is transmitted to the device,
> allowing for native DSD playback.
> 
> Signed-off-by: Lukasz Tyl <ltyl@hem-e.com>
> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 3ecd1ba7fd4b..1414bf15ac21 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2197,6 +2197,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_DSD_RAW),
>  	VENDOR_FLG(0xc502, /* HiBy devices */
>  		   QUIRK_FLAG_DSD_RAW),
> +	VENDOR_FLG(0x3336, /* HEM devices */
> +		   QUIRK_FLAG_DSD_RAW),

The entry is sorted in vendor id number.  Could you try to put at the
right position?


thanks,

Takashi