Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04f5e3cb-d2f5-747c-1fd0-4b61d845e2c5@quicinc.com>
Date:   Wed, 14 Jun 2023 17:13:27 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for
 multipd model
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Kalle Valo <kvalo@kernel.org>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <jassisinghbrar@gmail.com>, <mathieu.poirier@linaro.org>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <quic_eberman@quicinc.com>, <quic_mojha@quicinc.com>,
        <loic.poulain@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
        <quic_kathirav@quicinc.com>, <quic_anusha@quicinc.com>,
        <quic_poovendh@quicinc.com>, <quic_varada@quicinc.com>,
        <quic_devipriy@quicinc.com>
References: <20230521222852.5740-1-quic_mmanikan@quicinc.com>
 <20230521222852.5740-2-quic_mmanikan@quicinc.com>
 <7940c743-815f-f864-d015-43d7e916ecfa@linaro.org>
 <a1456f62-d0a7-d5ec-b379-db1b6035c89c@quicinc.com>
 <d187eafb-4a80-9479-d063-3a01b47d8efa@linaro.org>
 <feb0d11d-0930-d0b8-ab6e-cf477bbf114b@quicinc.com>
 <87edmoitu3.fsf@kernel.org>
 <0555c089-9d0d-7d19-9646-f0f9b8630d12@quicinc.com>
 <5f9cc367-eaa5-4c19-4e5e-7052b0259ccf@linaro.org>
From:   Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
In-Reply-To: <5f9cc367-eaa5-4c19-4e5e-7052b0259ccf@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/7/2023 1:57 PM, Krzysztof Kozlowski wrote:
> On 07/06/2023 10:10, Manikanta Mylavarapu wrote:
>>
>>
>> On 6/6/2023 7:19 PM, Kalle Valo wrote:
>>> Manikanta Mylavarapu <quic_mmanikan@quicinc.com> writes:
>>>
>>>>>>>> +
>>>>>>>> +    properties:
>>>>>>>> +      compatible:
>>>>>>>> +        enum:
>>>>>>>> +          - qcom,ipq5018-wcss-ahb-mpd
>>>>>>>> +          - qcom,ipq9574-wcss-ahb-mpd
>>>>>>>> +          - qcom,ipq5018-wcss-pcie-mpd
>>>>>>>
>>>>>>> Keep rather alphabetical order (so both 5018 together).
>>>>>>>
>>>>>>> I also do not understand these at all. Why adding bus type to
>>>>>>> compatible? This rarely is allowed (unless it is PCIe controller within
>>>>>>> soc).
>>>>>>>
>>>>>> IPQ5018 SOC has in-built PCIE controller. Here QDSP6 will bring up
>>>>>> external(PCIE) and internal (AHB) wifi radio's. To separate AHB, PCIE
>>>>>> radio's properties, i have added bus type to compatible.
>>>>>
>>>>> It's the same device - WCSS - right? We do not create multiple nodes and
>>>>> compatibles for the same devices. Bus suffixes are almost never parts of
>>>>> compatibles.
>>>>
>>>>
>>>> No it's not the same device. WCSS on inside IPQ5018 and WCSS attached
>>>> via pcie to IPQ5018. Here QDSP6 managing both WCSS's.
>>>>
>>>> So for better clarity i will use attached SOC ID in compatible.
>>>> Below are the new compatible's.
>>>>
>>>> - qcom,ipq5018-wcss-mpd //IPQ5018 internal radio
>>>> - qcom,ipq9574-wcss-mpd	//IPQ9574 internal radio
>>>> - qcom,qcn6122-wcss-mpd //IPQ5018 attached radio
>>>
>>> What mandates that there's just one QCN6122 device attached to PCI?
>>> Assuming fixed PCI configurations like that makes me worried.
>>>
>>
>> IPQ5018 always has one internal radio, attached pcie radio's depends on
>> no of pcie ports. IPQ5018 has 2 pcie ports, so it supports max two
>> qcn6122 devices. One compatible (qcom,qcn6122-wcss-mpd) itself support's
>> number of pcie devices controlled by QDSP6.
> 
> So this is hot-pluggable (or at least board-pluggable), then should not
> be a part of static DTS.
> 
> Some concepts of virtual-processes is anyway far away from hardware
> description, thus does not fit into DTS. Adding now to the equation PCIe
> with variable number of such processes, brings us even further.
> 
> This is not a DT property. Remember - DT describes hardware.
> 
> Best regards,
> Krzysztof
> 

In the multipd architecture based Socs, There is one Q6 DSP which runs 
the OS/kernel and there are one or more instances of WCSS radios
(It can be either internal or pcie attached).
These WCSS cores are controlled by the Q6 (Q6 DSP brings wcss radios out 
of reset/ shuts it down etc). Q6 forms the 'root Protection domain' and 
the wcss radios are termed as the 'user protection domain'.
The compatible's that is being added here are to manage the 'root 
domain' and 'user domain'.
Not sure if using the words 'pcie'/'ahb' made it confusing.
So, 'qcom,ipq5018-q6-mpd' and 'qcom,ipq5018-wcss-mpd'.

There will be multiple instances of 'qcom,ipq5018-wcss-mpd' in DT based 
on number of wcss radios connected on that board and only one instance 
of 'qcom,ipq5018-q6-mpd'.

Is this approach ok ?

Thanks & Regards,
Manikanta.