Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 14:46:27 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     Peng Zhang <zhangpeng362@huawei.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, wangkefeng.wang@huawei.com,
        sunnanyong@huawei.com
Subject: Re: [PATCH] memblock: use the helper macro for_each_zone
Message-ID: <20230614114627.GW52412@kernel.org>
References: <20230612125102.1674568-1-zhangpeng362@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612125102.1674568-1-zhangpeng362@huawei.com>
Precedence: bulk

On Mon, Jun 12, 2023 at 08:51:02PM +0800, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
> 
> Let's use the helper macro for_each_zone to iterate over all memory
> zones and reset the node managed pages. After that, we can remove the
> unused function reset_node_managed_pages.

Are you sure it's safe to use for_each_zone() in all users of
reset_all_zones_managed_pages()?
 
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
> ---
>  mm/memblock.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index da4264528e1e..af552604c3fb 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -2122,23 +2122,15 @@ static unsigned long __init free_low_memory_core_early(void)
>  
>  static int reset_managed_pages_done __initdata;
>  
> -static void __init reset_node_managed_pages(pg_data_t *pgdat)
> -{
> -	struct zone *z;
> -
> -	for (z = pgdat->node_zones; z < pgdat->node_zones + MAX_NR_ZONES; z++)
> -		atomic_long_set(&z->managed_pages, 0);
> -}
> -
>  void __init reset_all_zones_managed_pages(void)
>  {
> -	struct pglist_data *pgdat;
> +	struct zone *z;
>  
>  	if (reset_managed_pages_done)
>  		return;
>  
> -	for_each_online_pgdat(pgdat)
> -		reset_node_managed_pages(pgdat);
> +	for_each_zone(z)
> +		atomic_long_set(&z->managed_pages, 0);
>  
>  	reset_managed_pages_done = 1;
>  }
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.