Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 14:05:15 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: felix: fix taprio guard band overflow at
 10Mbps with jumbo frames
Message-ID: <ZIms+0/KDpU9dd3y@corigine.com>
References: <20230613170907.2413559-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613170907.2413559-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K46lUTkJCKmx1g1UmB2YoLISIEWJjl4vgPVXyLpWil4HY0WIPijy72iHH7Ox?=
 =?us-ascii?Q?RS+dpYh3AM/PpkIw728ou3LURsndLFJTHCeTUqxgSxR8FoqN7DdIxcc+T8Jz?=
 =?us-ascii?Q?irPxvjNYvp+Ql0az1M7OXlENW1V3uLWferGd1G7Zu8nnA9NwLPcDlmI5P1Oh?=
 =?us-ascii?Q?QjvdgRQI/Q+sUbFK8XVjOvwflUnduyklyiyL1NgU/M5s4iUxB16XAkH9OBBS?=
 =?us-ascii?Q?bj2ivLYJJiIGyziHln8RRW3dccY+B4WDwTL1D9kUjnn47EIqFr6EPpsjVFKy?=
 =?us-ascii?Q?HvKql9fMdaAdepWXzY/SQ+Cc/cD6eYvGeiq5wRrlII638TskmVONnQCGXGd6?=
 =?us-ascii?Q?o03ZN0gvBzNEfqvfe3pVB3l/1qU5ZWoMA3H/R/+xkTh3ilIIxQNC/mlqNl+Y?=
 =?us-ascii?Q?sDH+4qwGWcpa8DJChb13vshk1bvl6aCLm0eJUkJ14ei0mEfHtuoG+7zmMaWq?=
 =?us-ascii?Q?GMtkUzSBvyQ+lsnbGMGR5OGXFReJ9PMMUxA+sA5Hq8XWFq6qvVQzKpScYXnI?=
 =?us-ascii?Q?M21mdm+rl6SBzdFiN9AvF/OayS3W7v6wHX+cbyuS9LxJm/zJwzQ7LQdTKU8m?=
 =?us-ascii?Q?bNixdiunvcTnxk9/D5JOiMYVsz5RNOhxuAThv+GLwBxaO+LeKEBDQvzrf8Ke?=
 =?us-ascii?Q?cO9rE6LlSh/Ft4KzplhOCLTv4R3eq5d+iHnWGrOmREXr8F8bx6f46GNWUPKY?=
 =?us-ascii?Q?Uf+32T3Aj5gnH3YnNcf9RcyRYnsc0zxHv46MfGdcEdnpU0QTOJUuhbETeGK3?=
 =?us-ascii?Q?h3asK4V4q+D+iLIkacxBekHeZHt6MP+dqnLQxDNEzgzqeNrwlxZfM+f8bd/f?=
 =?us-ascii?Q?odKFUgP871AADFCNDkU/zQ8G1X+o8kO6EMaxtkAfwHUjK+0KWVEXFrJ2cFXh?=
 =?us-ascii?Q?tAFGb+oie0f7iv4zVuk9vjR1y/qJyrE84uPnGR3Bypxe+c9ljAMGUxhAYkZ6?=
 =?us-ascii?Q?SgbwfRyAk3BMd1w9nCOsGtIeMYBFzcvt4rxIv6NZ63Pj00/953bhyBusUfvO?=
 =?us-ascii?Q?7qNv6y9TPt73GzL6QLrjH0yq1bWaYwgyUihUD7+jbsUuAQfDxtyKUNyOmGfP?=
 =?us-ascii?Q?cKAZu85Bw7JC2OaWmtJHNiOSbSdBoMz+1EfkEbBUdp8TRXmeBapfk5WOgvHv?=
 =?us-ascii?Q?U5SNZjy/4Ncwy1X9MmFYtmRnqLXqmI4P0v4FbprTzJhqO9FcxuJBpIcAaoZP?=
 =?us-ascii?Q?VA28I2kLT4zUGOmwYKvP7jGW70LKS9SZ8e0BMW19YRRADdM2MaXVBEtkCdHb?=
 =?us-ascii?Q?x9ugxMD4hrEfUHOPe5pEv5nVcGRD0vaXtCDTPmEhT3B4lIbV8fU/tXzTwiXI?=
 =?us-ascii?Q?BpHMURWria/P2o3/yEJAGY80MyjQFNN0ZcITHfbs+fYT5gyLBxCVpYtQGqFt?=
 =?us-ascii?Q?IgLJar2aykvlD6CYle8oVAH/L8dxdVpNMIDw27QZCXng3J+ZchgAAAVceYOV?=
 =?us-ascii?Q?VWDODmcTT8TgtCRZ0OOqRGOoZidfHDfGjU+vEnezO438QL0wA91wdt0dXc0o?=
 =?us-ascii?Q?ag5UlV4EQ9m137dZcQHhu7Qo7Wo5/vKaS1Sm2n7D5Fp6CO1kjjdIQACDCXVj?=
 =?us-ascii?Q?JihEzgGioYy7GYW3Mf1FusCg5cBi3j4zATYh8inCpM6XcGpUD6VRa1tUEest?=
 =?us-ascii?Q?5cHIPPNm0z80CG5UAaZA50sD/Bauv9V+PglP7o/4JQX/AYgD2OTk/1isWY8D?=
 =?us-ascii?Q?pyj0Bw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edfcd88f-a503-43ad-01c0-08db6ccfa154
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 12:05:22.5309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: htt/KK9gpD0cbfKD9XdNiXFStPlz4ir2Lbl8hywciyb/CERjqkmArWL5oRMv2WFKNQloeuhqQZIiiEXI7gL70TNThUc6FHCN/jZ9EqS1eD8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR13MB5164
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 13, 2023 at 08:09:07PM +0300, Vladimir Oltean wrote:
> The DEV_MAC_MAXLEN_CFG register contains a 16-bit value - up to 65535.
> Plus 2 * VLAN_HLEN (4), that is up to 65543.
> 
> The picos_per_byte variable is the largest when "speed" is lowest -
> SPEED_10 = 10. In that case it is (1000000L * 8) / 10 = 800000.
> 
> Their product - 52434400000 - exceeds 32 bits, which is a problem,
> because apparently, a multiplication between two 32-bit factors is
> evaluated as 32-bit before being assigned to a 64-bit variable.
> In fact it's a problem for any MTU value larger than 5368.
> 
> Cast one of the factors of the multiplication to u64 to force the
> multiplication to take place on 64 bits.
> 
> Issue found by Coverity.
> 
> Fixes: 55a515b1f5a9 ("net: dsa: felix: drop oversized frames with tc-taprio instead of hanging the port")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

In a similar vein, you may want to consider the following suggestion from
Coccinelle.

  .../felix_vsc9959.c:1382:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.