Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <572c2826-82e8-ccd5-c870-cfea99c759dc@quicinc.com>
Date:   Wed, 14 Jun 2023 17:26:29 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V3 2/5] clk: qcom: Remove support to set CAL_L field in
 lucid evo pll configure
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Andy Gross <agross@kernel.org>,
        "Michael Turquette" <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC:     Bjorn Andersson <andersson@kernel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        Vinod Koul <vkoul@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Taniya Das <quic_tdas@quicinc.com>,
        Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
        Imran Shaik <quic_imrashai@quicinc.com>,
        Ajit Pandey <quic_ajipan@quicinc.com>
References: <20230601143430.5595-1-quic_jkona@quicinc.com>
 <20230601143430.5595-3-quic_jkona@quicinc.com>
 <1d29bc3f-12db-a676-56f8-b8c1a09063dc@linaro.org>
 <e9781cda-8eb4-99e0-8ed7-09c2534638e0@quicinc.com>
 <71d5758c-793a-3e9a-543f-19e326ecfcd4@linaro.org>
From:   Jagadeesh Kona <quic_jkona@quicinc.com>
In-Reply-To: <71d5758c-793a-3e9a-543f-19e326ecfcd4@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 6/9/2023 6:18 PM, Konrad Dybcio wrote:
> 
> 
> On 9.06.2023 13:49, Jagadeesh Kona wrote:
>> Hi Dmitry,
>>
>> Thanks for your review!
>>
>> On 6/1/2023 8:16 PM, Dmitry Baryshkov wrote:
>>> On 01/06/2023 17:34, Jagadeesh Kona wrote:
>>>> For lucid evo and ole pll's the CAL_L, RINGOSC_CAL_L and L_VAL are
>>>> part of the same register, hence update the l configuration value
>>>> to include these fields across all the chipsets.
>>>>
>>>> Since the l configuration value now includes both L and CAL_L fields,
>>>> there is no need to explicitly set CAL_L field again in lucid evo pll
>>>> configure, Hence remove support to explicity set CAL_L field for evo pll.
>>>>
>>>> Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces")
>>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>>>> ---
>>>> Changes since V2:
>>>>    - Squashed update L val and remove explicit cal_l configuration to single patch
>>>>    - Updated L configuration for gpucc-sm8450 as well which was merged recently
>>>> Changes since V1:
>>>>    - Newly added.
>>>>
>>>>    drivers/clk/qcom/camcc-sm8450.c  | 24 ++++++++++++++++--------
>>>>    drivers/clk/qcom/clk-alpha-pll.c |  6 +-----
>>>>    drivers/clk/qcom/dispcc-sm8450.c |  6 ++++--
>>>>    drivers/clk/qcom/dispcc-sm8550.c |  6 ++++--
>>>>    drivers/clk/qcom/gpucc-sa8775p.c |  6 ++++--
>>>>    drivers/clk/qcom/gpucc-sm8450.c  |  6 ++++--
>>>>    6 files changed, 33 insertions(+), 21 deletions(-)
>>>
>>> I'd say, this is still not a correct solution from my point of view. A correct solution would be to follow the existing code and use constants for the constant values (of CAL_L, and RINGOSC_CAL_L).
>>>
>>
>> Sure, will keep the existing code as is and will remove this patch in the next series.
>>
>>>>
>>>> diff --git a/drivers/clk/qcom/camcc-sm8450.c b/drivers/clk/qcom/camcc-sm8450.c
>>>> index 51338a2884d2..6a5a08f88598 100644
>>>> --- a/drivers/clk/qcom/camcc-sm8450.c
>>>> +++ b/drivers/clk/qcom/camcc-sm8450.c
>>>> @@ -57,7 +57,8 @@ static const struct pll_vco rivian_evo_vco[] = {
>>>>    static const struct clk_parent_data pll_parent_data_tcxo = { .index = DT_BI_TCXO };
>>>>    static const struct alpha_pll_config cam_cc_pll0_config = {
>>>> -    .l = 0x3e,
>>>> +    /* .l includes CAL_L_VAL, L_VAL fields */
>>>> +    .l = 0x0044003e,
>>>>        .alpha = 0x8000,
>>>>        .config_ctl_val = 0x20485699,
>>>>        .config_ctl_hi_val = 0x00182261,
>>>> @@ -128,7 +129,8 @@ static struct clk_alpha_pll_postdiv cam_cc_pll0_out_odd = {
>>>>    };
>>
>> [skipped]
>>
>> Thanks & Regards,
>> Jagadeesh
> Another non-patch-related nit, you don't have to (and shouldn't) cut off
> parts of the email unless it helps you "get to the point". You can also
> include your signature after the last paragraph you reply with.
> 
> Konrad

Sure, will take care from now.

Thanks,
Jagadeesh