Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 07:03:03 -0500
From:   Nishanth Menon <nm@ti.com>
To:     "Kumar, Udit" <u-kumar1@ti.com>
CC:     Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Neha Malcom Francis <n-francis@ti.com>
Subject: Re: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add
 wakeup_uart pinmux
Message-ID: <20230614120303.5ievpixlpjb3wtdz@elective>
References: <20230601183151.1000157-1-nm@ti.com>
 <20230601183151.1000157-7-nm@ti.com>
 <22b67e80-1f5f-d8e0-3c85-c69d97ea0d39@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <22b67e80-1f5f-d8e0-3c85-c69d97ea0d39@ti.com>
Precedence: bulk

On 19:26-20230613, Kumar, Udit wrote:
> Hi Nishanth,
> 
> On 6/2/2023 12:01 AM, Nishanth Menon wrote:
> > Define the wakeup uart pin-mux for completeness. This allows the
> > device tree usage in bootloader and firmwares that can configure the
> > same appropriately.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >   arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > index c13246a9ed8f..bc53ca566a68 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > @@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
> >   		>;
> >   	};
> > +	wkup_uart0_pins_default: wkup-uart0-pins-default {
> > +		pinctrl-single,pins = <
> > +			J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
> > +			J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */
> > +		>;
> > +	};
> > +
> >   	mcu_usbss1_pins_default: mcu-usbss1-pins-default {
> >   		pinctrl-single,pins = <
> >   			J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */
> > @@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO
> >   &wkup_uart0 {
> >   	/* Wakeup UART is used by TIFS firmware. */
> >   	status = "reserved";
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&wkup_uart0_pins_default>;
> >   };
> 
> 
> If you like to consider alias for wkup_uart0 for this board ,
> 
> Just to align with other boards for this SOC family.? I understand
> wkup_uart0 is not being used.

Vignesh,
could you squash this locally OR if you like, I can post a v2:

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index 3304460f6a0b..9922d7bb061f 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -20,6 +20,7 @@ / {
 	model = "BeagleBoard.org BeagleBone AI-64";
 
 	aliases {
+		serial0 = &wkup_uart0;
 		serial2 = &main_uart0;
 		mmc0 = &main_sdhci0;
 		mmc1 = &main_sdhci1;

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D