Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 14:10:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Azeem Shaikh <azeemshaikh38@gmail.com>
Cc:     Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        linux-hardening@vger.kernel.org, netfilter-devel@vger.kernel.org,
        coreteam@netfilter.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipset: Replace strlcpy with strscpy
Message-ID: <ZImuKWESPMLOiK/l@corigine.com>
References: <20230613003437.3538694-1-azeemshaikh38@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613003437.3538694-1-azeemshaikh38@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wOIIV9mxHZPkN5NlbLxxEXbwHaa90tuzGOE4xNZD635M/QsJktY/rziY9O4A?=
 =?us-ascii?Q?aGvL/iPRKOq0f1e2XzL9m5+CCAwKH5Byq2NjQFCV1oJMXCZLO2zbBJ/Vj8xZ?=
 =?us-ascii?Q?U2pzcvSemTI5PAXdAtE978ygTJpb/e9CPh7tZMBt0f9MRnalHhc0rPABGSFZ?=
 =?us-ascii?Q?vYYeMdSUvjTgAudaFBVLLL0OK86ZlJrUaztbWVp07yLcHRLuQqMJVcx5DO1N?=
 =?us-ascii?Q?pj7OCVqLrojDhXDXQltNEOIbpPGrKsUxqVXy6Qk7lZzX9kdnakXWpzpfYGBE?=
 =?us-ascii?Q?HqmrDE0zIEKr6fV/AYPoqqOcOoZ/ZWt+m3tky7c1byN4EjrB7FVTXt+75MBC?=
 =?us-ascii?Q?njiFENKRfMhEB8UBi2FDGCO+V1xKD78VjEbyrUNcQoDrh+0lS8tfCo9eNkFz?=
 =?us-ascii?Q?yUGce+BXzIBauV4s6gSJEOwMmrgR/uKKnRpl5cZzaeJ1KlCfOfvQTI/QyXXZ?=
 =?us-ascii?Q?X/clK1FZpjgD8lZ+NozQ0GPneJ+3radDy+TPCUT6VUDKloLx954JQHBusr4S?=
 =?us-ascii?Q?MZVxZzk+QWriqK2NnCasTd+lyuKn/FIB3Te+pOBaxVYEfsWC2WwibGyk63UC?=
 =?us-ascii?Q?zioeZmqcKZ6rVRberIiUdYspTP9MFxr/Jv2NL3EZobhXX8nQCQ9jLO5vE4n8?=
 =?us-ascii?Q?1Ilzrq59+06SIYYLn4VBxp6InjbCZncYrJMxrCkNGemh4vlUvFaDKLJVh41y?=
 =?us-ascii?Q?2sh5Lz3aIG4qhPde98p4ev7rNvCpXZ/YCHDI7cI9d4GgRZQ7W4ZnhMtuKSw/?=
 =?us-ascii?Q?LXLeXxQJBwMCDxXDNU+nzOiWpAuNKSC4/sSgFtcAOnTXQBceGoysUPtfuHeJ?=
 =?us-ascii?Q?olxYW9VcCJPHRv1AI7vuyJRM5z4sRrNcu8IrfBNKE9XcreuqhXpNfvYebVOM?=
 =?us-ascii?Q?VMWPcabeySDmUh9QZ7COjzkzXrMdYR7DKZ23VbSK4KW/qLFUJfDW5Gpc8C0F?=
 =?us-ascii?Q?jKC7wrElTtRLCbAVpEL6xXB8vtdutJAcj72s9XImu+OKcLTnwV7lZqnUIuJV?=
 =?us-ascii?Q?kIa4262LoH2TeyysQAZREvLXLcLv8Qn/toUuD/D09ZrqQ7+E94Kt0dXxyODC?=
 =?us-ascii?Q?KRxmv8YzIU7cF5PCvDfTU3iKXf0W4Ki84MmomQsQfLoMz3AT1k75+2TbAFVo?=
 =?us-ascii?Q?XxOGEm5FK8eMOxSWB82qrYzsboqypCyqwuWFMs4obQPNGFv2CGlIUYKiq6L4?=
 =?us-ascii?Q?4awsj8KPGI8z9PS2Z/2VhhHrxIgJdmbQ+Lrjl20BKjXyMJyRFYp4V26HFWVn?=
 =?us-ascii?Q?m8TwZm+/t02P1lMwA+DzuYDgwHS1YKuIvQm1BtcPVMnWRCNJB0uDcbQu71ZB?=
 =?us-ascii?Q?2QMHrxUlxxaAW+YfypONiuzOzcpPeexI8edGQs6kPSX+CIfMhFQ4O17VJKRq?=
 =?us-ascii?Q?+378D4uCFpP68fN0qLGjgPWR4l7D/KkZeGpckA6lVyTyqcyGvCA8johLamp7?=
 =?us-ascii?Q?EwHp04cYkLk/vn8NCgVvOFAOjPR7rJaqmYy7SLW4ybHcC99Xblwm4Gx4y2+w?=
 =?us-ascii?Q?1eyHmMDrvE6YXqOp7Og+PmyRPDer8VOC9fjPCuSImt2LXUo9gj4Ler4b2QAF?=
 =?us-ascii?Q?DzFhMV9XUoZ5Y52YHCHXt+0oNDG7Q7/+KpVVUgib+aCJdrpcphG6qxVm6txH?=
 =?us-ascii?Q?VaQiABh7r/oDRFbGSBcxd0gQFHWfOVz1NEVR9Bu3WBW/3y2bZ9cK2r81Y6nt?=
 =?us-ascii?Q?AtiiXQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f4b380c-776f-46e6-f37b-08db6cd0554a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 12:10:24.5232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lz2hXQiOuNauZgerJo02Q7hAkPQ067oaq8+zEjC57dsDwUAJBbRQlZo0OFOI8gigUPR0ZwQ4gH4qavPtRebBQR52clS8vfTtQcKwhIUN6hs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR13MB4043
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 13, 2023 at 12:34:37AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> 
> Direct replacement is safe here since return value from all
> callers of STRLCPY macro were ignored.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
> 
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>