Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614061130.64214-1-zhanglibing@cdjrlc.com> <5cc396aff142acbc4ba4b2541a5e4d71@208suo.com>
In-Reply-To: <5cc396aff142acbc4ba4b2541a5e4d71@208suo.com>
From:   Julian Calaby <julian.calaby@gmail.com>
Date:   Wed, 14 Jun 2023 22:11:30 +1000
Message-ID: <CAGRGNgUW30BYGyPOwwV-zteO7O4gjVgZ4NsoP-xLhuG994bL7A@mail.gmail.com>
Subject: Re: [PATCH] sparc/kernel: Fix syntax error
To:     wuyonggang001@208suo.com
Cc:     davem@davemloft.net, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Yonggang,

On Wed, Jun 14, 2023 at 4:19=E2=80=AFPM <wuyonggang001@208suo.com> wrote:
>
> Fix the following checkpatch error:
>
> ERROR: space required before the open parenthesis '('
> ERROR: do not initialise statics to 0
> ERROR: trailing whitespace

While this patch is mostly correct and is fixing real issues with this
code, it is very old code in a very old part of the kernel and the
maintainers are unlikely to apply it as they'd prefer to leave it
as-is and not introduce any potential for regressions.

>
> Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
> ---
>   arch/sparc/kernel/apc.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/sparc/kernel/apc.c b/arch/sparc/kernel/apc.c
> index ecd05bc0a104..40b9c72ad4d9 100644
> --- a/arch/sparc/kernel/apc.c
> +++ b/arch/sparc/kernel/apc.c
> @@ -162,7 +162,7 @@ static int apc_probe(struct platform_device *op)
>       if (!apc_no_idle)
>           sparc_idle =3D apc_swift_idle;
>
> -    printk(KERN_INFO "%s: power management initialized%s\n",
> +    pr_info("%s: power management initialized%s\n",

While this is most likely harmless, this is technically a change in
behaviour and should have been noted in the commit message. Also, as
this is technically a change in behaviour, it will make it even less
likely that this will be applied.

Thanks,

--=20
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/