Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614004857.134980-1-kimseer.paller@analog.com>
 <20230614004857.134980-2-kimseer.paller@analog.com> <CAHp75VcTXsZZ4JsKWS0RuccPKRLO9ci+87b538BT9V9ZZ_WACg@mail.gmail.com>
 <a6488485909d40b3810ad15787cd2100@analog.com>
In-Reply-To: <a6488485909d40b3810ad15787cd2100@analog.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 14 Jun 2023 14:53:12 +0300
Message-ID: <CAHp75VdQJ39Uw8bPD+y7GS7W2iJhjs2D4L-=-Fo0Jeb+8Ffn8g@mail.gmail.com>
Subject: Re: [PATCH v6 2/2] iio: adc: max14001: New driver
To:     "Paller, Kim Seer" <KimSeer.Paller@analog.com>
Cc:     "jic23@kernel.org" <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 14, 2023 at 1:43=E2=80=AFPM Paller, Kim Seer
<KimSeer.Paller@analog.com> wrote:
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Wednesday, June 14, 2023 5:12 PM

...

> > > +               /* select external voltage reference source for the A=
DC */
> > > +               ret =3D max14001_reg_update(st, MAX14001_CFG,
> > > +                                         MAX14001_CFG_EXRF, 1);
> > > +
> > > +               ret =3D regulator_get_voltage(vref);
> > > +               if (ret < 0)
> > > +                       return dev_err_probe(dev, ret,
> > > +                                            "Failed to get vref\n");
> >
> > Is it important to choose the external reference source _before_ gettin=
g the
> > voltage of the regulator? If not, I would swap these calls, otherwise t=
he
> > comment is needed to explain why the sequence is important in the way i=
t's
> > written.
>
> It is not important. These calls can be swap without any issues.

If you send a new version, please swap, otherwise I hope Jonathan can
do it when applying.

--=20
With Best Regards,
Andy Shevchenko