Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce4a3201-3d42-b6fe-9e1a-63ea74588531@linaro.org>
Date:   Wed, 14 Jun 2023 13:25:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 2/8] arm64: dts: qcom: msm8939: Disable lpass_codec by
 default
Content-Language: en-US
To:     Stephan Gerhold <stephan@gerhold.net>,
        Bjorn Andersson <andersson@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230530-msm8939-regulators-v1-0-a3c3ac833567@gerhold.net>
 <20230530-msm8939-regulators-v1-2-a3c3ac833567@gerhold.net>
From:   Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <20230530-msm8939-regulators-v1-2-a3c3ac833567@gerhold.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/06/2023 08:16, Stephan Gerhold wrote:
> Update for recent changes to msm8916.dtsi in commit a5cf21b14666
> ("arm64: dts: qcom: msm8916: Disable audio codecs by default") and
> make lpass_codec disabled by default for devices that are not using
> the audio codec functionality inside MSM8939.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>   arch/arm64/boot/dts/qcom/apq8039-t2.dts | 4 ++++
>   arch/arm64/boot/dts/qcom/msm8939.dtsi   | 1 +
>   2 files changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8039-t2.dts b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
> index 2a39216ceef5..c8442242137a 100644
> --- a/arch/arm64/boot/dts/qcom/apq8039-t2.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
> @@ -135,6 +135,10 @@ &lpass {
>   	status = "okay";
>   };
>   
> +&lpass_codec {
> +	status = "okay";
> +};
> +
>   &mdss {
>   	status = "okay";
>   };
> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> index 3c1505b69a6b..895cafc11480 100644
> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> @@ -1608,6 +1608,7 @@ lpass_codec: audio-codec@771c000 {
>   				 <&gcc GCC_CODEC_DIGCODEC_CLK>;
>   			clock-names = "ahbix-clk", "mclk";
>   			#sound-dai-cells = <1>;
> +			status = "disabled";
>   		};
>   
>   		sdhc_1: mmc@7824900 {
> 

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>