Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Christian Marangi <ansuelsmth@gmail.com>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jose Abreu <Jose.Abreu@synopsys.com>
Subject: RE: [net-next PATCH v5 4/5] net: ethernet: stmicro: stmmac: generate
 stmmac dma conf before open
Thread-Topic: [net-next PATCH v5 4/5] net: ethernet: stmicro: stmmac: generate
 stmmac dma conf before open
Thread-Index: AQHYnqCzb/lINFBB6kaBEWXyCUbVca+L4V/w//+tuwCAAMDMQA==
Date:   Wed, 14 Jun 2023 13:48:40 +0000
Message-ID: <DM4PR12MB508899B25BA18E2E53939BE7D35AA@DM4PR12MB5088.namprd12.prod.outlook.com>
References: <20220723142933.16030-1-ansuelsmth@gmail.com>
 <20220723142933.16030-5-ansuelsmth@gmail.com>
 <DM4PR12MB508882D5BE351BD756A7A9A4D35AA@DM4PR12MB5088.namprd12.prod.outlook.com>
 <64898745.5d0a0220.546a.a6f1@mx.google.com>
In-Reply-To: <64898745.5d0a0220.546a.a6f1@mx.google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kDFsLWYr4pGiaA1UI4p414eD8TJtXbyyiOs+ah6SHGRwgU9OPJ6YU0YQGNEG?=
 =?us-ascii?Q?/NexwBZ4WUD3DTz+TO32s9eszOJsJqNANhB6YFMHnhdx9KJjVFKggK4Y0XYn?=
 =?us-ascii?Q?JFveliJx2enTXqk4dWGnYiJ5RgJFU7lVHRMNbU+iA1Lz8J4ZglytsUu5V42j?=
 =?us-ascii?Q?pzO8I2Q6k/olAJjm8AR/07SnbSc+JsOo5oGV9X6q3nT6SM3jMyiXpDV6lAB+?=
 =?us-ascii?Q?v3cbPp76Trhn8eHlkb9w9DeWSIzVZr6jJvpCOxh5vUwcBm/1eJ3zocbJBsAU?=
 =?us-ascii?Q?d0Xn9K7KQp1F3RiEslgNN0ck2LoWhHUhrFDOsbjThs4IW/T2N0axQFLJKkIF?=
 =?us-ascii?Q?Mb08T7SpSNtlLog2fadad/4e9pd7CReVWu71dix7Bm7AfWeuuM1wd0GpTiJw?=
 =?us-ascii?Q?rlOBrufeASnBcGsjOHKdKkORviBhbGcPiWP9t7gB4uBKswe3hTFy8573Iebe?=
 =?us-ascii?Q?tHSqt+k9/QdNudL3HKZqck/2wmUUG/25oF836mvFvPWdWSY7UDUHZMlug/IQ?=
 =?us-ascii?Q?DplvGCDH9ETg91i54OwjjGuYPX77e8aWiX8C6A1/w/R9HjXOTbg1ax/Td1Rs?=
 =?us-ascii?Q?NpcmqjUHZ6N4FOmS0AdX50yAk1KextkvJcKAqGjkgb1NvxzR9QplIySURx7p?=
 =?us-ascii?Q?nptQ5+zRKjWVGXsnf0+UW/VxvKDuT5Vf8LQMUbLkfoLSV/ltM3dxY3pFb1Ef?=
 =?us-ascii?Q?7Dp0N/kG3ZGEI4kJh1I3ogngY7ETIKSbgZcd/0jTDJx1Ls0Y46AVgFNDbg3a?=
 =?us-ascii?Q?PM3pxO12fwm9gydtE/1ePG7uRTSyZO/f+6XI64Lm3onIGQny+WRfETIgp+QM?=
 =?us-ascii?Q?0oVxyQR/H7uGgd3BjtE9alxKlBYU3cNpUtTWV3SY+C3gEqp56BCc+omUrur/?=
 =?us-ascii?Q?5Ikm34DMnWqgsDLFzMp3X5eP9HMj9XcVbzE/BY/tWBd3jMDorpMqCTZcZH9Y?=
 =?us-ascii?Q?ZLWJ3Vl9jaSIgR9mORM/vBT7ZY38RZxMm5Bg95AJaNnkUrWHMTh6qLcAx6d3?=
 =?us-ascii?Q?fpyZLOPRkhdNnUkn+Sv8M6f/UXGl94egZPlXa8DFGQ5KYb+YlgcISFIzYBdq?=
 =?us-ascii?Q?UZhvfrBvbageYTwVQuqQTBgJdHT7c3e7HJsyCp/E5oG+Z3qjwSRzwxXf0DXn?=
 =?us-ascii?Q?pfGXhTzeZe3zHvvnGLGWWmEF4nQ7KtRuRm6yl5+vaCbukwdsLNC69ROK//rY?=
 =?us-ascii?Q?6mukObQ/H+abcxT+NkALcEr5FT8yp3g3hJ5nChCHvEEMUbxr46yfh6fFmuX1?=
 =?us-ascii?Q?zXACd2/JRyyDUZ/U5ALt8mwlYMxsux875Ow50pASzwpn1u3vsEiY29dWHdWp?=
 =?us-ascii?Q?8BJtNe2UpsidwUgg8f80s0JiawRRd379pOAr6WJGZWCsT8Q2kGlw8s3SzRZ2?=
 =?us-ascii?Q?HjvJeTYbPo0c1BriBGw7nvgW9FYbW4fz+WG4MSJ9LL3zAFhso/clpgMsF14p?=
 =?us-ascii?Q?7tswIQDQZTJ+v+uGIB0WQAKz9xM1RXcDXd7xrVbmBgK0Z71XBsxJgNl+dmxX?=
 =?us-ascii?Q?uT5LWYTRRTnrc+T/b9K9DpiEVDIhmYh9Hhb8BqeAZzZsj1cNU6Lpb+N7GA?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?H36S6J/qT/2BiJbUuB2msRAx+Bd3JtkjVxmeS72dKjCPC6dIZvUT4D0fa5op?=
 =?us-ascii?Q?lg9NrhtI/x9tfIuUVpIGv+fNKgBCSKu1EkBlf9LhkFgDd5d8reXmgOYbLZsv?=
 =?us-ascii?Q?4KZvIaDtNn9GoZKP+xjPuoGN6RgvGgxoqnqFYzhc4ugKFK/kAbD75SRggKur?=
 =?us-ascii?Q?OhWB+Mw/5baYFZu6C8ZS7SbGG+418WHf7DaSCs3vt55Dz4wnJ+V2J7a4P6DN?=
 =?us-ascii?Q?vYUC6i7c9PxSRabFnepE0Ei4DvFOSC4cboV4BRIyshGrjjhOJFZiFdVLD9DL?=
 =?us-ascii?Q?RuXTZwMfhU6frs5rDysR9I1+JtuInrqlfNS93dCnm16lc9UHs1PbYnWkty7a?=
 =?us-ascii?Q?SBPRPNdFntYrY+rUHjlKxybvHueLOpF7NLuVjMYKPgM8qzwyeZ2rrPQc2xk3?=
 =?us-ascii?Q?Xvt1HKXzwBaYOlNk4t9s1V9dyPPa1oaoFi8ZGqIdrNwVBOeJlu6oQzXqq9hG?=
 =?us-ascii?Q?UD0/pg1i6/1f40aMbXHzkDm4DSb8ooIj/3xj9bGLBCAnauLahr4zSLDgmvDv?=
 =?us-ascii?Q?sIgjsUl6/VM6DxQNAaU4nkfLzG2ETpVCTINTy/Ldkm+fyjL1FfFlIdeTEqR5?=
 =?us-ascii?Q?ivyIKp0qyQ4s2TR5y8YsfLU5axJPCOEbevznNw0Ke0b3FQD3/6fFOD8NO4Id?=
 =?us-ascii?Q?5I5vI3klOrKRbCgXQmQO5PypKnS4SUpCE7oNl1o3W1PPfGUtGinuTNmYXEVH?=
 =?us-ascii?Q?n2U7RFIYtQogbIwA/1fLD+Pe29t/M7gp7uNRosnZFSu2jNCt0jzEq45943W1?=
 =?us-ascii?Q?VimtVcTw2Lnz5YvWmS/eo+8UgeBHieR7MOMMMIHRv+foLZ6hfWe09LCeCquM?=
 =?us-ascii?Q?seOZZ21WiU13w3JgAPuC2OZcEOQ9v2k8QH0uhl+5bbuYF5Tw03cZqLqZ9Kq1?=
 =?us-ascii?Q?wei2Pg2x6mTpZSM9w5LKVYSXqX6T/rDtSrCO2GpITbqkyrjMiwhU5sHI1FCB?=
 =?us-ascii?Q?FgfdGNuwUSRLJshHoShPlbBRRBOrXw13/+XZfJrJczzOjIs2AkE9CouvBx9a?=
 =?us-ascii?Q?ECJ1rWZilUUlBFUBPH5ZFDb6PGdo0VSOpKx2Hh2QqP7SQS33C4Mz7fXqedGd?=
 =?us-ascii?Q?3dicMfsxSdHQcXy70UVmXkBsr79NZPFTRSRfUeLvZdmj/pfscX19rt6Rp9kv?=
 =?us-ascii?Q?SY9xWoYSHMd/R5xnZxsIaGIb/HgrW4dYaGbrFrgnW+i4EkNkn3JIrpQ=3D?=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5088.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cad894da-c921-48de-c9c9-08db6cde0fd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2023 13:48:40.7054
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1LRSiOLBH6VJBHIQ6dtkwzXaV0Ph/wrHsbZK3WB+WZ74zJLW+tmEY6yM617+rLl0pKxUgnAPSohFaDQlt5UrQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7020
X-Proofpoint-GUID: gKj2upY5utBiXmzFXtDpTYFOUq1tz8BM
X-Proofpoint-ORIG-GUID: gKj2upY5utBiXmzFXtDpTYFOUq1tz8BM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-14_08,2023-06-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 phishscore=0
 spamscore=0 impostorscore=0 malwarescore=0 mlxscore=0 adultscore=0
 clxscore=1015 bulkscore=0 suspectscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306140118
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Christian Marangi <ansuelsmth@gmail.com>
Date: Wed, Jun 14, 2023 at 03:16:08

> I'm not following the meaning of leak here. If it's intended as a memory
> leak then dma_conf is correctly freed in the 2 user of __stmmac_open.
>=20
> stmmac_init_phy also doesn't seems to use dma_conf. Am I missing
> something here?
>=20

Sorry, I should have been clearer: It's not leaking the dma_conf per-se but
the contents of it: The DMA descriptors. Since the memcpy() is only done af=
ter
init_phy(); if init_phy() fails, then stmmac will never free up the DMA des=
criptors.

Does it make sense?

Thanks,
Jose