Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2803762rwd; Wed, 14 Jun 2023 07:32:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5E/Lf/fz+VGld5F+Xj1dB2jbLJdXrgrF9MV+aKnbkr4IVQfTsyhDn5jJR8h/RQ5sIQeg/f X-Received: by 2002:a05:6402:8c4:b0:514:90e0:99b7 with SMTP id d4-20020a05640208c400b0051490e099b7mr9560284edz.5.1686753178600; Wed, 14 Jun 2023 07:32:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686753178; cv=none; d=google.com; s=arc-20160816; b=kYG0gFB/t5mtjuN6UMzGoWz21SgXzdjaVNCifLCFNdIdDTOX0FOVXRwY0+QS2Z1cr9 fidmnG8RkrnNIiVBYpffu8uHvZnCI/qHGuEE5DPki4S1mpKIEVBl9Oi0fQGevvCeiNsU aMtZdXqLd9YU6+vS1wnLJKPdquIk9W16Py0wguU5iZnJtIOKQE7N9ddJ5mO4HAqYW8Ny pdsDTjRw0juEPHbigWWDGrs2Fu6Qa6e8xRs0FDkqrm5WtAO3IVfI5tf63Gs/debClBB7 dVHpr/LyT08NpKRBNBWkTla8IkFbd+TtDwJvJ1dhVgWx9KUUyt/kgloxaC3mSfn79kXs CWAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5gEO8JN0SvQz0fKEgbKXpQ4YvK4zoihfwl8LX5zB+88=; b=zd7FfJ3H300BlTq2kaEW7RYvWtpmJnzs5BsT7AHLKfATzu1dtjONfH50Mz3w+qpy1x mTnZxur/kOvSQaoAB2ZPNfdsvntsbmvRRz/N9qfyj4ycKUPn19AWXE4B7iBFuN6hh3/r TKn9WWrLjkl7VF0mVP+3xt3eQil+GHvLuuFjz5hVRTG3E0VlHFyGFTG/+Af5xGnqS5vh MxSIXcTTRP2aqdTEQlL8tepHmNPVM6mHFw0y6+VTE8E/VcwIZ49dVI/AIeY8AV1m/kep AdOLEhh3NmgouMtcYAFRoiodE/jJYUD3AOKPt6cebpZpEhVcGYwSKWl9E+ljDlZcNibT Wykg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dMU49nXf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a9-20020a50e709000000b00516a1f2c89fsi9220477edn.677.2023.06.14.07.32.33; Wed, 14 Jun 2023 07:32:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dMU49nXf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245267AbjFNNwS (ORCPT + 99 others); Wed, 14 Jun 2023 09:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245251AbjFNNwM (ORCPT ); Wed, 14 Jun 2023 09:52:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579142684; Wed, 14 Jun 2023 06:52:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB4D860F06; Wed, 14 Jun 2023 13:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51FC5C433C0; Wed, 14 Jun 2023 13:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686750725; bh=CO5xc8YPPQWPDb40OvDsmBIPZj3o5j1/a0jNwh4QVN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dMU49nXfjD0xUXILvTvlDXF8NMUb2VlD+tfLPuwxXKPYNwvghwaxBU+9u2dFQKFMo XG+fJzMiwNtoO0PTs068LLyp6fKUG1EThsNPAAUJAhH3cSh2dtIxXzlGd88HQv484/ ZAlAl83NY+7EBAOlT+shnVTY6WCtv7JBz6vvP95GR1zrwO/OawUrUrsW1MuGojBZsU ioUn869QlwHx9xsO4FSJtFNrH+83l/Y//XX2lHjKyHDmUnW2nJ8wKCVlv7fkPfS+Te paPKw8aaxdheBAC+5kYRLZAtm7ruqPpKky4hXCGyPIRxJST++sKSPrIR2izAJsgq5m lVIOfM71BDihA== Date: Wed, 14 Jun 2023 14:51:57 +0100 From: Lee Jones To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Laurent Pinchart , stable@vger.kernel.org Subject: Re: [PATCH v3 01/38] backlight/bd6107: Compare against struct fb_info.device Message-ID: <20230614135157.GU3635807@google.com> References: <20230613110953.24176-1-tzimmermann@suse.de> <20230613110953.24176-2-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230613110953.24176-2-tzimmermann@suse.de> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Jun 2023, Thomas Zimmermann wrote: > Struct bd6107_platform_data refers to a platform device within > the Linux device hierarchy. The test in bd6107_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > > v2: > * move renames into separate patch (Javier, Sam, Michael) > > Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: dri-devel@lists.freedesktop.org > Cc: # v3.12+ > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Sam Ravnborg > Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/bd6107.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Can the Backlight patches be applied without the others and visa versa? -- Lee Jones [李琼斯]