Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 15:15:43 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: felix: fix taprio guard band overflow at
 10Mbps with jumbo frames
Message-ID: <ZIm9fw1l/EM0r3Um@corigine.com>
References: <20230613170907.2413559-1-vladimir.oltean@nxp.com>
 <ZIms+0/KDpU9dd3y@corigine.com>
 <20230614121759.riazt6xiskk74h6r@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230614121759.riazt6xiskk74h6r@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GzNaPk96jgzZMeqP2Bm5AUKPzrzMQZTr2pC8/jxP/oUeBn1LVFOFSjv9rDU6?=
 =?us-ascii?Q?xr3K1qB6KvnLbmQeypRBfHbuFlslBgrLIAyDo0wYzQz4NxrVe9dcm3GUU+W0?=
 =?us-ascii?Q?l7Q1EATVkgmz2pxbf1RuK1IgQG67YSDvWLL0qznPTaiWknJc2arXdizcAEX0?=
 =?us-ascii?Q?b2YvkdJd3/CsU3KrZz3o/qKw9flzuBIX7jnGdySnymswM2OaURsve1sHYR0F?=
 =?us-ascii?Q?Jr+Gx4iV05d5NaOStl+TbpKe9RXjvhhdiHl6TqeQ+b3NhBDRRRgv11y2O733?=
 =?us-ascii?Q?4vPd+RW/oCYzDDFkqNOLJ3eUm8wt7Tkic1R8YqLOOGGXbeiKX1B+JHxFOw1y?=
 =?us-ascii?Q?WKM5tphq5zO9NL0bTtjiG/q6cHWDa89oMDCdFwEVnpY8/QzoWGujT6rr71xd?=
 =?us-ascii?Q?Aa59DPRKOSW2/yOZlOltPqxKikv/KQbMEXv9W6Mvwu0+Z8fXcXHvNGyE2u9/?=
 =?us-ascii?Q?VbPwkwRZ15Ogne9S1cv/GiG9k/TZ9EJobyOMrcBsE3ShgluOjLwxeuig1JNm?=
 =?us-ascii?Q?cpOJ5xxSUiDhwBoBVqqni/bAmz8p5P2WXsn5BGutDGtEz9WuPDIx++HWCVkI?=
 =?us-ascii?Q?RgOe13Wk6NI9SlMph/WJ7Ea+Kf4wJw5Yf+OgkPpMMzIjcEYL0ghYT3Odx/jh?=
 =?us-ascii?Q?1WrImgJU3mvqj2R8DRNICHX+iiU/4R9zD7Ulm4pjDGK7mFIhV78EXxK0FUrU?=
 =?us-ascii?Q?70Nky0xWbdXkdo7g8N/5gq1Jk7NFIAVyOeu5YEv6VzF14LR/8yworKw/WWAs?=
 =?us-ascii?Q?G5mI9uMRhSIGN/QchD+8tLvupIXGa3/oVihaTaxr7mnKqtcZxXmQp8q60THP?=
 =?us-ascii?Q?OI95EwSpj5NZyBuSJxo24679BfXCyw1Da88it+/f4yrFsWKrjkfXlzd7Si+I?=
 =?us-ascii?Q?g08dLHxDezOveIVolBOCogUwCw+7/0/3VBxlBewhOPWJoURXpdc/UU9+0pBb?=
 =?us-ascii?Q?THoHWyy0AYYd3CCKhKSSxSDGPoqX9H56jFXhA8fB5UVTASB3q9lUNTMQzb/k?=
 =?us-ascii?Q?P/zRnkU/Ehfb0IHKX99eG+4hKcvG3whlfK1Onw8Q/2DHx/qnRyFrea+vSRk7?=
 =?us-ascii?Q?Qwcx7hm/vvk4EgwpNUFhFHyjZJJeaVnyR0iLTLFQajT9mP6nnP31Jh86tVIO?=
 =?us-ascii?Q?bkgJHTpIWZBHBb5zzFnFsGgbJHvMpy+lrMR7DKPZU6ONYwcJnpXtqhfwbM98?=
 =?us-ascii?Q?ykW1KpKj5ntgKaHHEsqU9I6WmFwSqUhXx6vYo0FKL8TgqqeLMBcqA1unHYJ1?=
 =?us-ascii?Q?A0v4GVatPn9mLPWqxGaqup6Ec2d44XC0di8jXc4XIISqsIiLceT32OH6ojT0?=
 =?us-ascii?Q?wq1yY3vTm0eM0RUv7Xo3/I1zlWVR25UpdvWNukCWQMVtOOVrm496CJCg5GoU?=
 =?us-ascii?Q?wmzHNqReUuAC4Y1Lgf6Z5vcXSJrUwmkkBRFK1k1w/Om0OmrM79LWz6/Pzw4u?=
 =?us-ascii?Q?Ft8pYY/2NNGDw3UgClLKtB8/FmOTJpkIfwGB5kOx5CWcvm/+dotVRwTpduNe?=
 =?us-ascii?Q?AHUkXwt3eiu2qmtxnafMwAyb1s/f3Csepc+Pf1UTrmtmghL4DmMDHvi7n8v+?=
 =?us-ascii?Q?tLsbYoNBX1ynsBeymQ7atbZ1hw8Fbv4Ahf5+liKTUKfLFNwABDeTYCOVyXAi?=
 =?us-ascii?Q?E1224MYKUc8ak1h9CBN0o9fBMBhKThZ4Yi6DmzdV5GJuFyR/Jo3es+CvBQ+f?=
 =?us-ascii?Q?kcM85Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb296a1-aeaa-446a-a7aa-08db6cd9796d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 13:15:50.5075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bU/NEMeGBBTIcfFuQZ25nUTsZN3GYjYVszHY/bmN6Tm7mW1NvsE+ouH5SUkrgrnnV/s8oTWseUp/rBU/qk96IaIvUvqGxQ1T1kFSBTubhPo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB4565
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 14, 2023 at 03:17:59PM +0300, Vladimir Oltean wrote:
> On Wed, Jun 14, 2023 at 02:05:15PM +0200, Simon Horman wrote:
> > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> 
> Thanks.
> 
> > In a similar vein, you may want to consider the following suggestion from
> > Coccinelle.
> > 
> >   .../felix_vsc9959.c:1382:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
> >
> 
> Yeah, but there, there's an earlier restriction for cycle_time to never
> exceed NSEC_PER_SEC (1000000000L) which fits on 32 bits.

Thanks, understood.

> Nonetheless, it is a good reminder that there are too many disjoint
> places in the kernel already that open-code the logic to advance a
> taprio base time. It would indeed be good to consolidate all of those
> into a static inline function offered by include/net/pkt_sched.h, which
> is also warning-free.

Yes, that would be nice, now that you mention it.