Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614141338.3480029-1-senozhatsky@chromium.org>
In-Reply-To: <20230614141338.3480029-1-senozhatsky@chromium.org>
From:   Brian Geffon <bgeffon@google.com>
Date:   Wed, 14 Jun 2023 10:16:03 -0400
Message-ID: <CADyq12xoEKpYOd7nFy+ET89ss-zTdKbbj6870UMDQeLe09=Zow@mail.gmail.com>
Subject: Re: [PATCH] zram: further limit recompression threshold
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Minchan Kim <minchan@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks Sergey

On Wed, Jun 14, 2023 at 10:13=E2=80=AFAM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> Recompression threshold should be below huge-size-class
> watermark.

Acked-by: Brian Geffon <bgeffon@google.com>

>
> Suggested-by: Brian Geffon <bgeffon@google.com>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.=
c
> index 1867f378b319..5676e6dd5b16 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev,
>                 }
>         }
>
> -       if (threshold >=3D PAGE_SIZE)
> +       if (threshold >=3D huge_class_size)
>                 return -EINVAL;
>
>         down_read(&zram->init_lock);
> --
> 2.41.0.162.gfafddb0af9-goog
>