Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b12a94a-e3e9-e2a2-389e-48a588d5ad6b@meta.com>
Date:   Wed, 14 Jun 2023 07:08:46 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH] selftests/bpf: Fix the address is NULL
To:     wuyonggang001@208suo.com, andrii@kernel.org, shuah@kernel.org
Cc:     bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230614073443.4894-1-zhanglibing@cdjrlc.com>
 <7f34bd3ce377d9d89626c2df8fa584e0@208suo.com>
Content-Language: en-US
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <7f34bd3ce377d9d89626c2df8fa584e0@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2xEcW9KMXBjNnZuaWhOMVRoWFh2dld0bllzNmMzWWJjTytrQml0ajN2Z2k2?=
 =?utf-8?B?RVpVTklCUm5ublladWk1cG1CU1hEcklUMndyN2dTdkZPTmk1MmlQMExNaG9x?=
 =?utf-8?B?MmwrQXliM1ZmVm5GdkVtS1l5SGY1Ykp3L1BQaVNoOTIzeC9sVmplY045M2Uv?=
 =?utf-8?B?a21jY1MybGdnN0lwb2VpVmtOelVRbStycWdlcGNHa3NHc2dLZjdCMTk2SmFj?=
 =?utf-8?B?UDJxQU5EYTFkUGRsWkh6dkI0UGtZZnViODR6UDNxT3N0RHlUaFhVOXA2d1dz?=
 =?utf-8?B?UlBKa3p5NTRTYWpXNG5VY2pkMERCK2FHS1Roc0dLQi9wS2owdWFkTXExSm5w?=
 =?utf-8?B?TytmeWxBa0xNRGsxUVlBZi84YW5IUm1nMjhDKzNlNEN0eTlQZmJvOWx1alk1?=
 =?utf-8?B?OG95Q2dmNE0wV1JEcVdlME8zZ2llQ3Z6N25LTjhFTGc5ZTZEWVdWRlBtc0Vk?=
 =?utf-8?B?d0FCdjEySllxR25UWmFCc0p3UVFzRVNOWXFuWGhKMmxGS1hBRUIvRG8rZlYv?=
 =?utf-8?B?dlVwdiszMmRyWTN6dFZuV2k1M1pzY0trS3owRUdPSFg2VWpEM1cyaTRkYzBH?=
 =?utf-8?B?SkJtdEdlQ2FjdDJMUHFtQ1grVlBOejNaN2NhaFI4UzJXYWZYMGxsUDlQcEQw?=
 =?utf-8?B?OGpkdEV4dkh3VllXWkpHa1kvdkQ2NUlYYmtZSjlBK2YwbDFBZ1BhTDdHZ2hn?=
 =?utf-8?B?RUxTMDhDQ0JNTkthZnMyTFBhM3hOS1RxQUJCa0JKbVUyN2xZVVp4bGJIL0l0?=
 =?utf-8?B?UGEzMG9RK3YrUHJhNHFsTE1wYlIvamtMNmJMcHgvL3UxMzhpejlrc3FDMFpo?=
 =?utf-8?B?ektPYjZyV1FQNGZjQlR2NDNrb0VCT3NSeVB2K1pxS2dMZHdTMjkyQVQ1T2di?=
 =?utf-8?B?dlBacEhWSk5BTTl2dHd6UUZ2RXZ3eVNYMnhlOUlBbTBmNXVuY2xveTNUN2Qv?=
 =?utf-8?B?MG5Vd3cxdTBqaG83TVdybDgxUFhoa1M5OGhCdlA5NlFjcE1uQ1ZmTHhTbEQw?=
 =?utf-8?B?L0djMjlQdktaZmtzQmpMK0pTWnNrRlg0bWNOQmd1SXdwMGZzRHRQOGFLNmxr?=
 =?utf-8?B?M253Q1VLVXlyMmtMN0FEc3M1T0pYRUJMemxmWFNYVkEyUFV3bGxWNExVRUlB?=
 =?utf-8?B?dXY1QTZnMDMybjE2RFRMY0I2cFltZUNjNmRKOHVCWXdneGhFWGZsTHlGRmlt?=
 =?utf-8?B?UDdXeU5aNmRCU1kvTmVGUC9CU3dDNzN2OEJ4NEJZWEE0aSt0NGhUbENtUFd5?=
 =?utf-8?B?VHdiWHg3UTdHTTB0U1pJdjVqSU1TTVl1VW1qQWJJTGViRkZ0bUpPanV2a1U2?=
 =?utf-8?B?OWN5a0dZbnNhTHd0NUNUL3h3eHhDdGpGSHNudS9teGo0OHBHRVBPOTI0dGxj?=
 =?utf-8?B?dEEyc2EycW03T2dBeEUvWGZsLzJpU24wV2piNjl0VjIvZTFzZFpNY2w0dEt5?=
 =?utf-8?B?SHluaThTK0kzdm5sSUV0dTc3UG5mNGFQV2FkOWp2QkdIZnNvMy82amZZNStu?=
 =?utf-8?B?eXZIU2JuYWxXYVVkckRIZzNCT0xhbmY4ZURkNjc0RmpYSXl0NlZlMUZZM3Vh?=
 =?utf-8?B?SXo0ckoxUHB4L3NtQzc5RFl3MUc5eU9LTlNuM01WTDVOaCs2UW9SaUZ4Tm9o?=
 =?utf-8?B?KzVtY1o0V0dIRVFsOFZuL3ZRaW0vNzR1V2x0WXhRZlBvaGtJbVdreFlUdno3?=
 =?utf-8?B?eG5IZEJQYzFpMFVNdjA3elp6Sm9JUmFFSldwRE8xd29WZm5VVjMxQnRHdjBn?=
 =?utf-8?B?TG5QVVNKbm1sMjZWSi9XNUthM1lNeTFaV2gzeHdRbi80RldMMlBBQW4wbUc2?=
 =?utf-8?B?RTFKejhyTXJkRGR4SGhncU4yUGVseHJjOUt1cm4zUlJJOGZDaXVabEU4dlM2?=
 =?utf-8?B?OGtROFdEMVc2L0cwSW84WjBOS1RLZEVmejZtYWgwL3pla29oMC9TQnVBQkJx?=
 =?utf-8?B?QVBWSmx3Q3dtbEo2YUNleGNoclpiUDRTOUw0d3pvcnFLMWRlTU5ydDBQYm9Z?=
 =?utf-8?B?WGVlT1FZRVhNTk9QNU1HSjdHb014N0I2bkxwcUY4SUY2bm9uNmRHZ1FZVFFX?=
 =?utf-8?B?ZTU3S1hIdDV2ZXBhZDRDcTdEVVJNTjJzYzQ2WXZ5cXpNdENzVWVIbUlQdWkr?=
 =?utf-8?B?TkVXMTVlbUJEYUhyYWcwODRjWFFiYmpRUlBIYWhCcXd5QUtYNVo1Vmd0UitM?=
 =?utf-8?B?d2c9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 119a00a5-4105-4a3e-2eda-08db6ce0dff6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 14:08:49.1686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +2Zcs2Frn+Yi49mBFLH9hkeBFEi6CvLraYLTPh1ZbOkZYR7/rsbCqiDXboRTvUZI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR15MB4380
X-Proofpoint-GUID: y7KdZmynskLYtYmCXFknIxCCSR2ulidy
X-Proofpoint-ORIG-GUID: y7KdZmynskLYtYmCXFknIxCCSR2ulidy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-14_10,2023-06-14_01,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/14/23 12:42 AM, wuyonggang001@208suo.com wrote:
> Fix the following coccicheck error:
> 
> tools/testing/selftests/bpf/progs/test_ksyms_weak.c:53:6-20: ERROR: test 
> of a variable/field address

I didn't see clang/gcc compiler warns about this. Maybe need some
additional flags beyond what current selftest/bpf already has
in order to trigger this warning?
If you feel this warning has some merit, could you propose
it to gcc/llvm community?

> 
> Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
> ---
>   tools/testing/selftests/bpf/progs/test_ksyms_weak.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_ksyms_weak.c 
> b/tools/testing/selftests/bpf/progs/test_ksyms_weak.c
> index d00268c91e19..768a4d6ee6f5 100644
> --- a/tools/testing/selftests/bpf/progs/test_ksyms_weak.c
> +++ b/tools/testing/selftests/bpf/progs/test_ksyms_weak.c
> @@ -50,7 +50,7 @@ int pass_handler(const void *ctx)
>       /* tests non-existent symbols. */
>       out__non_existent_typed = (__u64)&bpf_link_fops2;
> 
> -    if (&bpf_link_fops2) /* can't happen */
> +    if (&bpf_link_fops2 != NULL) /* can't happen */
>           out__non_existent_typed = 
> (__u64)bpf_per_cpu_ptr(&bpf_link_fops2, 0);
> 
>       if (!bpf_ksym_exists(bpf_task_acquire))
>