Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 10:55:50 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     baomingtong001@208suo.com
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        kan.liang@linux.intel.com, zhengjun.xing@linux.intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf parse-events: Remove unneeded semicolon
Message-ID: <ZInG5t2brWyKzvhy@kernel.org>
References: <20230614080937.54937-1-luojianhong@cdjrlc.com>
 <2c733a91717eae93119ba2226420fd8f@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2c733a91717eae93119ba2226420fd8f@208suo.com>
Precedence: bulk

Em Wed, Jun 14, 2023 at 04:13:53PM +0800, baomingtong001@208suo.com escreveu:
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon

Was this detected by some tool? Which one?

- Arnaldo
 
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>  tools/perf/util/parse-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
>      if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {
>          assert(perf_pmus__supports_extended_type());
>          attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> -    };
> +    }
> 
>      if (head_config) {
>          if (config_attr(&attr, head_config, parse_state->error,

-- 

- Arnaldo