Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89a67e4d-cada-ff57-f702-d5579ea8b39c@amd.com>
Date:   Wed, 14 Jun 2023 11:21:46 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: set variable gpu_node_map
 storage-class-specifier to static
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, bp@alien8.de, tony.luck@intel.com,
        james.morse@arm.com, mchehab@kernel.org, rric@kernel.org
References: <20230610210930.174074-1-trix@redhat.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20230610210930.174074-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWtIVW5xM240Ry9oZENOZzhzc1hFK2dGSGVDZWV2WXQvUXZodC9UWURUazVJ?=
 =?utf-8?B?SGlaWEc2T25BK3FXOHR4RnpmUE5pdTZQNHdOeXI2anFaSkw3dUFpMVcxOHRE?=
 =?utf-8?B?allyeUxGRHVqUEx3VFpkQ0ZBSTNsb3UxaVlRbUpIV1I3a3FQQWVPaFJoVmFM?=
 =?utf-8?B?VlFDdkRuVTZNWk5ZbzVpeEdFSEtwQURKK1kzRHppUCtzbkRlN2F5VUMzVlJE?=
 =?utf-8?B?dHpGSkdXeHArRk1DTmd1Zm4vQzRxT21oOGVFbGJnbE13ZXJlTkszVzZZUXBI?=
 =?utf-8?B?V1QyL2x5Q0xMNWpQMjhEdmJDKzhvWHhBUURIN2VlRWtVM0pjSGxiVkVHb3Mv?=
 =?utf-8?B?QWlaVTc1R2lhSUZCcUxqSkFuTEFIQlI3eVhFMCtpOUJPSVlmcXhZbnZzQXBy?=
 =?utf-8?B?VkFZSXFTOUU2ZENFM2l3eWRhWk5Famttci9kV0xYWHFFRUxJS1hHOXdJcVRF?=
 =?utf-8?B?U21LNUNaa0RXNTV0YytRTlZlT3FVTHlybTFGMEx3YTZENHBLL1IyWmI3SlZW?=
 =?utf-8?B?YW1BT2ZFZW5TdXFxQ1IwcVZHRXJJcTl0YXQzRk9aSHE3VGxIbnQvajAraldW?=
 =?utf-8?B?NmtVRC95c1VDSVkrTUNROG9jVXpZSk5IUnM4c0d3TmFvWGRpM1RKbndrWnha?=
 =?utf-8?B?RTBrVHRidDlqV3pzS1grT1owWHlqS3R6c0tQSUtlUlBUbU1YWlErZlUwNWUx?=
 =?utf-8?B?QjJIOHZ2V1U4WnhONm9xRjRSaWk1djA4SGptc0lHdDh6R2NTUVdjaUMxcEdk?=
 =?utf-8?B?S3l3Nmh6SFlGMnE5TG04WFJpaDlacXpPa2NzK2xXLzlkQjhFZEYyWmI3d1Y0?=
 =?utf-8?B?anZybzVIMFUrYVJRTndyd1lOcjNwWGZzc1NMNVZYNG5kakZuOElJSmp2RklU?=
 =?utf-8?B?Q2E2WWtKaStEdFJKVEhJS1FBNHRTRW1wMjNsTGxURU4rV1E2bThJWHBrQ2Rk?=
 =?utf-8?B?bHZ2azlPRzl6Z1FwQzhaeFU2bXVFTzVCcU54RGM0djlLbjlXZWpsekR1eEdQ?=
 =?utf-8?B?cUUrVm9UMGphdHJoSkxoZk04U2lkaWlicUFudXg4MzVsTzRWL3pIWWdTZHdj?=
 =?utf-8?B?U3F2ZlR1MngxQW90Nno3TzJhZ2hUNm5NbkR5UTZLUGFad1hkaTVURFQwdGpO?=
 =?utf-8?B?MDdnV2IxNlZKQUVjd0ZmZG9qY2hSSlF2Y0FscjdnZWxTV3BqMmVXc2pnYTc2?=
 =?utf-8?B?cWJHZHF5cE1SWFdNQ2lreDQzSnNZdE9JVWUwK3R6RU92dHNuaHM1U0dsNDdt?=
 =?utf-8?B?Y3JvWVp4ZFZqZExUc2NycFRSa1VHNGNpNFUvd0lIcG5UaGZpTXJRaTlEV3Zv?=
 =?utf-8?B?QjVWQWdhWUhjcUpsMWc4U2JTL2U3Znl4aUFSWUc4VmVhdHRnS3BKM2l6bk9m?=
 =?utf-8?B?eXNjRjV6WUpUNGxHNTZyYUFMSHdwMnFIdnV6djJ0bEZHZk9iM0xnenhqdW4y?=
 =?utf-8?B?cFNiczZuQmprUXZvL1VRbmRyNGFtZysyMEpacHIwTEZPellrVkJIU3h3cU92?=
 =?utf-8?B?VDlhaUgzb3hXK1NrUVMyL1NQT1VmTFd6dVRzQUdKUytReG52ZVdCWHNZMytL?=
 =?utf-8?B?empTWXc2SmVuWFBZV2ZScjJUdStMTmNrZWowd3I1VGFvc1o2M0dzaDZXUm9P?=
 =?utf-8?B?WTNrZUlyTEU2SDlRRTFiV1FkMiswK25XdDkyRHV2OHd6Z0hkZUk2QWYrZ2hT?=
 =?utf-8?B?ODJ1N2FKTWErTks0Q09tbis4U2R2YzlVRmhORjVWRFJSVHJuOXFNMVRTSlpy?=
 =?utf-8?B?OG1JRUdIbjU2QjVNeUZqUEZ1eE5QMHJyaVpBeTVkcWRQT2wvbE9rTWpPMkRr?=
 =?utf-8?B?aEFXLzU3THp2TzlmZENoYW1MOHcrQjlMWDEwUEthRjNXTEtTUHVFa2R4bCtP?=
 =?utf-8?B?cG1FOXBRZVV6c1FRaWRMVlBWVzJEcnA5RnNNbWZjVzdSUjZTYkc5UGV0U0tz?=
 =?utf-8?B?SlBDTHkwWEFqYlpqSWhrWDIzMW5HaExtTmlxLzF5UW5mS0QvUkFLVFVXdjJs?=
 =?utf-8?B?d0lXbi9KdUd1anhXWmpIbnFlOHR0eE1wek1BMGNXVmhDQnlwQjMycndVNEtv?=
 =?utf-8?B?YjVlQktHTmIxMFpqWmdFa2xBNHFOS3JycnY5RVhpL054VEdkR2xNV1lQc2Vm?=
 =?utf-8?Q?DSwaKah/t9g52768HtFW955Mw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64309065-ea92-4b62-2179-08db6ceb1354
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 15:21:50.2692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xTTr5fFg9h4z6s3qxxNUvGtBNrsMY1ksL4zj4bqLLjo6FEpdZbBm7cowovR8qPL8AaEVJONzpUPII9FDeSzFeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7477
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/10/2023 5:09 PM, Tom Rix wrote:
> smatch reports
> drivers/edac/amd64_edac.c:990:3: warning: symbol
>    'gpu_node_map' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 

Hi Tom,

Please use "imperative mood" when describing the change.

"This variable is only used in its defining file, so add the 'static' 
keyword to it."

or

"Make gpu_node_map static, since it's only used in its defining file."

Also, would a Fixes tag be appropriate?

Otherwise, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen