Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp13013rwd; Wed, 14 Jun 2023 11:27:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6h4Jv7HJiqnp8i8q8PIGIL3UcwL60fnwZ4DDJ+fTt0EyLp4CeLfefI3KAGRbLONoYznD/H X-Received: by 2002:a05:6512:44b:b0:4f2:6817:2379 with SMTP id y11-20020a056512044b00b004f268172379mr7668287lfk.23.1686767245976; Wed, 14 Jun 2023 11:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686767245; cv=none; d=google.com; s=arc-20160816; b=hzLPvq1ghRnZB0QZ6FMvBu+enfTvCwlp689G0cVXgpEqixE7zPoaCprxSI2W3So4jA o12VSxPaUyaNAZnOkWTZBGIM++2xr3GJvFJu5cKVdyf2rskgzAPICCcbSUHLRCiJe/lm Ep+SXMZHCugn1+qiGPk4AptVpmTJl+LRQUwf/uie9u+SkYN6+C5D/JzF4nRCyw0bWJg+ 0G4TGo7qRRP3m4XFP0iO4ksdTJKQ5w82arxcZsQTBTdrzV6Nr1agvZvZXJubTA+WqWZ+ ZVqmkrn4uCxP8mR0di6BITBwe19/T7BZmvlKEJ7eJmPPupb/NGxR/bhv1vrMu/IsubsO j+0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=cx3ww42b/GUADmPxgecUruglRuTodYTFhWxxp7Qxcss=; b=tGETbsqp/HADchxynRNpT5nPjiFE+zGIIdSQZn3Oc3rTIEc7+MuRexMmzBRIbL2FOj NtHZ0dbzX0FtN5NevvOjjiyQ6lZh8as4AhUvs0KCewE4QpRWcUihLAPIbj4AF3aHfmKb WMXCeMJeZHB5syEECqoah/KRbuGuyUHmeYNCxI2o2b96z9v3TxmXsvFuIF4xNAvjW8Pk efbeAoC+Q0uiDNfFVdZrOLnXstUd8SPeEFPz+FtGmtdI38DsLz2jbi7C35Im+zU88vFw 5BxFEMJW4dq4DF6McHViCUxUvwTJhFSHXWrKoC1bl19tL7zPSWYU7AElBGABnW20+tnZ +hFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Kiva6gK7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f24-20020a170906139800b0094fa38de124si5476236ejc.133.2023.06.14.11.26.38; Wed, 14 Jun 2023 11:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Kiva6gK7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241100AbjFNSLT (ORCPT + 99 others); Wed, 14 Jun 2023 14:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236438AbjFNSKv (ORCPT ); Wed, 14 Jun 2023 14:10:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4111530D1 for ; Wed, 14 Jun 2023 11:10:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A34C76458F for ; Wed, 14 Jun 2023 18:09:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF487C433C8; Wed, 14 Jun 2023 18:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686766164; bh=+nxesi73rHt30BcL4CzJywspddkR9ibaByigPS/fPBc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kiva6gK7MHUYL0CxOWup6G0c1iUNZxcgNyRtbLccepIEW9XIsERqtTwtmhufzdk8D tL1fJjZqqtgVCYCr03ofsn/4dYBh7I9kARA8qLfI8/SNX311/bI06DIe663INP1v6J fdqtvJ7J/3R8p6TS5f/0JQkeEl68nnuADOkb8EaM= Date: Wed, 14 Jun 2023 11:09:23 -0700 From: Andrew Morton To: hexingwei001@208suo.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_io: Prefer 'unsigned int' to bare use of 'unsigned' Message-Id: <20230614110923.b5ac015ac6e9a2d97f3b40c3@linux-foundation.org> In-Reply-To: <1e132a6416d673e285af610ff185fa5f@208suo.com> References: <20230614071804.13110-1-panzhiai@cdjrlc.com> <1e132a6416d673e285af610ff185fa5f@208suo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jun 2023 15:23:44 +0800 hexingwei001@208suo.com wrote: > Fix the following checkpatch warning: > > mm/page_io.c:87: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > mm/page_io.c:89: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > mm/page_io.c:109: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. I'm counting 55 of these in mm/*.c. If we're going to do this then it wouild be better to do all at once, plus the header files. I don't believe that is worth the churn.