Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a1d8002f7e2982399cb8ab7641f54ac867270aa.camel@physik.fu-berlin.de>
Subject: Re: [PATCH] sh: Replace all non-returning strlcpy with strscpy
From:   John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To:     Kees Cook <keescook@chromium.org>, ysato@users.sourceforge.jp,
        azeemshaikh38@gmail.com, dalias@libc.org
Cc:     linux-kernel@vger.kernel.org, rdunlap@infradead.org,
        linux-sh@vger.kernel.org, linux-hardening@vger.kernel.org
Date:   Wed, 14 Jun 2023 20:49:13 +0200
In-Reply-To: <168676826702.1963449.9061022814058323294.b4-ty@chromium.org>
References: <20230530163041.985456-1-azeemshaikh38@gmail.com>
         <168676826702.1963449.9061022814058323294.b4-ty@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.3 
MIME-Version: 1.0
Precedence: bulk

Hi Kees!

On Wed, 2023-06-14 at 11:44 -0700, Kees Cook wrote:
> On Tue, 30 May 2023 16:30:41 +0000, Azeem Shaikh wrote:
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> > No return values were used, so direct replacement is safe.
> > 
> > [...]
> 
> Build tested with sh4 GCC 13.1 from:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/
> 
> with defconfig and:
> 	CONFIG_CPU_SUBTYPE_SH7343=y
> 	CONFIG_SH_DMA=y
> 	CONFIG_SH_DMA_API=y
> 
> Applied to for-next/hardening, thanks!
> 
> [1/1] sh: Replace all non-returning strlcpy with strscpy
>       https://git.kernel.org/kees/c/ca64da3052be
> 

Apologies, this fell off my table. I should have acked and tested this being the
SuperH maintainer. If you can still update the patch in your tree, I can both
test and ack this patch.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913