Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp70902rwd; Wed, 14 Jun 2023 12:21:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46UqKlqsZAFYeLMxE35+3oMtmRZRS3M6SwLhp5kNIKB6xE9cX/ozHpAnEJ/iwrTF8lmwWY X-Received: by 2002:a05:6a20:5492:b0:10c:41a6:ac1f with SMTP id i18-20020a056a20549200b0010c41a6ac1fmr2724506pzk.16.1686770474598; Wed, 14 Jun 2023 12:21:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686770474; cv=none; d=google.com; s=arc-20160816; b=A3IvVDxDRy+0Nu+jKI57KCriYlbTBwIr6fN+NeCjWrUsMKszSpz//8LzU2tdnFVC17 PaeGyCk4ZRmaxSZKeXnsdIkgpb4+iPasgwjGZclH5E14tg0kLkhLtqA9TdR/gMIzjpg2 6TfV1ulxt3AO3/q1CRdCIyYsravtCxemX3wmY5llkV6adlhWdE4Hd0S6Jpf3UvcYsC/I VPuwAN5c5rQRZ0l27ryE/kDWicTlpGuXdiE9teGjJWAAZ7OAIQG3/UBCqCHMt1tc9uqA xhmNuXv25l3vEooHsvuERp66GSj8iG7gjdwBqWBvZdCa3PeQ8YwiSiGQUwxRuA2K/3/3 omKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3YCZowOEZlyDvPFb00vEd70o77BSACcS6VLpIzsJZfs=; b=GWx51OOeK06pLwho8XZwueQun+67rRDKdJP/Xq29tVFDIrS3WLGl4ua/bLNgIZD95U gmUJhQLYMMmevXFUmwZJGq2QA6BJIBxl6qUgqoVF16uh6T0GC2+7H/G9y1QZzjY91w+n dQ+5+MxQIvJbrAheNsnPEs3kJMdhA40TGF8JatgIlvuGZUmX/xSYdPWmvJ5XEj77WOq+ gWauf0IEL0z8lQFJmOHgxCa6nV3KZ/Ai5Q0xV+c2+iQaBgZ8Z1ZIlUKlZCF6WheqSCUH FVgo0r2YQ6rEEY2pNbfpwLrj10jd1c9/ycHLpT5z5v2gPDGOPpKBGjwC4qlG+SnA85cW vnYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UL1esWWe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v135-20020a63618d000000b0054f9e5e7238si5320112pgb.654.2023.06.14.12.21.02; Wed, 14 Jun 2023 12:21:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UL1esWWe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233699AbjFNTCh (ORCPT + 99 others); Wed, 14 Jun 2023 15:02:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233681AbjFNTC3 (ORCPT ); Wed, 14 Jun 2023 15:02:29 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3651FC7 for ; Wed, 14 Jun 2023 12:02:28 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b512309d18so2352975ad.3 for ; Wed, 14 Jun 2023 12:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686769348; x=1689361348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3YCZowOEZlyDvPFb00vEd70o77BSACcS6VLpIzsJZfs=; b=UL1esWWehBszKXIe8ACxXGNCnSPB/ARM1o1PbG0kVkV4nemWgox+TZaJYs9cpXwBEG 0h98gqsB4/z9r4Nw7DjfLdCbyHyqk+L7nxIJn3QAQY99DdH+dOzfYBYK9rBT6k2Bcm8r bYtdfgVnSA3wMgKBWkyV1x2vHFzdRyoIOMt0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686769348; x=1689361348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3YCZowOEZlyDvPFb00vEd70o77BSACcS6VLpIzsJZfs=; b=jJoLUC/l+Xvo3L5JsCODpa9JFonaK9vLawW4BLiTvXFEhUNf/eEGu2Qplv3Mqd7pn4 O5ZcjFnqLunL435Xa77004UVQDWRiKDiJA5RdPo12UidT16AQmsjZjeHom6LQ8xtbT7D re9jPgw8FEOuU+cfxa17zDwpBDH5iI4sm22hzaql3ItkKwjIi3xa2u6hq9fFEMyvILRd e4UXXo8faFFmJ/87FiWbDXhTYtOrlFEoI4ngichmaM8G/o6ocV42ww6VRzVUxRW0t3PM AuhsEk08KywdFiyWFDa3cMCK29b0FtSfIyms/gNJAWAtOGKF36Pfn99/7RDkxGK1Ld3a X6zg== X-Gm-Message-State: AC+VfDxcMePZ1w0t1QVTVIkOm/0OAtRXSXP3cYo0zL+eWMSidElRHStK CELFUl72euphmQHQ9R+qiCss6Q== X-Received: by 2002:a17:902:900b:b0:1b1:787d:1e47 with SMTP id a11-20020a170902900b00b001b1787d1e47mr10405803plp.41.1686769347821; Wed, 14 Jun 2023 12:02:27 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id q17-20020a170902bd9100b001a6dc4f4a8csm6080516pls.73.2023.06.14.12.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 12:02:26 -0700 (PDT) From: Kees Cook To: Tony Luck , gpiccoli@igalia.com, jiasheng@iscas.ac.cn Cc: Kees Cook , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pstore/ram: Add check for kstrdup Date: Wed, 14 Jun 2023 12:02:22 -0700 Message-Id: <168676933413.1964902.10975046622666156359.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230614093733.36048-1-jiasheng@iscas.ac.cn> References: <20230614093733.36048-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jun 2023 17:37:33 +0800, Jiasheng Jiang wrote: > Add check for the return value of kstrdup() and return the error > if it fails in order to avoid NULL pointer dereference. > > Applied to for-next/pstore, thanks! [1/1] pstore/ram: Add check for kstrdup https://git.kernel.org/kees/c/d97038d5ec20 -- Kees Cook