Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 21:17:30 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Jose Abreu <Jose.Abreu@synopsys.com>, stable@vger.kernel.org
Subject: Re: [net PATCH v2] net: ethernet: stmicro: stmmac: fix possible
 memory leak in __stmmac_open
Message-ID: <ZIoSSgNr2qus5Ok9@corigine.com>
References: <20230614091714.15912-1-ansuelsmth@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230614091714.15912-1-ansuelsmth@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J7+TYQZMcKYgp1+aiRUoDEWP/B0oUFJ9REUF9gKD9EqA1wcxQfo7fcjKleY/?=
 =?us-ascii?Q?uoT1NTfwmU2x0nyrUbZyujKMD6ZPkXIXdR4Zkq8S3i0bGqu2qYVObaEEdewL?=
 =?us-ascii?Q?H88ir2vO2uZtRhsc0LSyugtzuhjgoneAct3Nus6HVygY6wexrwclQmf9Nv+q?=
 =?us-ascii?Q?W0B0DtI8jD70ILHwxFl1Ec1zjtV8IZBS+u+HiRIUxV5AEMTJTcYaUx9Ve4bt?=
 =?us-ascii?Q?K+bPRHhXDD93l73bO1FLgk8PxgcV0NEs0MKhfAUrtbjdIm+1vd7zjIAPs6Jl?=
 =?us-ascii?Q?fl1/TFJiBcPLUemT5fSb5ITp0Hx5cMlEaYB5y4N0Pnln7/nhZO2W0z+Z1Lj2?=
 =?us-ascii?Q?lDo6gaXKMOFlv0oNA/kKbYhI5cWMy5wW2OcCdnxL7kN40LGYT5a2iIxAG1+f?=
 =?us-ascii?Q?iLXA4CH0+E0kfbk2LwLEx9INie9S5M32XYSpzrLWtTqJiJ4Rb70NBYGR4+M7?=
 =?us-ascii?Q?qZN6ijJ/OzokeUANww5WfhJ0XY1NeJ6mMfV588mqC3yX6fxHB+0Ynk+CIkeT?=
 =?us-ascii?Q?KFez1TamhKSE/cBF96ycR/EYm7ZvgWt1ptiO1CFvROUh0bauOSJRNoln/FH7?=
 =?us-ascii?Q?A62fs7JnMNGO9APseYLZozvPJ4J9t2M0rC8szJc/3hcPtwPCQ3g9400MeM48?=
 =?us-ascii?Q?FyNMdBm0QGz5LpXQfVDH9BkajxLOuUviwOoz2AbTyqkeuqp68LpQJr3cYV1S?=
 =?us-ascii?Q?9sSwoo8lGPxoudR69Je3UZ+gMSFFEPSAUIUi8u9qpZnilpSaI8OdW3BKcFBH?=
 =?us-ascii?Q?1Lp0uBJpP1hAV29WLQKKcl59BtfDnrQfXwD6feUNC4IyCrpv14pk/smqRIi9?=
 =?us-ascii?Q?7W6p6jwcNsMIAfnrFPeza5Ad10FqUOMpS9TdR5mgxhur84ZdWGVclsOwlnM0?=
 =?us-ascii?Q?+rgMrcQSlCOsho/HRDMHx/8S+94mVOknIMJlcLIw9j7Wef6F2nQiePkvwGVa?=
 =?us-ascii?Q?YLAD9xT5pbyP8kmYoIyTeshaFfGFGJ6/iBOvUPWovTNkNz4qsNVJsJqbm1YT?=
 =?us-ascii?Q?X38UIj3d5Cv8aUru7qJ0xpZL/NM6UOGyCdeILixJJsmw52uDyx/qXzi4RcGm?=
 =?us-ascii?Q?PgaUm+Z+jOLaKHLHgrvxOLQK5Vnlm4c7zwu+9bOgURW6nkp2412wNfta5Jjx?=
 =?us-ascii?Q?2Mn1U6rhrUOCi9P88GxAhlZ9CfvGqgjC1u1zXpnUZQsay/1isK3LiMp2hHKy?=
 =?us-ascii?Q?G2yiuCpaf0URCfmKAM8yLJ7HvXMTSiAiqpSzTuoHZiCO7HB++Ad1yjndBnno?=
 =?us-ascii?Q?zeibfXF4mLzqgFABEPrErdqMn6U0B5HP5p7L7lZaGsoZG/GYo1zYgI1uhd7l?=
 =?us-ascii?Q?YHWDD7PqBdmVbtPUqPeSKcs+HFr3KztMMVkfScZqILNq4Trv+g8tHyxwbi5a?=
 =?us-ascii?Q?3MWzNdqlqxkce6iMCEit4kSfBjuiDBu7oc5/n2oo03pfUE605NjI0DVRxh07?=
 =?us-ascii?Q?lxHY1xFb1fIw00fcERYklfh8oRRDDxl0mZP6TiECePYBfuBg9ypHHJm3gfrQ?=
 =?us-ascii?Q?9WYMAX5kfSvXuc3cU/p9FU2X0RF122dRoZs0USJaVtjerh4ohj+ohnuRUNfJ?=
 =?us-ascii?Q?3yHKMql2s69dJs8Npz5S0VgmiXT3kRM7C6NEoLfwF6U/DqHsy+9rYOQAdyho?=
 =?us-ascii?Q?eXouwh8CdA/TI0e8UlN8OyLWyXKLLR2KTt+nHFpsGKkE0oHNEk5swheFbwIN?=
 =?us-ascii?Q?6DOuGg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc863c04-b0a2-4ebb-0bdc-08db6d0c0354
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 19:17:37.0562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KBYcj5gXgc7nQ1IR+lbB7ztL/emgYFg959xA+UAtA59gCeJVonj72T1yNJRw0EQbuZHByUcx/EROg35STIBIcRIszSdFoEEaFuVNMb0PYGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5627
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 14, 2023 at 11:17:14AM +0200, Christian Marangi wrote:
> Fix a possible memory leak in __stmmac_open when stmmac_init_phy fails.
> It's also needed to free everything allocated by stmmac_setup_dma_desc
> and not just the dma_conf struct.
> 
> Drop free_dma_desc_resources from __stmmac_open and correctly call
> free_dma_desc_resources on each user of __stmmac_open on error.
> 
> Reported-by: Jose Abreu <Jose.Abreu@synopsys.com>
> Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma conf before open")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Cc: stable@vger.kernel.org

Reviewed-by: Simon Horman <simon.horman@corigine.com>