Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 21:39:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jisheng Zhang <jszhang@kernel.org>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 0/3] net: stmmac: fix & improve driver statistics
Message-ID: <ZIoXZQXLTWKF8nCZ@corigine.com>
References: <20230614161847.4071-1-jszhang@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230614161847.4071-1-jszhang@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Y5CitNe9MFPXZ5Mb5ayiBUWJFvSVFL6Vmf3+TV8PmHCKJdHDOLfewAF3eCL?=
 =?us-ascii?Q?dS6BPE/d8FK536jcfR/NXs4u5+Mr+N4T/lwKdlVcFidMkMo+KfWt0cHzSSh9?=
 =?us-ascii?Q?w1kwEBE7pFYPaYV2flj0cUodfAU+U3a9ZrzBW+fRQ+jirZrfN1Z/iJHHjNKA?=
 =?us-ascii?Q?B1y8ECjkspAUihMvzD+fXJmNZa48eONNr+oy99lZfhsAjqTmB+wqZ2A3iF9W?=
 =?us-ascii?Q?fGRMpCsWgcw+/O4rkLnM/169cbpgmYCdqcqnAskGD9DGroGhgDSWnm3no15n?=
 =?us-ascii?Q?rnMCr33ZgRd+Gbz+oObND8UfhBYs1o1gcNYmYKHOEbyOsUFjA+ecIIhunFbl?=
 =?us-ascii?Q?mR9YNQWXgmE1rUOIjI9p4FP2s4mmz/C5deozN+WRN5GbTRAUi5TamW3roOmU?=
 =?us-ascii?Q?qipi98Hlc3A+pEf5+EUteCU9LxH6m8O7TPLz1j+rAft4plJR3Bur12O3+K6m?=
 =?us-ascii?Q?23LwvOZ+hWt75WnKgTFU+XELBuEUxekc3NNUm8SiT65sqScF2m2CUI5Z2uUi?=
 =?us-ascii?Q?w/Opqej+lgGiU3YmTlXA36tU556gZV7gZDWUPwabxzLH3UduurWc+zLvMepI?=
 =?us-ascii?Q?e3Fdm40IIdASMCjPMTd26TQFaS8iDo47wlCepb8v5IwzA6u3m9z+1E85BkAR?=
 =?us-ascii?Q?6hhf3i4vUcR9XjHS4EDjoEqePnhcBKAU7U6CuF69imTf3Skngp3+QA07u3QB?=
 =?us-ascii?Q?NXzbyTpMvZrsnbzbLmC4qCJ0wkErCftAviKDU2/oGb4NtlKqMKm4D6tRSYhV?=
 =?us-ascii?Q?/M28C6mCcJBrYiEMbbWhr9GdXaH0fFhIJE3bnJ+sHfLhLUwPkEn9qzI8KTPN?=
 =?us-ascii?Q?rIVOI7v+ZOJiKNyfWXT/6Yg38RekcFwCXn0zqY20nPnvXoaXHR1vuyZjfk9T?=
 =?us-ascii?Q?Hm2iyvHC1kW63V4tfuhA3t9c6cFa60TI5XYLZbhOGDhXH2puomAb1yleOAKl?=
 =?us-ascii?Q?sYGZQ8X0UKR+A0mXOnzl18miS0dYxJTEB7CE7YRwRchmLrs7SFKEotpkVyUk?=
 =?us-ascii?Q?7ZilFaUKkuGJXInG5Ai8p6BkNzjO0iIOQNvDZdWk4QWF8uHP8TWUYXiH90rc?=
 =?us-ascii?Q?48lpmO9zin6IsqHvPwBxwzdXTDDscih6YdW/gpD68ARP2Uqo7Z4ZMBnonA9a?=
 =?us-ascii?Q?A8O8jIYKDC1EGAI+1SSvwodzKopjkMK41yp5uYbtfKdvKTnwiJyuYTJWWZWJ?=
 =?us-ascii?Q?hJPgVz5EloiFBg25S+iFCqxLh2Ogq20PIaDSyS4uAguqU/aD1KKUy4kqyEOI?=
 =?us-ascii?Q?S+swhoyZOhdE//VCsvGHoJBfBGnq4y7VjS1jgQ6emT9ssd2j+pVbZPuAzj72?=
 =?us-ascii?Q?7jRsT4kUDa0GSPyQ/vg3p7lKXmC5SLxi0zs2wEKuf5XS3rZs++fXKQH3L+oV?=
 =?us-ascii?Q?PmW1kos2gqGxaBHYEP22aCi+7AL66WzAgmb6wDuPoP7UecliRpGCgOXJgNAd?=
 =?us-ascii?Q?kuR2saoBrPgX1ZKO4e8FOSaXPj5E8HIOyE6vUhDQR4NF3bH+qLAqJrT6vPU2?=
 =?us-ascii?Q?k119IDXO31JMA+97Pm92IDDTTmx/Hu2yh0CgB5TAC7hN2n5NNREQXCXv8a+r?=
 =?us-ascii?Q?LXupXJ6kYsS3q4CO3EPfHE3HPvrQbBQj8dTAazWn6Cod5Ibh+eWgSwglJKgq?=
 =?us-ascii?Q?DR2gKuihl+tESV9rf4dSCztv2c7WbtxVIu3yTrwgYhWHazrDJCOtEyNpP60Z?=
 =?us-ascii?Q?rM5ExQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d71390d3-7a86-49a4-6be2-08db6d0f0f67
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 19:39:25.5521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hAhh4OzMwyF981WpkO28KERr+XHJXeoB4DtNPfIW/DOiREh5/fpiDZnW0TJgn5/WWnZZtg9e2RvWy81wqxo59MEunZ6fJkCWN85YScp9s40=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3938
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 15, 2023 at 12:18:44AM +0800, Jisheng Zhang wrote:
> patch1 and patch2 fix two issues in net driver statistics:
> 1. network driver statistics are cleared in .ndo_close() and
> .ndo_open() cycle
> 2. some network driver statistics overflow on 32 bit platforms

I would encourage you to describe these as enhancements or similar,
but not fixes. Because fix implies a bug, such as a crash. And
bugs for fixes are handled by a slightly different process which
often includes backporting.

> patch3 use pcpu statistics where necessary to remove frequent
> cacheline ping pongs.

Assuming these are three enhancements, then they should be
targeted at the net-next tree. And that should be noted in the subject:

	Subject: [PATCH net-next v2] ...

Unfortunately the series does not seem to apply to net-next
in its current form. So it probably needs to be rebased and reposted.

If you do post an updated series, please observe a 24h grace
period between postings, to give reviewers time to do their thing.

Link: https://docs.kernel.org/process/maintainer-netdev.html