Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp121024rwd; Wed, 14 Jun 2023 13:11:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Gy9HspqPgqbDJodjxPHs/yceTz0fh5dnsNDj+Jb3D4E4ede3PKoE4VZiL4YeZsk/iR8BQ X-Received: by 2002:a05:6a00:80c:b0:665:c07b:6b29 with SMTP id m12-20020a056a00080c00b00665c07b6b29mr3644675pfk.15.1686773465733; Wed, 14 Jun 2023 13:11:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686773465; cv=none; d=google.com; s=arc-20160816; b=irpDs2mJxgNMH7yZLBsVc8m4GUQFX4Q3tSbkIwfyjdidMMmoPEzqmG1avgO3/j/KwY qBrtY+M2PvDXcXS9IWV7nWunpKF5HaifF32ldPNhOqglYmEZ8xyr2VciYxahlhRBziX4 JVtAASY1f3QOH7Ik6giUEoPIseHdrpRsDVyhkEfCLz+vbcX8v14yKonGOAj4oj2/Fu+9 Pi8isyfEfTf0OUDA3fn7ZqqQgkJWkc9Z4umIhd3HBmOsg+/9uRwxqmiHFacyqrGktUpS FIM59Y4f9eVFc7WQsWrov+CD7wpTmroy1FPXn2vi6cyXbm9Q/xk1gMOJiAk7ZI8weTEy HVjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=f7uhJT6kLDdqaietSojvYIPqRMHSIOzdA+ustiQ+Cg4=; b=DkwAoUK9VbuGMfrogB76sx5BDuzBXe3lMEqPzHbOgzVED6Btcp2wSuNc8dHoHEncjT IRYcuFFJntJdB6yEiSW6yuGzCWmcXXPnRgMq8I/jo2dOjJ28qxMQyTvRmvGh8Ss7ry8w 6DKbhL3Wx3sMtGMD9N/uhqf+KUZagDpD2Z8NINAuD1esthSurwxID4ZXjACP+EleAfJ0 xsWcrb4EV59cSWXoQTLor5Pz2J7h02eD9CDEg8mbK1rXcssMAXFV0RRjIcuw+7b1WoVl DgMT1qp7UdLkxBHm6ZOK+g1Sz0oX1XeCH+UcHtWSrZLUTr7OLRUNheDO2v7FzGLOJ8Fi 9F/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A1g+XWgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h64-20020a638343000000b0054ff0e193fesi274762pge.225.2023.06.14.13.10.40; Wed, 14 Jun 2023 13:11:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A1g+XWgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235979AbjFNTvK (ORCPT + 99 others); Wed, 14 Jun 2023 15:51:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230301AbjFNTvJ (ORCPT ); Wed, 14 Jun 2023 15:51:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 412F31B2 for ; Wed, 14 Jun 2023 12:51:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6AF461939 for ; Wed, 14 Jun 2023 19:51:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF328C433C0; Wed, 14 Jun 2023 19:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686772266; bh=XixhRXNacZf86/Ab3M9lMGOYV4VdBeeg4pCVwps5JRo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A1g+XWgdsLQsKEltC0MaZo2pukro9VJdv1s3vLg/vWL9lCMspmn0odUrAmldGNBFT GStQLkX7kvz6iUWv9NRRp/ElhFw9Jx1e8PFszG5BQ2xvX6XV63NpIsqaRiOD8FXkeY h7Plogp2/P1gKuI52Ou2MS60jcXxb20f+T+f/ZVqGTHUXRLjEYTZbconRAld9C3rPC Q7bVyFq8sSMfCKP+mJ5E9zpYJk+MEhU75D9xHB+HSBia4rHuYTcIF/sKUxYNSe3KKO U+DRMkDL3FcprsRptdO5hpBJ7rO/p9hihrN/U1zvfKCZ5v66d+Zm2uhmPe25KdebgD NiSCAjfchdFVQ== Date: Wed, 14 Jun 2023 12:51:04 -0700 From: Jakub Kicinski To: Kalesh Anakkur Purayil Cc: Jiasheng Jiang , vburru@marvell.com, aayarekar@marvell.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, sburla@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] octeon_ep: Add missing check for ioremap Message-ID: <20230614125104.0d29b00c@kernel.org> In-Reply-To: References: <20230614032347.32940-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jun 2023 11:33:17 +0530 Kalesh Anakkur Purayil wrote: > > kfree(oct->conf); > > return -1; > > > [Kalesh]: fix to return -ENOMEM instead of -1. The author is not touching the return code, seems unrelated.