Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sohil Mehta <sohil.mehta@intel.com>
To:     x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Sohil Mehta <sohil.mehta@intel.com>
Subject: [PATCH] x86/smpboot: Remove a stray comment about CPU hotplug
Date:   Wed, 14 Jun 2023 20:13:01 +0000
Message-Id: <20230614201301.1308363-1-sohil.mehta@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

This old comment is irrelavant to the logic of disabling interrupts and
could be misleading. Remove it.

Some history - commit 'e1367daf3eed5 ("[PATCH] cpu state clean after hot
remove")' introduced this comment a while back. However, while
refactoring the play_dead code, commit 'a21f5d88c17a ("x86: unify x86_32
and x86_64 play_dead into one function")' missed moving it to the
appropriate location.

Now, hlt_play_dead() resembles the code that the comment was initially
added for, but, it doesn't make sense anymore because an offlined cpu
could also be put into other states such as mwait.

Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
---
 arch/x86/kernel/smpboot.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 352f0ce1ece4..64dd4703c1ff 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1734,9 +1734,6 @@ void play_dead_common(void)
 	/* Ack it */
 	(void)cpu_report_death();
 
-	/*
-	 * With physical CPU hotplug, we should halt the cpu
-	 */
 	local_irq_disable();
 }
 
-- 
2.34.1