Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230613074931.666966-1-anders.roxell@linaro.org> <928ad485-2dc2-2e02-98a2-fa203441f463@nvidia.com>
In-Reply-To: <928ad485-2dc2-2e02-98a2-fa203441f463@nvidia.com>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Wed, 14 Jun 2023 23:16:56 +0200
Message-ID: <CADYN=9KtYe6jo+MDm+3NVwfNFzsOgoRRKxu_hSJeEPMuLRGgeg@mail.gmail.com>
Subject: Re: [PATCH] selftests: lib.mk: fix out-of-tree builds
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     shuah@kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, usama.anjum@collabora.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 14 Jun 2023 at 04:23, John Hubbard <jhubbard@nvidia.com> wrote:
>
> On 6/13/23 00:49, Anders Roxell wrote:
> > Since commit ("selftests: error out if kernel header files are not yet
> > built") got merged, the kselftest build correctly because the
> > KBUILD_OUTPUT isn't set when building out-of-tree and specifying 'O=3D'
> > This is the error message that pops up.
> >
> > make --silent --keep-going --jobs=3D32 O=3D/home/anders/.cache/tuxmake/=
builds/1482/build INSTALL_PATH=3D/home/anders/.cache/tuxmake/builds/1482/bu=
ild/kselftest_install ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- V=3D1=
 CROSS_COMPILE_COMPAT=3Darm-linux-gnueabihf- kselftest-install
> > make[3]: Entering directory '/home/anders/src/kernel/next/tools/testing=
/selftests/alsa'
> >
> > -e  [1;31merror [0m: missing kernel header files.
> > Please run this and try again:
> >
> >      cd /home/anders/src/kernel/next/tools/testing/selftests/../../..
> >      make headers
> >
> > make[3]: Leaving directory '/home/anders/src/kernel/next/tools/testing/=
selftests/alsa'
> > make[3]: *** [../lib.mk:77: kernel_header_files] Error 1
> >
> > Fixing the issue by assigning KBUILD_OUTPUT the same way how its done i=
n
> > kselftest's Makefile. By adding 'KBUILD_OUTPUT :=3D $(O)' 'if $(origin =
O)'
> > is set to 'command line'. This will set the the BUILD dir to
> > KBUILD_OUTPUT/kselftest when doing out-of-tree builds which makes them
> > in its own separete output directory.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> >   tools/testing/selftests/lib.mk | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/l=
ib.mk
> > index b8ea03b9a015..d17854285f2b 100644
> > --- a/tools/testing/selftests/lib.mk
> > +++ b/tools/testing/selftests/lib.mk
> > @@ -44,6 +44,10 @@ endif
> >   selfdir =3D $(realpath $(dir $(filter %/lib.mk,$(MAKEFILE_LIST))))
> >   top_srcdir =3D $(selfdir)/../../..
> >
> > +ifeq ("$(origin O)", "command line")
> > +  KBUILD_OUTPUT :=3D $(O)
> > +endif
> > +
>
> Thanks for fixing this up! This looks correct.
>
> (It's too bad that we have all this duplication between the Makefile
> and lib.mk.)

I agree, also the duplication of get_sys_includes in bpf, hid and net Makef=
ile's
Do you have any idea how we can remove the duplication?

Cheers,
Anders

>
> thanks,
> --
> John Hubbard
> NVIDIA
>
> >   ifneq ($(KBUILD_OUTPUT),)
> >     # Make's built-in functions such as $(abspath ...), $(realpath ...)=
 cannot
> >     # expand a shell special character '~'. We use a somewhat tedious w=
ay here.
>
>