Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stefan Wahren <stefan.wahren@i2se.com>
To:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     Stefan Wahren <stefan.wahren@chargebyte.com>,
        Simon Horman <simon.horman@corigine.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Stefan Wahren <stefan.wahren@i2se.com>
Subject: [PATCH V2 net] net: qca_spi: Avoid high load if QCA7000 is not available
Date:   Wed, 14 Jun 2023 23:06:56 +0200
Message-Id: <20230614210656.6264-1-stefan.wahren@i2se.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
UI-OutboundReport: notjunk:1;M01:P0:JfalXIoL/cE=;KFZvrtSmWNt3/u0HYOPGGwocAa5
 CApBh1ONIAfzahlLOysMw2eclK5c0HSckMkhHZqO23CKDW3saahriVbDpq/xaKmaCMtFCCuaj
 6inrelcrTyWk9JEI0uJbxNGevFSD2hyoXOPcU/l+BxU4BcT4J3xvMKdiNqUCjwmVNMmRgp7A+
 RDK5nqaKvrRaS+NrUtrCR1Ce1Cid0dqVyT7Awd8JjIyxJlhePzlf0D2eea2Kr6f1v+an46owq
 kjjmPs+i4UEgW7wHiOLxGOc1tbvCgIXc3lKg4+mmMrqYw4zyhPsLG5Njt4Yq27U7IfMPvetYG
 oo4eqpTYhDw/Rx0E2LcCki2i1D5OhUD9uteMdaI6qZlDtDSZjoiNxb1vCo11m+SfMS9sUjlz8
 7cq7e1YND5hjCwU1gsKOWClMQd9RXreRGcud7uzYnafsZP+pQ2iXWf/Uwyu5alsNTP0w3N5U2
 aRzADYIlMEBRfmO+Tdp8yeemB1zkQynoGMb2QJjtEJZuRhq7U0tud3fzXUQ4qhudZHwxM85sD
 j0Hpw1oP5cbYI9N0d4r9IOB0dApnusNePC40tp6SZyE9tnAZzbMbD6c9+pAZdwMaIklgdUkbz
 7DedsYolqeb9bvjZlEHryWPUapEYQXkHESVb1Jzac7g4hwvonq73qnO0o3usvHyuwC/306ZjY
 L7m6pftMtrAfcpWLOrZJJocMEDlfOjektd2XQhPjvw==
Precedence: bulk

In case the QCA7000 is not available via SPI (e.g. in reset),
the driver will cause a high load. The reason for this is
that the synchronization is never finished and schedule()
is never called. Since the synchronization is not timing
critical, it's safe to drop this from the scheduling condition.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000")
---

Changes in V2:
- send from different account which doesn't break the patch

 drivers/net/ethernet/qualcomm/qca_spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index bba1947792ea16..90f18ea4c28ba1 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -582,8 +582,7 @@ qcaspi_spi_thread(void *data)
 	while (!kthread_should_stop()) {
 		set_current_state(TASK_INTERRUPTIBLE);
 		if ((qca->intr_req == qca->intr_svc) &&
-		    (qca->txr.skb[qca->txr.head] == NULL) &&
-		    (qca->sync == QCASPI_SYNC_READY))
+		    !qca->txr.skb[qca->txr.head])
 			schedule();
 
 		set_current_state(TASK_RUNNING);