Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614180837.630180-6-ojeda@kernel.org> <20230614203803.2910957-1-aliceryhl@google.com>
In-Reply-To: <20230614203803.2910957-1-aliceryhl@google.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 15 Jun 2023 00:09:00 +0200
Message-ID: <CANiq72n-WocEegVc2-Em6muU4pOTOh+Lf8RAwiAtjuUUjnysbQ@mail.gmail.com>
Subject: Re: [PATCH 5/6] rust: support running Rust documentation tests as
 KUnit ones
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     ojeda@kernel.org, alex.gaynor@gmail.com, benno.lossin@proton.me,
        bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
        brendan.higgins@linux.dev, davidgow@google.com, gary@garyguo.net,
        kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, nmi@metaspace.dk,
        patches@lists.linux.dev, philip.li@intel.com,
        rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 14, 2023 at 10:38=E2=80=AFPM Alice Ryhl <aliceryhl@google.com> =
wrote:
>
> This could just be
>
> std::fs::write(path, body.as_bytes());

+1, simpler, less `use`s needed and less size:

     320429      12736        368     333533      516dd
scripts/rustdoc_test_builder
     314701      12440        368     327509      4ff55
scripts/rustdoc_test_builder

Thanks for the review!

Cheers,
Miguel

diff --git a/scripts/rustdoc_test_builder.rs b/scripts/rustdoc_test_builder=
.rs
index e3b7138fb4f9..e5894652f12c 100644
--- a/scripts/rustdoc_test_builder.rs
+++ b/scripts/rustdoc_test_builder.rs
@@ -15,8 +15,7 @@
 //! from that. For the moment, we generate ourselves a new name,
`{file}_{number}` instead, in
 //! the `gen` script (done there since we need to be aware of all the
tests in a given file).

-use std::fs::File;
-use std::io::{BufWriter, Read, Write};
+use std::io::Read;

 fn main() {
     let mut stdin =3D std::io::stdin().lock();
@@ -69,5 +68,5 @@ fn main() {

     let path =3D format!("rust/test/doctests/kernel/{name}");

-    write!(BufWriter::new(File::create(path).unwrap()), "{body}").unwrap()=
;
+    std::fs::write(path, body.as_bytes()).unwrap();
 }