Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp299708rwd; Wed, 14 Jun 2023 16:22:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6H/XHa5HComf++aNSbz4SgoIeew2xYbPPjwJ57bsSEJLXd808IhrvBABXUiCAEWAfvdXWN X-Received: by 2002:a17:90b:3586:b0:256:991a:19e with SMTP id mm6-20020a17090b358600b00256991a019emr2418464pjb.9.1686784948881; Wed, 14 Jun 2023 16:22:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686784948; cv=none; d=google.com; s=arc-20160816; b=VsHc5EFN7uwtRnv49KPhV0DqEyts0X7SZfmsgPdjxYbzvWHGD9jK6NtY/qQhioowfE Q/0Dpt+6B9e3uZLsLCc4QowTTLML/nnvEWJsAKRLwykLACj1wnXQ1OS26S7mRvw56LPZ 4c+DdvAdJJY1xSPkQjQQQqY/13ULzRZ3dFJOhZ6dBtv3AvHdcZnSSaHX2iXw2s+LmWOH SBcpo7GhWrLysVdXgdkWQfWg9j2PdrNwG6FMOYT8bvsPXz30G46vbbT7eAjAWLNIyCv4 xVu8MbsvLtFqmKcN7NojDARQ91abdc/pJ9HvJKnx8Cfm2kgI6D+ClTEV4XEoK7LcGUZD q+fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=sHdvQZ7m6PxuN/USel8yVHaEF6p2iUl/FtGj/loZ4nU=; b=SgNtvGNmZt4dG6i1WgUnjBLI+zzrCMTNPLm2PO+UmQrBDxCbjZ0pVey07gJIQGhSdf dNHEXSRbNrw+vXRB39CS5sJgGuNHOXR1Cq2nIoHagZExf1ZUq8aGTsSKtwQEYTs4JSj9 ZwppBiIl8jBEgIbUsYaLndjwjMdRGpqZUHC8BXdraNxW0gLrH3kSUcOmFhDdyOuy2w0N mGAJFrFRWUyC5Vaq3ZIb9iuxnO2n+3S4WBTzqM+XFbMBBnhKZgVlzrLpJcgLf5AQ1hy8 zzEb5q5bMzqF2NknxDvYHbHuOi63jvHGxK8M41u7E5Oip5O/gApP1UeYyy3684rc5Cbn 2TMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a17090a734700b0025337db9e19si11670167pjs.156.2023.06.14.16.22.16; Wed, 14 Jun 2023 16:22:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236041AbjFNWuI (ORCPT + 99 others); Wed, 14 Jun 2023 18:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237201AbjFNWt7 (ORCPT ); Wed, 14 Jun 2023 18:49:59 -0400 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [5.144.164.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81BD61FCC for ; Wed, 14 Jun 2023 15:49:57 -0700 (PDT) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 583333F35F; Thu, 15 Jun 2023 00:49:55 +0200 (CEST) Date: Thu, 15 Jun 2023 00:49:53 +0200 From: Marijn Suijten To: Dmitry Baryshkov Cc: Jessica Zhang , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , quic_abhinavk@quicinc.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0 Message-ID: References: <20230525-add-widebus-support-v1-0-c7069f2efca1@quicinc.com> <20230525-add-widebus-support-v1-1-c7069f2efca1@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-06-14 14:23:38, Marijn Suijten wrote: > Tested this on SM8350 which actually has DSI 2.5, and it is also > corrupted with this series so something else on this series might be > broken. Never mind, this was a bad conflict-resolve. Jessica's original BURST_MODE patch was RMW'ing MDP_CTRL2, but the upstreamed patch was only writing, and the way I conflict-resolved that caused the write of BURST_MODE to overwrite the RMW DATABUS_WIDEN. If both are moved to dsi_ctrl_config(), we could do a read, add both flags in conditionally, and write. - Marijn