Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp338896rwd; Wed, 14 Jun 2023 17:07:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7OgQQ0oRt459/0pcxgJfwiuGodV+hJ+2iK+Pk+itfMw+qxVCKkKn1lZn9MF1aDftDviS2y X-Received: by 2002:a05:6808:1596:b0:398:7db6:7ee3 with SMTP id t22-20020a056808159600b003987db67ee3mr14338279oiw.19.1686787649826; Wed, 14 Jun 2023 17:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686787649; cv=none; d=google.com; s=arc-20160816; b=P/+CvT9sxMld5VbPRaDIrjD6DUYezoPcwdazEFkUww03jANSUQQelyACjAvULvu7+w rL8Ucy40e5Mc7KX6apmMjRIajfJ89gsyfs5cjEl0bHMhwcg49s5ORfD2VcjvQbxXX+mJ m0FMoMU/FI2wI5H0NGLbjfYEzlXI7XZsxxVPk+8iU57vIgivhDij8Ve3jaBj76jJaVg2 t/DVvUpvboRj4+AeHEkpb/nMhqvoqwAlL5N51xcYdAepTEFeWv9ywpytRbt7BKudI9Pu pRB/u305++vYf6UtM14GwJ+8n4WX7FT+oI38OPQW4DtqOsXTvrSa9OjevfqQrrfCVosO FDyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=em1Oy/ZXJogHXMF15eFq+xLsfAk1Tg9tnkKe6mZVrbk=; b=yzz9hur0Z9Ajz47d37zG7ttjvYDKrLwoPQ69dCNfxH6iIr3ORd/XWW021HskxImfkQ SPUjWORoc5jZZTTonTtRC9PPgjUnFhSREYd/bsVGSKtt9celCYWgShvknkaqIKEzGtX3 3DZMMGJ+cXXKKWwBFnmH6j6fqe7z4IWvQ25Utbh2u8u8JtdkYA2zkzyWTOQMw4pSGyZh ADfrLuh5Uirl6I9vu0hgOIUInCw3DK6PXX1rzsCTBfIMfiGZoCohfHKRjaOk5TAZNg/m P6WiUYl2QcO7kS7wWBVSWtY62+8pK7ikbm3DHvuKWziOMDzE7wBsAefzqmzoPaP8Bpn+ mrkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=KDKzgmlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a17090ac90e00b002470ea7f67fsi13640360pjt.3.2023.06.14.17.07.17; Wed, 14 Jun 2023 17:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=KDKzgmlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236802AbjFNX40 (ORCPT + 99 others); Wed, 14 Jun 2023 19:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbjFNX4W (ORCPT ); Wed, 14 Jun 2023 19:56:22 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 241071FD4; Wed, 14 Jun 2023 16:56:22 -0700 (PDT) Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35ENlh3V026988; Wed, 14 Jun 2023 23:55:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=em1Oy/ZXJogHXMF15eFq+xLsfAk1Tg9tnkKe6mZVrbk=; b=KDKzgmlYEHwwvkRA5T771c4ageC8lnPTLK4j/zQ7Uaacd9fu1Q3Vk4OYyUxjx6IyucgG YfZAWkCOz/Na90oFKgmJg20XYd+oAPpCugMMfOZ5NWvBiX3PpImHqEN70gjpARaZDDGc zqy+SXe7JSrR1p1V3UEVmsAA6GSfbDnfEcM927tYRU6/HLoZKV3ARvtCwfwBA2KFzQa+ 3omZAsIjMd6/VjazBWEP8/lpqnRHvX5CChsXfsZu9AxL4YjUX0D4VSUH29LhXCWxHFvC KiMRHNoQdAKJseWFhXTDruihxH12pZTgF2/WqIqf+cdBSL3FxlGIdDqecuFLRpoSQFMp ZA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r7qhf847m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 23:55:51 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35ENnFtF030725; Wed, 14 Jun 2023 23:55:51 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r7qhf847a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 23:55:51 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35EKfiFC002759; Wed, 14 Jun 2023 23:55:50 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([9.208.130.102]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3r4gt5g4qe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 23:55:49 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35ENtmjS56295736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Jun 2023 23:55:49 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB5B958053; Wed, 14 Jun 2023 23:55:48 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E82FA58043; Wed, 14 Jun 2023 23:55:46 +0000 (GMT) Received: from li-f45666cc-3089-11b2-a85c-c57d1a57929f.ibm.com (unknown [9.61.19.215]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 14 Jun 2023 23:55:46 +0000 (GMT) Message-ID: <6af688eba06f6a89632fbf4afcd47cbb8c790183.camel@linux.ibm.com> Subject: Re: [PATCH v12 4/4] evm: Support multiple LSMs providing an xattr From: Mimi Zohar To: Roberto Sassu , dmitry.kasatkin@gmail.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, kpsingh@kernel.org, keescook@chromium.org, nicolas.bouchinet@clip-os.org, Roberto Sassu Date: Wed, 14 Jun 2023 19:55:46 -0400 In-Reply-To: <20230610075738.3273764-5-roberto.sassu@huaweicloud.com> References: <20230610075738.3273764-1-roberto.sassu@huaweicloud.com> <20230610075738.3273764-5-roberto.sassu@huaweicloud.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2rTFnRN5fpu42bPG-G4_Qq-LcYHFpQSx X-Proofpoint-GUID: 72iNxXHhB3aam4APkdBzXTGgPwL2_OO5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-14_14,2023-06-14_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306140206 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2023-06-10 at 09:57 +0200, Roberto Sassu wrote: > From: Roberto Sassu > > Currently, evm_inode_init_security() processes a single LSM xattr from the > array passed by security_inode_init_security(), and calculates the HMAC on > it and other inode metadata. > > As the LSM infrastructure now can pass to EVM an array with multiple > xattrs, scan them until the terminator (xattr name NULL), and calculate the > HMAC on all of them. > > Also, double check that the xattrs array terminator is the first non-filled > slot (obtained with lsm_get_xattr_slot()). Consumers of the xattrs array, > such as the initxattrs() callbacks, rely on the terminator. > > Finally, change the name of the lsm_xattr parameter of evm_init_hmac() to > xattrs, to reflect the new type of information passed. > > Signed-off-by: Roberto Sassu > Reviewed-by: Mimi Zohar Thanks, Roberto! Acked-by: Mimi Zohar