Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp374980rwd; Wed, 14 Jun 2023 17:48:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ74VmeHK13F1S4orSygrUN62fgZdzxw3YkCUVVtf38GuTQiMnAM/v5A84DIUxPYkA7jHEL9 X-Received: by 2002:a50:fe84:0:b0:518:4ac0:d975 with SMTP id d4-20020a50fe84000000b005184ac0d975mr5334004edt.3.1686790117881; Wed, 14 Jun 2023 17:48:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686790117; cv=none; d=google.com; s=arc-20160816; b=bGDn36DNceKIqeDqUdnlcJbqB+wJ07Jsf59MplSJVf8KSpShK6AkA2pViQzwmU4O9P fyO1BrHunsBSWv+laej7laxYZy0sKef9Juq0gTlE0AXBHp1kRwy+BK8swK8o9ghVinyL PfI6LolFz9zfBP3CTXWK4vFrLW4cjSFCa32T7JEJDH1qopZCQ5NdK/OZfHbhPvMQR4AH E2/ezUqQmTuiXHE+fsLkSIwHG1fTxjV1c4KD0x6Of7+qOL+CCG6NwlmtAXLlxeqRkSim BgJZyneSlQTnjn5V9tm7LsX2w95TnForJuQ4GbKtBFvKHiXU5Oe3DZPnPyzFiHClLRVG 6YDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=pdaOGQKnCwrYyacOrxmVFnlnZMcpLs+PJTif44O1uR0=; b=BeSaBuNBpnyoHmeGSMmWum1x3y+goz9biWiKJYPITUqt7La7BRXZ8BQr0MBtQraERK aXMgP+RzNCIddwoLYmSq/XssnsAx3geUXegH32leGVZ2/xLMJ3uyUteGBaa6Skqx3e+r mLVpE999HFXpNqwev8oXYWvnY/3B9GMbOp0+0cQmRd3JmzJEzeIADhESSTroE3GerCR9 ktYkY7NNHW62ETDpOamkT6T2DFiopJUnv3pwZ+5P+sIxiH0cvR85O7Jqs94TmanxcOWx e0uz8NGCZuTEk+PAfwUY19fh7Te5MnvRwx1wL+47rYmoQEqFy23ntKZFotVQVvzcQiYW rjcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f0lLNBjN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020aa7cf04000000b00514b9801aa5si5689165edy.271.2023.06.14.17.48.13; Wed, 14 Jun 2023 17:48:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f0lLNBjN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236509AbjFOAW2 (ORCPT + 99 others); Wed, 14 Jun 2023 20:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbjFOAWZ (ORCPT ); Wed, 14 Jun 2023 20:22:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF22E3; Wed, 14 Jun 2023 17:22:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58FB56203F; Thu, 15 Jun 2023 00:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABF0AC433C8; Thu, 15 Jun 2023 00:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686788543; bh=pdaOGQKnCwrYyacOrxmVFnlnZMcpLs+PJTif44O1uR0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=f0lLNBjNHuUdXomi5Y3CJsmSEoBOOkx/xyi3iWuNN1mKcAjsmpA/0X2PCfGKHofaW SwaDp1NHBvOBFA+dF/7JHsdd93ZLCnYhBdhPITLDmtKm86N6bta0VpyCtmIkIB2bW3 1L5TrNX77olRf92ciD3uwJIwqRz/RGvja6j5y10Yb4oAqh/RJESXiCiUfh/o1hO8bt 6wN7yqDfuqcOyJKTAV3LF/JDpI7ynqzX/Od3nuAig096IgE5YOfO/rAdByuwtDIoE2 FO0WbrVzcKib3hn1stoarPop/B2qHdptSqz9HWEP4YZl8tKv6Jj4sNkf3GBNm+qxQO txpjX4BE1jE2A== Message-ID: <8eceb50391ff83f598e16e0cb371fdb0.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230511105845.299859-1-arnd@kernel.org> References: <20230511105845.299859-1-arnd@kernel.org> Subject: Re: [PATCH] clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr From: Stephen Boyd Cc: Arnd Bergmann , stable@vger.kernel.org, kernel test robot , Nathan Chancellor , Nick Desaulniers , Tom Rix , Robert Jarzmik , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev To: Arnd Bergmann , Michael Turquette Date: Wed, 14 Jun 2023 17:22:21 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Arnd Bergmann (2023-05-11 03:58:33) > From: Arnd Bergmann >=20 > sparse points out an embarrasing bug in an older patch of mine, > which uses the register offset instead of an __iomem pointer: >=20 > drivers/clk/pxa/clk-pxa3xx.c:167:9: sparse: sparse: Using plain integer a= s NULL pointer >=20 > Unlike sparse, gcc and clang ignore this bug and fail to warn > because a literal '0' is considered a valid representation of > a NULL pointer. >=20 > Fixes: 3c816d950a49 ("ARM: pxa: move clk register definitions to driver") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202305111301.RAHohdob-lkp@int= el.com/ > Signed-off-by: Arnd Bergmann > --- Applied to clk-fixes